From: "gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org" <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Cc: Oleksandr Shamray
<oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org"
<jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>,
'Chip Bilbrey' <chip-Gz1Ta9Qd61ZAfugRpC6u6w@public.gmane.org>,
"arnd-r2nGTMty4D4@public.gmane.org"
<arnd-r2nGTMty4D4@public.gmane.org>,
"linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org"
<openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
"mec-WqBc5aa1uDFeoWH0uzbU5w@public.gmane.org"
<mec-WqBc5aa1uDFeoWH0uzbU5w@public.gmane.org>,
Jiri Pirko <jiri-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
"robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
"joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org"
<joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org>,
"linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org"
<tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org>,
"mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org"
<mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [v11,1/4] drivers: jtag: Add JTAG core driver
Date: Tue, 14 Nov 2017 12:31:44 +0100 [thread overview]
Message-ID: <20171114113144.GA25234@kroah.com> (raw)
In-Reply-To: <20171114111916.GO12318-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
On Tue, Nov 14, 2017 at 11:19:16AM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 14, 2017 at 12:10:46PM +0100, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org wrote:
> > On Tue, Nov 14, 2017 at 10:34:49AM +0000, Oleksandr Shamray wrote:
> > > Greg, what you can suggest about it. May be better to add again single-open()-per-device lock with right locking way like:
> > >
> > > >if (mutex_lock_interruptible(&jtag->open_lock)) {
> >
> > You would stall an open? Why not just return saying you can't do that?
>
> Greg, I think you need to look at the code again.
Heh, sorry, I probably got it wrong. I'll be glad to review it in a
real patch when needed, but not in the middle of the merge window :)
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Oleksandr Shamray <oleksandrs@mellanox.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
'Chip Bilbrey' <chip@bilbrey.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"linux-api@vger.kernel.org" <linux-api@vger.kernel.org>,
"openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"openocd-devel-owner@lists.sourceforge.net"
<openocd-devel-owner@lists.sourceforge.net>,
"mec@shout.net" <mec@shout.net>, Jiri Pirko <jiri@mellanox.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"joel@jms.id.au" <joel@jms.id.au>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"tklauser@distanz.ch" <tklauser@distanz.ch>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [v11,1/4] drivers: jtag: Add JTAG core driver
Date: Tue, 14 Nov 2017 12:31:44 +0100 [thread overview]
Message-ID: <20171114113144.GA25234@kroah.com> (raw)
In-Reply-To: <20171114111916.GO12318@n2100.armlinux.org.uk>
On Tue, Nov 14, 2017 at 11:19:16AM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 14, 2017 at 12:10:46PM +0100, gregkh@linuxfoundation.org wrote:
> > On Tue, Nov 14, 2017 at 10:34:49AM +0000, Oleksandr Shamray wrote:
> > > Greg, what you can suggest about it. May be better to add again single-open()-per-device lock with right locking way like:
> > >
> > > >if (mutex_lock_interruptible(&jtag->open_lock)) {
> >
> > You would stall an open? Why not just return saying you can't do that?
>
> Greg, I think you need to look at the code again.
Heh, sorry, I probably got it wrong. I'll be glad to review it in a
real patch when needed, but not in the middle of the merge window :)
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org (gregkh at linuxfoundation.org)
To: linux-arm-kernel@lists.infradead.org
Subject: [v11,1/4] drivers: jtag: Add JTAG core driver
Date: Tue, 14 Nov 2017 12:31:44 +0100 [thread overview]
Message-ID: <20171114113144.GA25234@kroah.com> (raw)
In-Reply-To: <20171114111916.GO12318@n2100.armlinux.org.uk>
On Tue, Nov 14, 2017 at 11:19:16AM +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 14, 2017 at 12:10:46PM +0100, gregkh at linuxfoundation.org wrote:
> > On Tue, Nov 14, 2017 at 10:34:49AM +0000, Oleksandr Shamray wrote:
> > > Greg, what you can suggest about it. May be better to add again single-open()-per-device lock with right locking way like:
> > >
> > > >if (mutex_lock_interruptible(&jtag->open_lock)) {
> >
> > You would stall an open? Why not just return saying you can't do that?
>
> Greg, I think you need to look at the code again.
Heh, sorry, I probably got it wrong. I'll be glad to review it in a
real patch when needed, but not in the middle of the merge window :)
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-14 11:31 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-03 15:54 [patch v11 0/4] JTAG driver introduction Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` [patch v11 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
[not found] ` <1509724449-26221-1-git-send-email-oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-11-03 15:54 ` [patch v11 1/4] drivers: jtag: Add JTAG core driver Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
[not found] ` <1509724449-26221-2-git-send-email-oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-11-04 11:36 ` Greg KH
2017-11-04 11:36 ` Greg KH
2017-11-04 11:36 ` Greg KH
2017-11-05 22:32 ` [v11,1/4] " Chip Bilbrey
2017-11-05 22:32 ` Chip Bilbrey
2017-11-05 22:32 ` Chip Bilbrey
2017-11-06 14:28 ` Oleksandr Shamray
2017-11-06 14:28 ` Oleksandr Shamray
2017-11-06 14:28 ` Oleksandr Shamray
[not found] ` <8760aoz78q.fsf-Gz1Ta9Qd61ZAfugRpC6u6w@public.gmane.org>
2017-11-14 10:34 ` Oleksandr Shamray
2017-11-14 10:34 ` Oleksandr Shamray
2017-11-14 10:34 ` Oleksandr Shamray
2017-11-14 11:10 ` gregkh
2017-11-14 11:10 ` gregkh at linuxfoundation.org
2017-11-14 11:10 ` gregkh
[not found] ` <20171114111046.GA23820-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-14 11:19 ` Russell King - ARM Linux
2017-11-14 11:19 ` Russell King - ARM Linux
2017-11-14 11:19 ` Russell King - ARM Linux
2017-11-14 11:19 ` Russell King - ARM Linux
[not found] ` <20171114111916.GO12318-l+eeeJia6m9URfEZ8mYm6t73F7V6hmMc@public.gmane.org>
2017-11-14 11:31 ` gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r [this message]
2017-11-14 11:31 ` gregkh at linuxfoundation.org
2017-11-14 11:31 ` gregkh
2017-11-03 15:54 ` [patch v11 3/4] Documentation: jtag: Add bindings for Aspeed SoC 24xx and 25xx families JTAG master driver Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` [patch v11 4/4] Documentation: jtag: Add ABI documentation Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-03 15:54 ` Oleksandr Shamray
2017-11-07 10:36 ` Tobias Klauser
2017-11-07 10:36 ` Tobias Klauser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171114113144.GA25234@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=chip-Gz1Ta9Qd61ZAfugRpC6u6w@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=jiri-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org \
--cc=joel-U3u1mxZcP9KHXe+LvDLADg@public.gmane.org \
--cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=mec-WqBc5aa1uDFeoWH0uzbU5w@public.gmane.org \
--cc=oleksandrs-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
--cc=openbmc-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org \
--cc=openocd-devel-owner-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tklauser-93Khv+1bN0NyDzI6CaY1VQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.