* [PATCH FOR CI v2] drm/i915: Generalize transcoder looping
@ 2017-11-09 8:37 Mika Kahola
2017-11-09 8:59 ` ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3) Patchwork
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Mika Kahola @ 2017-11-09 8:37 UTC (permalink / raw)
To: intel-gfx
To make looping through transcoders in intel_ddi.c more generic, let's switch
to use 'for_each_pipe()' macro to do this.
v2: Add a notion that we are dealing with transcoders instead of pipes (Jani)
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
---
drivers/gpu/drm/i915/intel_ddi.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
index ace674c..31ef376 100644
--- a/drivers/gpu/drm/i915/intel_ddi.c
+++ b/drivers/gpu/drm/i915/intel_ddi.c
@@ -1681,8 +1681,8 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
struct drm_device *dev = encoder->base.dev;
struct drm_i915_private *dev_priv = to_i915(dev);
enum port port = encoder->port;
+ enum pipe p;
u32 tmp;
- int i;
bool ret;
if (!intel_display_power_get_if_enabled(dev_priv,
@@ -1717,15 +1717,17 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
goto out;
}
- for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
- tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
+ for_each_pipe(dev_priv, p) {
+ enum transcoder cpu_transcoder = (enum transcoder) p;
+
+ tmp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {
if ((tmp & TRANS_DDI_MODE_SELECT_MASK) ==
TRANS_DDI_MODE_SELECT_DP_MST)
goto out;
- *pipe = i;
+ *pipe = p;
ret = true;
goto out;
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3)
2017-11-09 8:37 [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Mika Kahola
@ 2017-11-09 8:59 ` Patchwork
2017-11-09 9:46 ` ✓ Fi.CI.IGT: success " Patchwork
2017-11-14 14:26 ` [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Ville Syrjälä
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-11-09 8:59 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Generalize transcoder looping (rev3)
URL : https://patchwork.freedesktop.org/series/32965/
State : warning
== Summary ==
Series 32965v3 drm/i915: Generalize transcoder looping
https://patchwork.freedesktop.org/api/1.0/series/32965/revisions/3/mbox/
Test kms_busy:
Subgroup basic-flip-a:
pass -> FAIL (fi-gdg-551) fdo#102654 +1
Test kms_pipe_crc_basic:
Subgroup nonblocking-crc-pipe-a:
pass -> SKIP (fi-hsw-4770r)
fdo#102654 https://bugs.freedesktop.org/show_bug.cgi?id=102654
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:443s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:452s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:382s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:537s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:275s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:499s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:505s
fi-byt-j1900 total:289 pass:254 dwarn:0 dfail:0 fail:0 skip:35 time:495s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:488s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:429s
fi-gdg-551 total:289 pass:176 dwarn:1 dfail:0 fail:3 skip:109 time:261s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:539s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:429s
fi-hsw-4770r total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:444s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:425s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:480s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:486s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:521s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:476s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:532s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:567s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:466s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:543s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:562s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:513s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:493s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:463s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:559s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:421s
Blacklisted hosts:
fi-cnl-y total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:556s
1446a30948d7c5570e5cfc40678dbdd74e152498 drm-tip: 2017y-11m-08d-21h-46m-48s UTC integration manifest
77ad65772a21 drm/i915: Generalize transcoder looping
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7026/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* ✓ Fi.CI.IGT: success for drm/i915: Generalize transcoder looping (rev3)
2017-11-09 8:37 [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Mika Kahola
2017-11-09 8:59 ` ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3) Patchwork
@ 2017-11-09 9:46 ` Patchwork
2017-11-14 14:26 ` [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Ville Syrjälä
2 siblings, 0 replies; 4+ messages in thread
From: Patchwork @ 2017-11-09 9:46 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Generalize transcoder looping (rev3)
URL : https://patchwork.freedesktop.org/series/32965/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup basic:
skip -> PASS (shard-hsw) fdo#103167
Test kms_busy:
Subgroup extended-modeset-hang-oldfb-with-reset-render-a:
dmesg-warn -> PASS (shard-hsw) fdo#102249 +1
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#102249 https://bugs.freedesktop.org/show_bug.cgi?id=102249
shard-hsw total:2540 pass:1432 dwarn:1 dfail:0 fail:10 skip:1097 time:9253s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_7026/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH FOR CI v2] drm/i915: Generalize transcoder looping
2017-11-09 8:37 [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Mika Kahola
2017-11-09 8:59 ` ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3) Patchwork
2017-11-09 9:46 ` ✓ Fi.CI.IGT: success " Patchwork
@ 2017-11-14 14:26 ` Ville Syrjälä
2 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2017-11-14 14:26 UTC (permalink / raw)
To: Mika Kahola; +Cc: intel-gfx
On Thu, Nov 09, 2017 at 10:37:50AM +0200, Mika Kahola wrote:
> To make looping through transcoders in intel_ddi.c more generic, let's switch
> to use 'for_each_pipe()' macro to do this.
>
> v2: Add a notion that we are dealing with transcoders instead of pipes (Jani)
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Pushed to dinq. Thanks for the patch.
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index ace674c..31ef376 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1681,8 +1681,8 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
> struct drm_device *dev = encoder->base.dev;
> struct drm_i915_private *dev_priv = to_i915(dev);
> enum port port = encoder->port;
> + enum pipe p;
> u32 tmp;
> - int i;
> bool ret;
>
> if (!intel_display_power_get_if_enabled(dev_priv,
> @@ -1717,15 +1717,17 @@ bool intel_ddi_get_hw_state(struct intel_encoder *encoder,
> goto out;
> }
>
> - for (i = TRANSCODER_A; i <= TRANSCODER_C; i++) {
> - tmp = I915_READ(TRANS_DDI_FUNC_CTL(i));
> + for_each_pipe(dev_priv, p) {
> + enum transcoder cpu_transcoder = (enum transcoder) p;
> +
> + tmp = I915_READ(TRANS_DDI_FUNC_CTL(cpu_transcoder));
>
> if ((tmp & TRANS_DDI_PORT_MASK) == TRANS_DDI_SELECT_PORT(port)) {
> if ((tmp & TRANS_DDI_MODE_SELECT_MASK) ==
> TRANS_DDI_MODE_SELECT_DP_MST)
> goto out;
>
> - *pipe = i;
> + *pipe = p;
> ret = true;
>
> goto out;
> --
> 2.7.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-14 14:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-09 8:37 [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Mika Kahola
2017-11-09 8:59 ` ✗ Fi.CI.BAT: warning for drm/i915: Generalize transcoder looping (rev3) Patchwork
2017-11-09 9:46 ` ✓ Fi.CI.IGT: success " Patchwork
2017-11-14 14:26 ` [PATCH FOR CI v2] drm/i915: Generalize transcoder looping Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.