From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: Fix error handling paths in order to avoid memory leaks
Date: Wed, 15 Nov 2017 07:23:51 +0000 [thread overview]
Message-ID: <20171115072351.GC22677@builder> (raw)
In-Reply-To: <20171115065835.14525-1-christophe.jaillet@wanadoo.fr>
On Tue 14 Nov 22:58 PST 2017, Christophe JAILLET wrote:
> In case of error returned by 'q6v5_xfer_mem_ownership', we must free
> some resources before returning.
>
> In 'q6v5_mpss_init_image()', add a new label to undo a previous
> 'dma_alloc_attrs()'.
> In 'q6v5_mpss_load()', re-use the already existing error handling code to
> undo a previous 'request_firmware()', as already done in the other error
> handling paths of the function.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks!
Regards,
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: ohad@wizery.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] remoteproc: qcom: Fix error handling paths in order to avoid memory leaks
Date: Tue, 14 Nov 2017 23:23:51 -0800 [thread overview]
Message-ID: <20171115072351.GC22677@builder> (raw)
In-Reply-To: <20171115065835.14525-1-christophe.jaillet@wanadoo.fr>
On Tue 14 Nov 22:58 PST 2017, Christophe JAILLET wrote:
> In case of error returned by 'q6v5_xfer_mem_ownership', we must free
> some resources before returning.
>
> In 'q6v5_mpss_init_image()', add a new label to undo a previous
> 'dma_alloc_attrs()'.
> In 'q6v5_mpss_load()', re-use the already existing error handling code to
> undo a previous 'request_firmware()', as already done in the other error
> handling paths of the function.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks!
Regards,
Bjorn
next prev parent reply other threads:[~2017-11-15 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 6:58 [PATCH] remoteproc: qcom: Fix error handling paths in order to avoid memory leaks Christophe JAILLET
2017-11-15 6:58 ` Christophe JAILLET
2017-11-15 7:23 ` Bjorn Andersson [this message]
2017-11-15 7:23 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171115072351.GC22677@builder \
--to=bjorn.andersson@linaro.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.