From: Andrew Lunn <andrew@lunn.ch>
To: Sarah Newman <srn@prgmr.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH] net: bridge: add max_fdb_count
Date: Thu, 16 Nov 2017 04:01:07 +0100 [thread overview]
Message-ID: <20171116030107.GI2130@lunn.ch> (raw)
In-Reply-To: <1510774027-2468-1-git-send-email-srn@prgmr.com>
> @@ -556,6 +559,10 @@ void br_fdb_update(struct net_bridge *br, struct net_bridge_port *source,
> if (hold_time(br) == 0)
> return;
>
> + /* Place maximum on number of learned entries. */
> + if (br->max_fdb_count <= br->fdb_count)
> + return;
> +
Hi Sarah
We probably want a rate limited warning printed here. If the table is
full, it will have to start flooding frames, which is not good for
performance. Having something in the log will help debug the problem.
The log will also give a hit that a DoS attack could be happening.
Andrew
next prev parent reply other threads:[~2017-11-16 3:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-15 19:27 [PATCH] net: bridge: add max_fdb_count Sarah Newman
2017-11-15 19:43 ` Sarah Newman
2017-11-15 20:04 ` Stephen Hemminger
2017-11-16 2:25 ` Andrew Lunn
2017-11-16 4:05 ` Toshiaki Makita
2017-11-16 4:54 ` Sarah Newman
2017-11-16 6:13 ` Toshiaki Makita
2017-11-16 6:20 ` Roopa Prabhu
2017-11-16 16:54 ` Stephen Hemminger
2017-11-15 21:34 ` Egil Hjelmeland
2017-11-16 3:01 ` Andrew Lunn [this message]
2017-11-16 7:31 ` Nikolay Aleksandrov
2017-11-16 9:20 ` Sarah Newman
2017-11-16 9:49 ` Nikolay Aleksandrov
2017-11-16 9:58 ` Willy Tarreau
2017-11-16 18:23 ` Sarah Newman
2017-11-16 19:23 ` Andrew Lunn
2017-11-16 19:36 ` Nikolay Aleksandrov
2017-11-16 20:54 ` Sarah Newman
2017-11-16 20:21 ` Vincent Bernat
2017-11-17 0:27 ` Stephen Hemminger
2017-11-17 5:26 ` Willy Tarreau
2017-11-17 6:14 ` Nikolay Aleksandrov
2017-11-17 8:01 ` Nikolay Aleksandrov
2017-11-17 14:06 ` Andrew Lunn
2017-11-17 18:44 ` Willy Tarreau
2017-11-21 14:53 ` David Laight
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171116030107.GI2130@lunn.ch \
--to=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
--cc=srn@prgmr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.