All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver
Date: Thu, 16 Nov 2017 08:55:10 -0800	[thread overview]
Message-ID: <20171116165510.GP28761@minitux> (raw)
In-Reply-To: <1510834717-21765-2-git-send-email-kgunda@codeaurora.org>

On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:

> WLED driver provides the interface to the display driver to
> adjust the brightness of the display backlight.
> 

Hi Kiran,

This driver has a lot in common with the already upstream pm8941-wled.c,
because it's just a new revision of the same block.

Please extend the existing driver rather than providing a new one
(and yes, renaming the file is okay).

Regards,
Bjorn

WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Kiran Gunda <kgunda@codeaurora.org>
Cc: linux-arm-msm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Jingoo Han <jingoohan1@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Jacek Anaszewski <jacek.anaszewski@gmail.com>,
	Pavel Machek <pavel@ucw.cz>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
	linux-arm-msm-owner@vger.kernel.org
Subject: Re: [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver
Date: Thu, 16 Nov 2017 16:55:10 +0000	[thread overview]
Message-ID: <20171116165510.GP28761@minitux> (raw)
In-Reply-To: <1510834717-21765-2-git-send-email-kgunda@codeaurora.org>

On Thu 16 Nov 04:18 PST 2017, Kiran Gunda wrote:

> WLED driver provides the interface to the display driver to
> adjust the brightness of the display backlight.
> 

Hi Kiran,

This driver has a lot in common with the already upstream pm8941-wled.c,
because it's just a new revision of the same block.

Please extend the existing driver rather than providing a new one
(and yes, renaming the file is okay).

Regards,
Bjorn

  reply	other threads:[~2017-11-16 16:55 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 12:18 [PATCH V1 0/4] qcom: spmi-wled: Support for QCOM wled driver Kiran Gunda
2017-11-16 12:18 ` [PATCH V1 2/4] qcom: spmi-wled: Add support for short circuit handling Kiran Gunda
2017-11-16 12:30   ` Kiran Gunda
     [not found]   ` <1510834717-21765-3-git-send-email-kgunda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-17 20:30     ` Rob Herring
2017-11-17 20:30       ` Rob Herring
2017-11-17 20:30       ` Rob Herring
2017-11-20 11:42       ` kgunda
2017-11-20 11:54         ` kgunda
2017-12-05  4:35     ` Bjorn Andersson
2017-12-05  4:35       ` Bjorn Andersson
2017-12-05  4:35       ` Bjorn Andersson
2017-12-11  9:28       ` kgunda
2017-12-11  9:40         ` kgunda
2017-11-16 12:18 ` [PATCH V1 3/4] qcom: spmi-wled: Add support for OVP interrupt handling Kiran Gunda
2017-11-16 12:30   ` Kiran Gunda
     [not found]   ` <1510834717-21765-4-git-send-email-kgunda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-05  4:45     ` Bjorn Andersson
2017-12-05  4:45       ` Bjorn Andersson
2017-12-05  4:45       ` Bjorn Andersson
2017-12-11  9:31       ` kgunda
2017-12-11  9:43         ` kgunda
     [not found] ` <1510834717-21765-1-git-send-email-kgunda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-11-16 12:18   ` [PATCH V1 1/4] qcom: spmi-wled: Add support for qcom wled driver Kiran Gunda
2017-11-16 12:30     ` Kiran Gunda
2017-11-16 12:18     ` Kiran Gunda
2017-11-16 16:55     ` Bjorn Andersson [this message]
2017-11-16 16:55       ` Bjorn Andersson
2017-11-17  6:36       ` kgunda
2017-11-17  6:48         ` kgunda
2017-11-17  6:56         ` Bjorn Andersson
2017-11-17  6:56           ` Bjorn Andersson
2017-11-17  8:33           ` Lee Jones
2017-11-17  8:33             ` Lee Jones
2017-11-17 11:01             ` kgunda
2017-11-17 11:13               ` kgunda
2017-11-17  9:52           ` kgunda-sgV2jX0FEOL9JmXXK+q4OQ
2017-11-17  9:52             ` kgunda
2017-11-17  9:52             ` kgunda
2017-11-17 20:28     ` Rob Herring
2017-11-17 20:28       ` Rob Herring
2017-12-05  2:01     ` Bjorn Andersson
2017-12-05  2:01       ` Bjorn Andersson
2017-12-11  9:11       ` kgunda
2017-12-11  9:23         ` kgunda
     [not found]     ` <1510834717-21765-2-git-send-email-kgunda-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2017-12-15 20:30       ` Pavel Machek
2017-12-15 20:30         ` Pavel Machek
2017-12-15 20:30         ` Pavel Machek
2017-11-16 12:18   ` [PATCH V1 4/4] qcom: spmi-wled: Add auto-calibration logic support Kiran Gunda
2017-11-16 12:30     ` Kiran Gunda
2017-11-16 12:18     ` Kiran Gunda
2017-12-05  5:40     ` Bjorn Andersson
2017-12-05  5:40       ` Bjorn Andersson
2018-04-19 10:45       ` kgunda
2018-04-19 10:57         ` kgunda
2018-04-19 15:58         ` Bjorn Andersson
2018-04-19 15:58           ` Bjorn Andersson
2018-04-20  5:43           ` kgunda
2018-04-20  5:55             ` kgunda
2018-04-20 16:03             ` Bjorn Andersson
2018-04-20 16:03               ` Bjorn Andersson
2018-04-23 11:26               ` kgunda
2018-04-23 11:38                 ` kgunda
2018-04-23 10:35             ` kgunda
2018-04-23 10:47               ` kgunda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171116165510.GP28761@minitux \
    --to=bjorn.andersson@linaro.org \
    --cc=b.zolnierkie@samsung.com \
    --cc=daniel.thompson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jacek.anaszewski@gmail.com \
    --cc=jingoohan1@gmail.com \
    --cc=kgunda@codeaurora.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-msm-owner@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=pavel@ucw.cz \
    --cc=robh+dt@kernel.org \
    --cc=rpurdie@rpsys.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.