All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Chris Chiu <chiu@endlessm.com>
Cc: Daniel Drake <drake@endlessm.com>,
	heikki.krogerus@linux.intel.com, linux-gpio@vger.kernel.org,
	Linux Kernel <linux-kernel@vger.kernel.org>,
	Endless Linux Upstreaming Team <linux@endlessm.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad
Date: Fri, 17 Nov 2017 15:35:18 +0200	[thread overview]
Message-ID: <20171117133518.GF17200@lahna.fi.intel.com> (raw)
In-Reply-To: <CAB4CAwcELV0LWeeBCP9MYt0i=W2sy_Cspwm2vD3K8az+hApQ3g@mail.gmail.com>

On Fri, Nov 17, 2017 at 09:21:48PM +0800, Chris Chiu wrote:
> On Fri, Nov 17, 2017 at 7:00 PM, Mika Westerberg
> <mika.westerberg@linux.intel.com> wrote:
> > On Fri, Nov 17, 2017 at 06:01:27PM +0800, Chris Chiu wrote:
> >> Hi Mika,
> >>     Here's the full dmesg log you need. The touchpad stop reporting at
> >> the last of the log.
> >> https://gist.github.com/mschiu77/a0b8d24a586a228c55eca30c87c71d41
> >
> > Thanks!
> >
> > I did not spot anything suspicious in the i2c-hid initialization. When
> > the issue happens, can you check what the pin state is and if it changes
> > when you use the touchpad? If I read your ACPI tables right, something
> > like this:
> >
> >   # grep GPIO_18 /sys/kernel/debug/pinctrl/INT3452:00/pins
> >
> > (it could be another INT3452:* device as well).
> >
> > The GPIO line should be high and when the touchpad is pressed it should
> > go low.
> >
> > Then another thing, if you unload i2c-hid and load it back, does it
> > start working again?
> >
> >   # modprobe -r i2c-hid
> >   # modprobe i2c-hid
> 
> Yup. We did the same inspection on /sys/kernel/debug/pinctrl/INT3452:00/pins
> before and after the touchpad stop working.
> Before touchpad stop working, most of the results would be
> pin 18 (GPIO_18) GPIO 0x40900102 0x00024075
> After touchpad stop working, the result would always be
> pin 18 (GPIO_18) GPIO 0x40900100 0x00024075

OK, so the line (as being active low) gets pulled to low and is never
released back.

Does /proc/interrupts show that the interrupt counts are still
increasing (for both the GPIO driver and the touchpad)?

  reply	other threads:[~2017-11-17 13:35 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16 11:38 intel-gpio interrupts stop firing with Focaltech I2C-HID touchpad Daniel Drake
2017-11-16 11:52 ` Mika Westerberg
2017-11-16 12:01   ` Daniel Drake
2017-11-16 13:07     ` Mika Westerberg
2017-11-17  8:27       ` Chris Chiu
2017-11-17  8:50         ` Chris Chiu
2017-11-17  9:11         ` Mika Westerberg
2017-11-17  9:13           ` Chris Chiu
2017-11-17 10:01             ` Chris Chiu
2017-11-17 11:00               ` Mika Westerberg
2017-11-17 13:21                 ` Chris Chiu
2017-11-17 13:35                   ` Mika Westerberg [this message]
2017-11-17 13:52                     ` Mika Westerberg
2017-11-20  5:18                       ` Chris Chiu
2017-11-20 10:32                         ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171117133518.GF17200@lahna.fi.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=chiu@endlessm.com \
    --cc=drake@endlessm.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@endlessm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.