* [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
@ 2017-11-17 14:16 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-11-17 14:16 UTC (permalink / raw)
To: Patrik Jakobsson, David Airlie
Cc: linux-kernel, dri-devel, Philippe Ombredanne
There is no need to #define the license of the driver, just put it in
the MODULE_LICENSE() line directly as a text string.
This allows tools that check that the module license matches the source
code license to work properly, as there is no need to unwind the
unneeded dereference, especially when the string is defined in a .h file
far away from the .c file it is used in.
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/gpu/drm/gma500/psb_drv.c | 2 +-
drivers/gpu/drm/gma500/psb_drv.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 37a3be71acd9..8f5cc1f471cd 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -527,4 +527,4 @@ module_exit(psb_exit);
MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE(DRIVER_LICENSE);
+MODULE_LICENSE("GPL");
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 821497dbd3fc..4918efc57b7a 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -36,7 +36,6 @@
#include "mmu.h"
#define DRIVER_AUTHOR "Alan Cox <alan@linux.intel.com> and others"
-#define DRIVER_LICENSE "GPL"
#define DRIVER_NAME "gma500"
#define DRIVER_DESC "DRM driver for the Intel GMA500, GMA600, GMA3600, GMA3650"
--
2.15.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
@ 2017-11-17 14:16 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2017-11-17 14:16 UTC (permalink / raw)
To: Patrik Jakobsson, David Airlie
Cc: dri-devel, linux-kernel, Philippe Ombredanne
There is no need to #define the license of the driver, just put it in
the MODULE_LICENSE() line directly as a text string.
This allows tools that check that the module license matches the source
code license to work properly, as there is no need to unwind the
unneeded dereference, especially when the string is defined in a .h file
far away from the .c file it is used in.
Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Cc: David Airlie <airlied@linux.ie>
Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/gpu/drm/gma500/psb_drv.c | 2 +-
drivers/gpu/drm/gma500/psb_drv.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/gma500/psb_drv.c b/drivers/gpu/drm/gma500/psb_drv.c
index 37a3be71acd9..8f5cc1f471cd 100644
--- a/drivers/gpu/drm/gma500/psb_drv.c
+++ b/drivers/gpu/drm/gma500/psb_drv.c
@@ -527,4 +527,4 @@ module_exit(psb_exit);
MODULE_AUTHOR(DRIVER_AUTHOR);
MODULE_DESCRIPTION(DRIVER_DESC);
-MODULE_LICENSE(DRIVER_LICENSE);
+MODULE_LICENSE("GPL");
diff --git a/drivers/gpu/drm/gma500/psb_drv.h b/drivers/gpu/drm/gma500/psb_drv.h
index 821497dbd3fc..4918efc57b7a 100644
--- a/drivers/gpu/drm/gma500/psb_drv.h
+++ b/drivers/gpu/drm/gma500/psb_drv.h
@@ -36,7 +36,6 @@
#include "mmu.h"
#define DRIVER_AUTHOR "Alan Cox <alan@linux.intel.com> and others"
-#define DRIVER_LICENSE "GPL"
#define DRIVER_NAME "gma500"
#define DRIVER_DESC "DRM driver for the Intel GMA500, GMA600, GMA3600, GMA3650"
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
2017-11-17 14:16 ` Greg Kroah-Hartman
(?)
@ 2017-11-17 14:50 ` Philippe Ombredanne
2017-11-20 10:16 ` Daniel Vetter
-1 siblings, 1 reply; 5+ messages in thread
From: Philippe Ombredanne @ 2017-11-17 14:50 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Patrik Jakobsson, David Airlie, dri-devel, LKML
On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> There is no need to #define the license of the driver, just put it in
> the MODULE_LICENSE() line directly as a text string.
>
> This allows tools that check that the module license matches the source
> code license to work properly, as there is no need to unwind the
> unneeded dereference, especially when the string is defined in a .h file
> far away from the .c file it is used in.
>
> Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> Cc: David Airlie <airlied@linux.ie>
> Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
--
Cordially
Philippe Ombredanne
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
2017-11-17 14:50 ` Philippe Ombredanne
@ 2017-11-20 10:16 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2017-11-20 10:16 UTC (permalink / raw)
To: Philippe Ombredanne; +Cc: David Airlie, Greg Kroah-Hartman, LKML, dri-devel
On Fri, Nov 17, 2017 at 03:50:25PM +0100, Philippe Ombredanne wrote:
> On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference, especially when the string is defined in a .h file
> > far away from the .c file it is used in.
> >
> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Queued for 4.16, it'll pop up in linux-next as soon as -rc1 is tagged.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define
@ 2017-11-20 10:16 ` Daniel Vetter
0 siblings, 0 replies; 5+ messages in thread
From: Daniel Vetter @ 2017-11-20 10:16 UTC (permalink / raw)
To: Philippe Ombredanne; +Cc: Greg Kroah-Hartman, David Airlie, dri-devel, LKML
On Fri, Nov 17, 2017 at 03:50:25PM +0100, Philippe Ombredanne wrote:
> On Fri, Nov 17, 2017 at 3:16 PM, Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> > There is no need to #define the license of the driver, just put it in
> > the MODULE_LICENSE() line directly as a text string.
> >
> > This allows tools that check that the module license matches the source
> > code license to work properly, as there is no need to unwind the
> > unneeded dereference, especially when the string is defined in a .h file
> > far away from the .c file it is used in.
> >
> > Cc: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
> > Cc: David Airlie <airlied@linux.ie>
> > Reported-by: Philippe Ombredanne <pombredanne@nexb.com>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>
> Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Queued for 4.16, it'll pop up in linux-next as soon as -rc1 is tagged.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-20 10:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-17 14:16 [PATCH] gpu: gma500: remove unneeded DRIVER_LICENSE #define Greg Kroah-Hartman
2017-11-17 14:16 ` Greg Kroah-Hartman
2017-11-17 14:50 ` Philippe Ombredanne
2017-11-20 10:16 ` Daniel Vetter
2017-11-20 10:16 ` Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.