* [PATCH] iio: adc/accel: Fix up module licenses
@ 2017-11-13 10:29 Linus Walleij
2017-11-18 15:54 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Linus Walleij @ 2017-11-13 10:29 UTC (permalink / raw)
To: Jonathan Cameron, linux-iio; +Cc: Linus Walleij, Randy Dunlap
The module license checker complains about these two so just fix
it up. They are both GPLv2, both written by me or using code
I extracted while refactoring from the GPLv2 drivers.
Cc: Randy Dunlap <rdunlap@infradead.org>
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
drivers/iio/accel/kxsd9-i2c.c | 3 +++
drivers/iio/adc/qcom-vadc-common.c | 3 +++
2 files changed, 6 insertions(+)
diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
index 98fbb628d5bd..38411e1c155b 100644
--- a/drivers/iio/accel/kxsd9-i2c.c
+++ b/drivers/iio/accel/kxsd9-i2c.c
@@ -63,3 +63,6 @@ static struct i2c_driver kxsd9_i2c_driver = {
.id_table = kxsd9_i2c_id,
};
module_i2c_driver(kxsd9_i2c_driver);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
index 47d24ae5462f..d249ce643e48 100644
--- a/drivers/iio/adc/qcom-vadc-common.c
+++ b/drivers/iio/adc/qcom-vadc-common.c
@@ -229,3 +229,6 @@ int qcom_vadc_decimation_from_dt(u32 value)
return __ffs64(value / VADC_DECIMATION_MIN);
}
EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
+
+MODULE_LICENSE("GPL v2");
+MODULE_DESCRIPTION("Qualcomm ADC common functionality");
--
2.13.6
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] iio: adc/accel: Fix up module licenses
2017-11-13 10:29 [PATCH] iio: adc/accel: Fix up module licenses Linus Walleij
@ 2017-11-18 15:54 ` Jonathan Cameron
2017-11-19 10:31 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2017-11-18 15:54 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-iio, Randy Dunlap
On Mon, 13 Nov 2017 11:29:55 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> The module license checker complains about these two so just fix
> it up. They are both GPLv2, both written by me or using code
> I extracted while refactoring from the GPLv2 drivers.
>
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Applied to the togreg branch of iio.git which will probably be be pushed
out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/accel/kxsd9-i2c.c | 3 +++
> drivers/iio/adc/qcom-vadc-common.c | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> index 98fbb628d5bd..38411e1c155b 100644
> --- a/drivers/iio/accel/kxsd9-i2c.c
> +++ b/drivers/iio/accel/kxsd9-i2c.c
> @@ -63,3 +63,6 @@ static struct i2c_driver kxsd9_i2c_driver = {
> .id_table = kxsd9_i2c_id,
> };
> module_i2c_driver(kxsd9_i2c_driver);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
> diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
> index 47d24ae5462f..d249ce643e48 100644
> --- a/drivers/iio/adc/qcom-vadc-common.c
> +++ b/drivers/iio/adc/qcom-vadc-common.c
> @@ -229,3 +229,6 @@ int qcom_vadc_decimation_from_dt(u32 value)
> return __ffs64(value / VADC_DECIMATION_MIN);
> }
> EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
> +
> +MODULE_LICENSE("GPL v2");
> +MODULE_DESCRIPTION("Qualcomm ADC common functionality");
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: adc/accel: Fix up module licenses
2017-11-18 15:54 ` Jonathan Cameron
@ 2017-11-19 10:31 ` Jonathan Cameron
2017-11-19 13:27 ` Linus Walleij
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2017-11-19 10:31 UTC (permalink / raw)
To: Linus Walleij; +Cc: linux-iio, Randy Dunlap
On Sat, 18 Nov 2017 15:54:48 +0000
Jonathan Cameron <jic23@kernel.org> wrote:
> On Mon, 13 Nov 2017 11:29:55 +0100
> Linus Walleij <linus.walleij@linaro.org> wrote:
>
> > The module license checker complains about these two so just fix
> > it up. They are both GPLv2, both written by me or using code
> > I extracted while refactoring from the GPLv2 drivers.
> >
> > Cc: Randy Dunlap <rdunlap@infradead.org>
> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Applied to the togreg branch of iio.git which will probably be be pushed
> out as testing for the autobuilders to play with it.
Actually - this doesn't pass basic x86_64 build testing...
Needs to include module.h in the qcom driver.
Done...
Jonathan
>
> Thanks,
>
> Jonathan
> > ---
> > drivers/iio/accel/kxsd9-i2c.c | 3 +++
> > drivers/iio/adc/qcom-vadc-common.c | 3 +++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/drivers/iio/accel/kxsd9-i2c.c b/drivers/iio/accel/kxsd9-i2c.c
> > index 98fbb628d5bd..38411e1c155b 100644
> > --- a/drivers/iio/accel/kxsd9-i2c.c
> > +++ b/drivers/iio/accel/kxsd9-i2c.c
> > @@ -63,3 +63,6 @@ static struct i2c_driver kxsd9_i2c_driver = {
> > .id_table = kxsd9_i2c_id,
> > };
> > module_i2c_driver(kxsd9_i2c_driver);
> > +
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("KXSD9 accelerometer I2C interface");
> > diff --git a/drivers/iio/adc/qcom-vadc-common.c b/drivers/iio/adc/qcom-vadc-common.c
> > index 47d24ae5462f..d249ce643e48 100644
> > --- a/drivers/iio/adc/qcom-vadc-common.c
> > +++ b/drivers/iio/adc/qcom-vadc-common.c
> > @@ -229,3 +229,6 @@ int qcom_vadc_decimation_from_dt(u32 value)
> > return __ffs64(value / VADC_DECIMATION_MIN);
> > }
> > EXPORT_SYMBOL(qcom_vadc_decimation_from_dt);
> > +
> > +MODULE_LICENSE("GPL v2");
> > +MODULE_DESCRIPTION("Qualcomm ADC common functionality");
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] iio: adc/accel: Fix up module licenses
2017-11-19 10:31 ` Jonathan Cameron
@ 2017-11-19 13:27 ` Linus Walleij
0 siblings, 0 replies; 4+ messages in thread
From: Linus Walleij @ 2017-11-19 13:27 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: linux-iio, Randy Dunlap
On Sun, Nov 19, 2017 at 11:31 AM, Jonathan Cameron
<jic23@jic23.retrosnub.co.uk> wrote:
> On Sat, 18 Nov 2017 15:54:48 +0000
> Jonathan Cameron <jic23@kernel.org> wrote:
>
>> On Mon, 13 Nov 2017 11:29:55 +0100
>> Linus Walleij <linus.walleij@linaro.org> wrote:
>>
>> > The module license checker complains about these two so just fix
>> > it up. They are both GPLv2, both written by me or using code
>> > I extracted while refactoring from the GPLv2 drivers.
>> >
>> > Cc: Randy Dunlap <rdunlap@infradead.org>
>> > Reported-by: Randy Dunlap <rdunlap@infradead.org>
>> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>> Applied to the togreg branch of iio.git which will probably be be pushed
>> out as testing for the autobuilders to play with it.
> Actually - this doesn't pass basic x86_64 build testing...
> Needs to include module.h in the qcom driver.
>
> Done...
Ah dammit there is so much stuff that seems obvious in
hindsight.
Thanks for fixing it up.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-19 13:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-13 10:29 [PATCH] iio: adc/accel: Fix up module licenses Linus Walleij
2017-11-18 15:54 ` Jonathan Cameron
2017-11-19 10:31 ` Jonathan Cameron
2017-11-19 13:27 ` Linus Walleij
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.