From: Johan Hovold <johan@kernel.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Johan Hovold <johan@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
Matthias Kaehlcke <matthias@kaehlcke.net>
Subject: Re: [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup
Date: Mon, 20 Nov 2017 11:44:12 +0000 [thread overview]
Message-ID: <20171120114412.GD3339@localhost> (raw)
In-Reply-To: <6effdc1a-9c3d-a773-04e4-e6c3ea8f4f52@linaro.org>
On Mon, Nov 20, 2017 at 11:34:07AM +0000, Daniel Thompson wrote:
>
>
> On 20/11/17 10:45, Johan Hovold wrote:
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at the parent rather than just matching
> > on its children.
> >
> > This would only cause trouble if the child node is missing while there
> > is an unrelated node named "backlight" elsewhere in the tree.
> >
> > Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
> > Cc: stable <stable@vger.kernel.org> # 3.7
> > Cc: Matthias Kaehlcke <matthias@kaehlcke.net>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Didn't I already ack this one?
Indeed you did (same with the previous one). Sorry about forgetting to
add them to v2.
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks for the acks.
Johan
WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: Daniel Thompson <daniel.thompson@linaro.org>
Cc: Johan Hovold <johan@kernel.org>, Lee Jones <lee.jones@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
linux-kernel@vger.kernel.org, stable <stable@vger.kernel.org>,
Matthias Kaehlcke <matthias@kaehlcke.net>
Subject: Re: [PATCH v2 3/4] backlight: tps65217_bl: fix device-tree node lookup
Date: Mon, 20 Nov 2017 12:44:12 +0100 [thread overview]
Message-ID: <20171120114412.GD3339@localhost> (raw)
In-Reply-To: <6effdc1a-9c3d-a773-04e4-e6c3ea8f4f52@linaro.org>
On Mon, Nov 20, 2017 at 11:34:07AM +0000, Daniel Thompson wrote:
>
>
> On 20/11/17 10:45, Johan Hovold wrote:
> > Fix child-node lookup during probe, which ended up searching the whole
> > device tree depth-first starting at the parent rather than just matching
> > on its children.
> >
> > This would only cause trouble if the child node is missing while there
> > is an unrelated node named "backlight" elsewhere in the tree.
> >
> > Fixes: eebfdc17cc6c ("backlight: Add TPS65217 WLED driver")
> > Cc: stable <stable@vger.kernel.org> # 3.7
> > Cc: Matthias Kaehlcke <matthias@kaehlcke.net>
> > Signed-off-by: Johan Hovold <johan@kernel.org>
>
> Didn't I already ack this one?
Indeed you did (same with the previous one). Sorry about forgetting to
add them to v2.
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Thanks for the acks.
Johan
next prev parent reply other threads:[~2017-11-20 11:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 10:45 [PATCH v2 0/4] backlight: fix device-tree node lookups Johan Hovold
2017-11-20 10:45 ` Johan Hovold
2017-11-20 10:45 ` [PATCH v2 1/4] backlight: as3711_bl: fix device-tree node lookup Johan Hovold
2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:33 ` Daniel Thompson
2017-11-20 11:33 ` Daniel Thompson
2017-11-29 11:28 ` Lee Jones
2017-11-29 11:28 ` Lee Jones
2017-11-29 11:28 ` Lee Jones
2017-11-20 10:45 ` [PATCH v2 2/4] backlight: max8925_bl: " Johan Hovold
2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:33 ` Daniel Thompson
2017-11-20 11:33 ` Daniel Thompson
2017-11-20 11:33 ` Daniel Thompson
2017-11-29 11:29 ` Lee Jones
2017-11-29 11:29 ` Lee Jones
2017-11-20 10:45 ` [PATCH v2 3/4] backlight: tps65217_bl: " Johan Hovold
2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:34 ` Daniel Thompson
2017-11-20 11:34 ` Daniel Thompson
2017-11-20 11:34 ` Daniel Thompson
2017-11-20 11:44 ` Johan Hovold [this message]
2017-11-20 11:44 ` Johan Hovold
2017-11-29 11:29 ` Lee Jones
2017-11-29 11:29 ` Lee Jones
2017-11-20 10:45 ` [PATCH v2 4/4] backlight: as3711_bl: fix device-tree node leaks Johan Hovold
2017-11-20 10:45 ` Johan Hovold
2017-11-20 11:41 ` Daniel Thompson
2017-11-20 11:41 ` Daniel Thompson
2017-11-20 11:41 ` Daniel Thompson
2017-11-29 11:29 ` Lee Jones
2017-11-29 11:29 ` Lee Jones
2017-11-29 11:29 ` Lee Jones
2018-05-11 7:27 ` [PATCH v2 0/4] backlight: fix device-tree node lookups Johan Hovold
2018-05-11 7:27 ` Johan Hovold
2018-05-11 7:27 ` Johan Hovold
2018-05-11 8:13 ` Lee Jones
2018-05-11 8:13 ` Lee Jones
2018-05-11 8:13 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171120114412.GD3339@localhost \
--to=johan@kernel.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel.thompson@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jingoohan1@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthias@kaehlcke.net \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.