From: Kalle Valo <kvalo@codeaurora.org>
To: Felix Fietkau <nbd@nbd.name>
Cc: linux-wireless@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>
Subject: Re: [v7,1/3] dt-bindings: net: add mt76 wireless device binding
Date: Tue, 21 Nov 2017 07:08:37 +0000 (UTC) [thread overview]
Message-ID: <20171121070837.F1BCF607F4@smtp.codeaurora.org> (raw)
In-Reply-To: <20171120193549.80831-2-nbd@nbd.name>
Felix Fietkau <nbd@nbd.name> wrote:
> Add documentation describing how device tree can be used to configure
> wireless chips supported by the mt76 driver.
>
> Signed-off-by: Felix Fietkau <nbd@nbd.name>
> Acked-by: Rob Herring <robh@kernel.org>
Fails to compile:
drivers/net/wireless/mediatek/mt76/mac80211.c: In function ‘mt76_led_init’:
drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit declaration of function ‘of_get_child_by_name’ [-Werror=implicit-function-declaration]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:111:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:113:8: error: implicit declaration of function ‘of_property_read_u32’ [-Werror=implicit-function-declaration]
if (!of_property_read_u32(np, "led-sources", &led_pin))
^
drivers/net/wireless/mediatek/mt76/mac80211.c:115:17: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]
dev->led_al = of_property_read_bool(np, "led-active-low");
^
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/mediatek/mt76/mac80211.o] Error 1
make[5]: *** Waiting for unfinished jobs....
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function ‘mt76x2_mac_process_rate’:
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: ‘RX_FLAG_SHORTPRE’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORTPRE;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: ‘RX_FLAG_HT_GF’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT_GF;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: ‘RX_FLAG_HT’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: ‘RX_FLAG_VHT’ undeclared (first use in this function)
status->flag |= RX_FLAG_VHT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_nss’
status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: ‘RX_FLAG_LDPC’ undeclared (first use in this function)
status->flag |= RX_FLAG_LDPC;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: ‘RX_FLAG_SHORT_GI’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORT_GI;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: ‘RX_FLAG_STBC_SHIFT’ undeclared (first use in this function)
status->flag |= 1 << RX_FLAG_STBC_SHIFT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: ‘RX_FLAG_40MHZ’ undeclared (first use in this function)
status->flag |= RX_FLAG_40MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_flag’
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: ‘RX_VHT_FLAG_80MHZ’ undeclared (first use in this function)
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^
make[5]: *** [drivers/net/wireless/mediatek/mt76/mt76x2_mac.o] Error 1
make[4]: *** [drivers/net/wireless/mediatek/mt76] Error 2
make[3]: *** [drivers/net/wireless/mediatek] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
3 patches set to Changes Requested.
10067143 [v7,1/3] dt-bindings: net: add mt76 wireless device binding
10067141 [v7,2/3] mt76: add common code shared between multiple chipsets
10067145 [v7,3/3] mt76: add driver code for MT76x2e
--
https://patchwork.kernel.org/patch/10067143/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
To: Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
Cc: linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [v7,1/3] dt-bindings: net: add mt76 wireless device binding
Date: Tue, 21 Nov 2017 07:08:37 +0000 (UTC) [thread overview]
Message-ID: <20171121070837.F1BCF607F4@smtp.codeaurora.org> (raw)
In-Reply-To: <20171120193549.80831-2-nbd-Vt+b4OUoWG0@public.gmane.org>
Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org> wrote:
> Add documentation describing how device tree can be used to configure
> wireless chips supported by the mt76 driver.
>
> Signed-off-by: Felix Fietkau <nbd-Vt+b4OUoWG0@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Fails to compile:
drivers/net/wireless/mediatek/mt76/mac80211.c: In function ‘mt76_led_init’:
drivers/net/wireless/mediatek/mt76/mac80211.c:111:7: error: implicit declaration of function ‘of_get_child_by_name’ [-Werror=implicit-function-declaration]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:111:5: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
np = of_get_child_by_name(np, "led");
^
drivers/net/wireless/mediatek/mt76/mac80211.c:113:8: error: implicit declaration of function ‘of_property_read_u32’ [-Werror=implicit-function-declaration]
if (!of_property_read_u32(np, "led-sources", &led_pin))
^
drivers/net/wireless/mediatek/mt76/mac80211.c:115:17: error: implicit declaration of function ‘of_property_read_bool’ [-Werror=implicit-function-declaration]
dev->led_al = of_property_read_bool(np, "led-active-low");
^
cc1: some warnings being treated as errors
make[5]: *** [drivers/net/wireless/mediatek/mt76/mac80211.o] Error 1
make[5]: *** Waiting for unfinished jobs....
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c: In function ‘mt76x2_mac_process_rate’:
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: error: ‘RX_FLAG_SHORTPRE’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORTPRE;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:49:20: note: each undeclared identifier is reported only once for each function it appears in
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:58:19: error: ‘RX_FLAG_HT_GF’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT_GF;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:61:19: error: ‘RX_FLAG_HT’ undeclared (first use in this function)
status->flag |= RX_FLAG_HT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:65:19: error: ‘RX_FLAG_VHT’ undeclared (first use in this function)
status->flag |= RX_FLAG_VHT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:67:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_nss’
status->vht_nss = FIELD_GET(MT_RATE_INDEX_VHT_NSS, idx) + 1;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:75:19: error: ‘RX_FLAG_LDPC’ undeclared (first use in this function)
status->flag |= RX_FLAG_LDPC;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:78:19: error: ‘RX_FLAG_SHORT_GI’ undeclared (first use in this function)
status->flag |= RX_FLAG_SHORT_GI;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:81:24: error: ‘RX_FLAG_STBC_SHIFT’ undeclared (first use in this function)
status->flag |= 1 << RX_FLAG_STBC_SHIFT;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:87:19: error: ‘RX_FLAG_40MHZ’ undeclared (first use in this function)
status->flag |= RX_FLAG_40MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:9: error: ‘struct ieee80211_rx_status’ has no member named ‘vht_flag’
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^
drivers/net/wireless/mediatek/mt76/mt76x2_mac.c:90:23: error: ‘RX_VHT_FLAG_80MHZ’ undeclared (first use in this function)
status->vht_flag |= RX_VHT_FLAG_80MHZ;
^
make[5]: *** [drivers/net/wireless/mediatek/mt76/mt76x2_mac.o] Error 1
make[4]: *** [drivers/net/wireless/mediatek/mt76] Error 2
make[3]: *** [drivers/net/wireless/mediatek] Error 2
make[2]: *** [drivers/net/wireless] Error 2
make[1]: *** [drivers/net] Error 2
make: *** [drivers] Error 2
3 patches set to Changes Requested.
10067143 [v7,1/3] dt-bindings: net: add mt76 wireless device binding
10067141 [v7,2/3] mt76: add common code shared between multiple chipsets
10067145 [v7,3/3] mt76: add driver code for MT76x2e
--
https://patchwork.kernel.org/patch/10067143/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-11-21 7:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 19:35 [PATCH v7 0/3] mt76: add new wireless driver for MediaTek MT76x2 PCIe chips Felix Fietkau
2017-11-20 19:35 ` [PATCH v7 1/3] dt-bindings: net: add mt76 wireless device binding Felix Fietkau
2017-11-20 19:35 ` Felix Fietkau
2017-11-20 21:34 ` Rob Herring
2017-11-20 21:34 ` Rob Herring
2017-11-21 7:08 ` [v7,1/3] " Kalle Valo
2017-11-21 7:08 ` Kalle Valo [this message]
2017-11-21 7:08 ` Kalle Valo
[not found] ` <20171121070837.AA354607EA@smtp.codeaurora.org>
2017-11-21 8:45 ` Felix Fietkau
2017-11-21 8:45 ` Felix Fietkau
2017-11-20 19:35 ` [PATCH v7 2/3] mt76: add common code shared between multiple chipsets Felix Fietkau
2017-11-20 19:35 ` [PATCH v7 3/3] mt76: add driver code for MT76x2e Felix Fietkau
2017-11-23 7:05 ` kbuild test robot
2017-11-23 7:42 ` Kalle Valo
2017-11-23 7:27 ` kbuild test robot
2017-11-23 7:27 ` [PATCH] mt76: fix debugfs_simple_attr.cocci warnings kbuild test robot
2017-12-07 13:42 ` Kalle Valo
2017-12-08 1:29 ` Fengguang Wu
2017-11-23 7:27 ` [PATCH] mt76: fix returnvar.cocci warnings kbuild test robot
2017-12-07 13:43 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171121070837.F1BCF607F4@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.