From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
criu@openvz.org, Arnd Bergmann <arnd@arndb.de>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Triplett <josh@joshtriplett.org>,
Jann Horn <jannh@google.com>, Andrei Vagin <avagin@openvz.org>
Subject: Re: [PATCH v3 4/4] test: add a test for the process_vmsplice syscall
Date: Thu, 23 Nov 2017 16:07:25 +0200 [thread overview]
Message-ID: <20171123140725.GC2303@rapoport-lnx> (raw)
In-Reply-To: <20171123080103.GA490@kroah.com>
On Thu, Nov 23, 2017 at 09:01:03AM +0100, Greg KH wrote:
> On Wed, Nov 22, 2017 at 09:36:31PM +0200, Mike Rapoport wrote:
> > From: Andrei Vagin <avagin@openvz.org>
> >
> > This test checks that process_vmsplice() can splice pages from a remote
> > process and returns EFAULT, if process_vmsplice() tries to splice pages
> > by an unaccessiable address.
> >
> > Signed-off-by: Andrei Vagin <avagin@openvz.org>
> > ---
> > tools/testing/selftests/process_vmsplice/Makefile | 5 +
> > .../process_vmsplice/process_vmsplice_test.c | 188 +++++++++++++++++++++
> > 2 files changed, 193 insertions(+)
> > create mode 100644 tools/testing/selftests/process_vmsplice/Makefile
> > create mode 100644 tools/testing/selftests/process_vmsplice/process_vmsplice_test.c
> >
[ ... ]
>
> Shouldn't you check to see if the syscall is even present? You should
> not error if it is not, as this test will then "fail" on kernels/arches
> without the syscall enabled, which isn't the nicest.
Sure, will fix.
> thanks,
>
> greg k-h
>
--
Sincerely yours,
Mike.
WARNING: multiple messages have this Message-ID (diff)
From: Mike Rapoport <rppt@linux.vnet.ibm.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-mm@kvack.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-api@vger.kernel.org,
criu@openvz.org, Arnd Bergmann <arnd@arndb.de>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Michael Kerrisk <mtk.manpages@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Josh Triplett <josh@joshtriplett.org>,
Jann Horn <jannh@google.com>, Andrei Vagin <avagin@openvz.org>
Subject: Re: [PATCH v3 4/4] test: add a test for the process_vmsplice syscall
Date: Thu, 23 Nov 2017 16:07:25 +0200 [thread overview]
Message-ID: <20171123140725.GC2303@rapoport-lnx> (raw)
In-Reply-To: <20171123080103.GA490@kroah.com>
On Thu, Nov 23, 2017 at 09:01:03AM +0100, Greg KH wrote:
> On Wed, Nov 22, 2017 at 09:36:31PM +0200, Mike Rapoport wrote:
> > From: Andrei Vagin <avagin@openvz.org>
> >
> > This test checks that process_vmsplice() can splice pages from a remote
> > process and returns EFAULT, if process_vmsplice() tries to splice pages
> > by an unaccessiable address.
> >
> > Signed-off-by: Andrei Vagin <avagin@openvz.org>
> > ---
> > tools/testing/selftests/process_vmsplice/Makefile | 5 +
> > .../process_vmsplice/process_vmsplice_test.c | 188 +++++++++++++++++++++
> > 2 files changed, 193 insertions(+)
> > create mode 100644 tools/testing/selftests/process_vmsplice/Makefile
> > create mode 100644 tools/testing/selftests/process_vmsplice/process_vmsplice_test.c
> >
[ ... ]
>
> Shouldn't you check to see if the syscall is even present? You should
> not error if it is not, as this test will then "fail" on kernels/arches
> without the syscall enabled, which isn't the nicest.
Sure, will fix.
> thanks,
>
> greg k-h
>
--
Sincerely yours,
Mike.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-11-23 14:07 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 19:36 [PATCH v3 0/4] vm: add a syscall to map a process memory into a pipe Mike Rapoport
2017-11-22 19:36 ` Mike Rapoport
[not found] ` <1511379391-988-1-git-send-email-rppt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-11-22 19:36 ` [PATCH v3 1/4] fs/splice: introduce pages_to_pipe helper Mike Rapoport
2017-11-22 19:36 ` Mike Rapoport
2017-11-22 19:36 ` Mike Rapoport
2017-11-22 19:36 ` [PATCH v3 2/4] vm: add a syscall to map a process memory into a pipe Mike Rapoport
2017-11-22 19:36 ` Mike Rapoport
2017-11-22 19:36 ` [PATCH v3 3/4] x86: wire up the process_vmsplice syscall Mike Rapoport
2017-11-22 19:36 ` Mike Rapoport
2017-11-22 19:36 ` [PATCH v3 4/4] test: add a test for " Mike Rapoport
2017-11-22 19:36 ` Mike Rapoport
[not found] ` <1511379391-988-5-git-send-email-rppt-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
2017-11-23 8:01 ` Greg KH
2017-11-23 8:01 ` Greg KH
2017-11-23 8:01 ` Greg KH
2017-11-23 14:07 ` Mike Rapoport [this message]
2017-11-23 14:07 ` Mike Rapoport
2017-11-22 20:43 ` [PATCH v3 0/4] vm: add a syscall to map a process memory into a pipe Michael Kerrisk (man-pages)
2017-11-22 20:43 ` Michael Kerrisk (man-pages)
2017-11-23 6:29 ` Mike Rapoport
2017-11-23 6:29 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171123140725.GC2303@rapoport-lnx \
--to=rppt@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=avagin@openvz.org \
--cc=criu@openvz.org \
--cc=gregkh@linuxfoundation.org \
--cc=jannh@google.com \
--cc=josh@joshtriplett.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mtk.manpages@gmail.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.