From: Eric Biggers <ebiggers3@gmail.com>
To: linux-security-module@vger.kernel.org
Subject: Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring
Date: Fri, 24 Nov 2017 20:37:50 +0000 [thread overview]
Message-ID: <20171124203750.GA559@zzz.localdomain> (raw)
In-Reply-To: <23022.1511538725@warthog.procyon.org.uk>
On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > - construct_get_dest_keyring(&dest_keyring);
>
> This will break. construct_get_dest_keyring() does other things than just
> getting a ref on whatever dest_keyring points to.
>
Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this
case.
Eric
WARNING: multiple messages have this Message-ID (diff)
From: ebiggers3@gmail.com (Eric Biggers)
To: linux-security-module@vger.kernel.org
Subject: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring
Date: Fri, 24 Nov 2017 12:37:50 -0800 [thread overview]
Message-ID: <20171124203750.GA559@zzz.localdomain> (raw)
In-Reply-To: <23022.1511538725@warthog.procyon.org.uk>
On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > - construct_get_dest_keyring(&dest_keyring);
>
> This will break. construct_get_dest_keyring() does other things than just
> getting a ref on whatever dest_keyring points to.
>
Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this
case.
Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers3@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: keyrings@vger.kernel.org, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org, Eric Biggers <ebiggers@google.com>
Subject: Re: [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring
Date: Fri, 24 Nov 2017 12:37:50 -0800 [thread overview]
Message-ID: <20171124203750.GA559@zzz.localdomain> (raw)
In-Reply-To: <23022.1511538725@warthog.procyon.org.uk>
On Fri, Nov 24, 2017 at 03:52:05PM +0000, David Howells wrote:
> Eric Biggers <ebiggers3@gmail.com> wrote:
>
> > - construct_get_dest_keyring(&dest_keyring);
>
> This will break. construct_get_dest_keyring() does other things than just
> getting a ref on whatever dest_keyring points to.
>
Not if dest_keyring is non-NULL (i.e. explicitly specified), which it is in this
case.
Eric
next prev parent reply other threads:[~2017-11-24 20:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-20 22:57 [PATCH] KEYS: remove unnecessary get/put of explicit dest_keyring Eric Biggers
2017-11-20 22:57 ` Eric Biggers
2017-11-20 22:57 ` Eric Biggers
2017-11-24 15:52 ` David Howells
2017-11-24 15:52 ` David Howells
2017-11-24 15:52 ` David Howells
2017-11-24 20:37 ` Eric Biggers [this message]
2017-11-24 20:37 ` Eric Biggers
2017-11-24 20:37 ` Eric Biggers
2017-11-24 21:18 ` David Howells
2017-11-24 21:18 ` David Howells
2017-11-24 21:18 ` David Howells
2017-11-24 21:24 ` David Howells
2017-11-24 21:24 ` David Howells
2017-11-24 21:24 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171124203750.GA559@zzz.localdomain \
--to=ebiggers3@gmail.com \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.