From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>
Subject: Re: [PATCH net 1/3] sctp: force SCTP_ERROR_INV_STRM with __u32 when calling sctp_chunk_fail
Date: Mon, 27 Nov 2017 12:32:35 +0000 [thread overview]
Message-ID: <20171127123235.GD3473@localhost.localdomain> (raw)
In-Reply-To: <b1daca5283b99f8df5a48749a18e07c8596316d1.1511698478.git.lucien.xin@gmail.com>
On Sun, Nov 26, 2017 at 08:16:06PM +0800, Xin Long wrote:
> This patch is to force SCTP_ERROR_INV_STRM with right type to
> fit in sctp_chunk_fail to avoid the sparse error.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/stream.c b/net/sctp/stream.c
> index a20145b..76ea66b 100644
> --- a/net/sctp/stream.c
> +++ b/net/sctp/stream.c
> @@ -64,7 +64,7 @@ static void sctp_stream_outq_migrate(struct sctp_stream *stream,
> */
>
> /* Mark as failed send. */
> - sctp_chunk_fail(ch, SCTP_ERROR_INV_STRM);
> + sctp_chunk_fail(ch, (__force __u32)SCTP_ERROR_INV_STRM);
> if (asoc->peer.prsctp_capable &&
> SCTP_PR_PRIO_ENABLED(ch->sinfo.sinfo_flags))
> asoc->sent_cnt_removable--;
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
WARNING: multiple messages have this Message-ID (diff)
From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
linux-sctp@vger.kernel.org, davem@davemloft.net,
Neil Horman <nhorman@tuxdriver.com>,
Vlad Yasevich <vyasevich@gmail.com>
Subject: Re: [PATCH net 1/3] sctp: force SCTP_ERROR_INV_STRM with __u32 when calling sctp_chunk_fail
Date: Mon, 27 Nov 2017 10:32:35 -0200 [thread overview]
Message-ID: <20171127123235.GD3473@localhost.localdomain> (raw)
In-Reply-To: <b1daca5283b99f8df5a48749a18e07c8596316d1.1511698478.git.lucien.xin@gmail.com>
On Sun, Nov 26, 2017 at 08:16:06PM +0800, Xin Long wrote:
> This patch is to force SCTP_ERROR_INV_STRM with right type to
> fit in sctp_chunk_fail to avoid the sparse error.
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> ---
> net/sctp/stream.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sctp/stream.c b/net/sctp/stream.c
> index a20145b..76ea66b 100644
> --- a/net/sctp/stream.c
> +++ b/net/sctp/stream.c
> @@ -64,7 +64,7 @@ static void sctp_stream_outq_migrate(struct sctp_stream *stream,
> */
>
> /* Mark as failed send. */
> - sctp_chunk_fail(ch, SCTP_ERROR_INV_STRM);
> + sctp_chunk_fail(ch, (__force __u32)SCTP_ERROR_INV_STRM);
> if (asoc->peer.prsctp_capable &&
> SCTP_PR_PRIO_ENABLED(ch->sinfo.sinfo_flags))
> asoc->sent_cnt_removable--;
> --
> 2.1.0
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-sctp" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
next prev parent reply other threads:[~2017-11-27 12:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 12:16 [PATCH net 0/3] sctp: fix some other sparse errors Xin Long
2017-11-26 12:16 ` Xin Long
2017-11-26 12:16 ` [PATCH net 1/3] sctp: force SCTP_ERROR_INV_STRM with __u32 when calling sctp_chunk_fail Xin Long
2017-11-26 12:16 ` Xin Long
2017-11-26 12:16 ` [PATCH net 2/3] sctp: force the params with right types for sctp csum apis Xin Long
2017-11-26 12:16 ` Xin Long
2017-11-26 12:16 ` [PATCH net 3/3] sctp: remove extern from stream sched Xin Long
2017-11-26 12:16 ` Xin Long
2017-11-27 12:41 ` Marcelo Ricardo Leitner
2017-11-27 12:41 ` Marcelo Ricardo Leitner
2017-11-27 12:32 ` [PATCH net 2/3] sctp: force the params with right types for sctp csum apis Marcelo Ricardo Leitner
2017-11-27 12:32 ` Marcelo Ricardo Leitner
2017-11-27 12:32 ` Marcelo Ricardo Leitner [this message]
2017-11-27 12:32 ` [PATCH net 1/3] sctp: force SCTP_ERROR_INV_STRM with __u32 when calling sctp_chunk_fail Marcelo Ricardo Leitner
2017-11-27 14:00 ` [PATCH net 0/3] sctp: fix some other sparse errors Neil Horman
2017-11-27 14:00 ` Neil Horman
2017-11-28 16:00 ` David Miller
2017-11-28 16:00 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127123235.GD3473@localhost.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-sctp@vger.kernel.org \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.