All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Jens Axboe <axboe@fb.com>,
	linux-block@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>
Cc: Omar Sandoval <osandov@fb.com>,
	Bart Van Assche <bart.vanassche@sandisk.com>,
	Hannes Reinecke <hare@suse.com>, Wen Xiong <wenxiong@us.ibm.com>,
	Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>
Subject: Re: [PATCH V2 0/2] block: fix queue freeze and cleanup
Date: Mon, 27 Nov 2017 20:41:48 +0800	[thread overview]
Message-ID: <20171127124147.GA16095@ming.t460p> (raw)
In-Reply-To: <20171123044800.25251-1-ming.lei@redhat.com>

On Thu, Nov 23, 2017 at 12:47:58PM +0800, Ming Lei wrote:
> Hi Jens,
> 
> The 1st patch runs queue in blk_freeze_queue_start() for fixing one
> regression by 055f6e18e08f("block: Make q_usage_counter also track legacy
> requests").
> 
> The 2nd patch drians blkcg part of request_queue for both blk-mq and
> legacy, which can be a fix on blk-mq's queue cleanup.
> 
> V2:
> 	- follow Bart's suggestion to use run queue instead of drain queue
> 	- drians blkcg part of request_queue for blk-mq
> 

Hi Jens,

Without this patchset, IO hang can be triggered in Mauricio's disk
pull test, and this IO hang won't happen any more after this patchset
is applied.

So could you make it in V4.15 if you are fine with the two patches?

Thanks,
Ming

  parent reply	other threads:[~2017-11-27 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-23  4:47 [PATCH V2 0/2] block: fix queue freeze and cleanup Ming Lei
2017-11-23  4:47 ` [PATCH V2 1/2] block: run queue before waiting for q_usage_counter becoming zero Ming Lei
2017-11-27 12:15   ` Mauricio Faria de Oliveira
2017-11-23  4:48 ` [PATCH V2 2/2] block: drain blkcg part of request_queue in blk_cleanup_queue() Ming Lei
2017-11-27 12:15   ` Mauricio Faria de Oliveira
2017-11-27 12:41 ` Ming Lei [this message]
2017-11-29  2:57   ` [PATCH V2 0/2] block: fix queue freeze and cleanup chenxiang (M)
2017-11-29  4:54     ` Ming Lei
2017-11-29  5:40       ` chenxiang (M)
2017-12-01 15:36     ` Mauricio Faria de Oliveira
2017-12-01 15:42       ` Ming Lei
2017-12-01 16:08       ` Bart Van Assche
2017-12-01 17:35         ` Ming Lei
2017-12-01 18:49         ` Mauricio Faria de Oliveira
2017-12-02  0:49           ` Ming Lei
2017-12-04 12:31             ` Mauricio Faria de Oliveira
2017-12-13 21:49           ` Bart Van Assche
2017-12-20 14:34             ` Mauricio Faria de Oliveira
2017-12-13 21:53     ` Bart Van Assche
2017-12-15  7:58       ` chenxiang (M)
2017-12-15 17:44         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171127124147.GA16095@ming.t460p \
    --to=ming.lei@redhat.com \
    --cc=axboe@fb.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=hare@suse.com \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=mauricfo@linux.vnet.ibm.com \
    --cc=osandov@fb.com \
    --cc=wenxiong@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.