From: Ming Lei <ming.lei@redhat.com>
To: Mauricio Faria de Oliveira <mauricfo@linux.vnet.ibm.com>,
Jens Axboe <axboe@fb.com>
Cc: "chenxiang (M)" <chenxiang66@hisilicon.com>,
Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Omar Sandoval <osandov@fb.com>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.com>, Wen Xiong <wenxiong@us.ibm.com>,
Linuxarm <linuxarm@huawei.com>
Subject: Re: [PATCH V2 0/2] block: fix queue freeze and cleanup
Date: Fri, 1 Dec 2017 23:42:43 +0800 [thread overview]
Message-ID: <20171201154242.GA21731@ming.t460p> (raw)
In-Reply-To: <fcc89b28-41f9-ecdc-438b-b593f09866c9@linux.vnet.ibm.com>
On Fri, Dec 01, 2017 at 01:36:13PM -0200, Mauricio Faria de Oliveira wrote:
> Hi Ming Lei,
>
> On 11/29/2017 12:57 AM, chenxiang (M) wrote:
> > I applied this v2 patchset to kernel 4.15-rc1, running fio on a SATA
> > disk, then disable the disk with sysfs interface
> > (echo 0 > /sys/class/sas_phy/phy-1:0:1/enable), and find system is hung.
> > But with v1 patch, it doesn't
> > has this issue. Please have a check.
>
> Indeed, with this particular test-case (thanks, chenxiang) the problem
> can be recreated with PATCH v2 but _not_ with v1.
>
> For reference, I'm including the tests with v2 in this e-mail.
> The same tests have too been performed with v1, without blocked tasks.
>
> Interestingly, physical disk pulls did not hit the problem either
> on v1 or v2 (but it does not matter anymore) -- so v1 is the one.
V1 has been resent out in the following link with your tested-by:
https://marc.info/?l=linux-block&m=151200356024020&w=2
Jens, since it fixes regression from two reports, could you take a look?
--
Ming
next prev parent reply other threads:[~2017-12-01 15:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 4:47 [PATCH V2 0/2] block: fix queue freeze and cleanup Ming Lei
2017-11-23 4:47 ` [PATCH V2 1/2] block: run queue before waiting for q_usage_counter becoming zero Ming Lei
2017-11-27 12:15 ` Mauricio Faria de Oliveira
2017-11-23 4:48 ` [PATCH V2 2/2] block: drain blkcg part of request_queue in blk_cleanup_queue() Ming Lei
2017-11-27 12:15 ` Mauricio Faria de Oliveira
2017-11-27 12:41 ` [PATCH V2 0/2] block: fix queue freeze and cleanup Ming Lei
2017-11-29 2:57 ` chenxiang (M)
2017-11-29 4:54 ` Ming Lei
2017-11-29 5:40 ` chenxiang (M)
2017-12-01 15:36 ` Mauricio Faria de Oliveira
2017-12-01 15:42 ` Ming Lei [this message]
2017-12-01 16:08 ` Bart Van Assche
2017-12-01 17:35 ` Ming Lei
2017-12-01 18:49 ` Mauricio Faria de Oliveira
2017-12-02 0:49 ` Ming Lei
2017-12-04 12:31 ` Mauricio Faria de Oliveira
2017-12-13 21:49 ` Bart Van Assche
2017-12-20 14:34 ` Mauricio Faria de Oliveira
2017-12-13 21:53 ` Bart Van Assche
2017-12-15 7:58 ` chenxiang (M)
2017-12-15 17:44 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201154242.GA21731@ming.t460p \
--to=ming.lei@redhat.com \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=chenxiang66@hisilicon.com \
--cc=hare@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=mauricfo@linux.vnet.ibm.com \
--cc=osandov@fb.com \
--cc=wenxiong@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.