From: Eduardo Valentin <edubezval@gmail.com>
To: Baruch Siach <baruch@tkos.co.il>
Cc: Russell King - ARM Linux <linux@armlinux.org.uk>,
Zhang Rui <rui.zhang@intel.com>, Andrew Lunn <andrew@lunn.ch>,
Jason Cooper <jason@lakedaemon.net>,
linux-pm@vger.kernel.org,
Miquel Raynal <miquel.raynal@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/3] thermal: armada: add support for AP806
Date: Mon, 27 Nov 2017 11:21:38 -0800 [thread overview]
Message-ID: <20171127192136.GA3835@localhost.localdomain> (raw)
In-Reply-To: <20171123163510.q34rndd4b4p4da4s@tarshish>
On Thu, Nov 23, 2017 at 06:35:10PM +0200, Baruch Siach wrote:
> Hi Russell,
>
> On Thu, Nov 23, 2017 at 03:24:17PM +0000, Russell King - ARM Linux wrote:
> > On Wed, Nov 22, 2017 at 04:42:04PM +0200, Baruch Siach wrote:
> > > The AP806 component is integrated in the Armada 8k and 7k lines of processors.
<cut>
> > > + mdelay(10);
> >
> > Do you really need to make the CPU busy-wait for 10ms here? This
> > looks like it's called from a schedulable context, so won't msleep()
> > do?
Yes, that is schedulable context.
>
> msleep() should be fine as well. I just mindlessly copied this code from the
> vendor kernel. I'll change that in the next iteration.
>
Yes please, send next version without CPU spinning delays.
> Thanks for reviewing,
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
WARNING: multiple messages have this Message-ID (diff)
From: edubezval@gmail.com (Eduardo Valentin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] thermal: armada: add support for AP806
Date: Mon, 27 Nov 2017 11:21:38 -0800 [thread overview]
Message-ID: <20171127192136.GA3835@localhost.localdomain> (raw)
In-Reply-To: <20171123163510.q34rndd4b4p4da4s@tarshish>
On Thu, Nov 23, 2017 at 06:35:10PM +0200, Baruch Siach wrote:
> Hi Russell,
>
> On Thu, Nov 23, 2017 at 03:24:17PM +0000, Russell King - ARM Linux wrote:
> > On Wed, Nov 22, 2017 at 04:42:04PM +0200, Baruch Siach wrote:
> > > The AP806 component is integrated in the Armada 8k and 7k lines of processors.
<cut>
> > > + mdelay(10);
> >
> > Do you really need to make the CPU busy-wait for 10ms here? This
> > looks like it's called from a schedulable context, so won't msleep()
> > do?
Yes, that is schedulable context.
>
> msleep() should be fine as well. I just mindlessly copied this code from the
> vendor kernel. I'll change that in the next iteration.
>
Yes please, send next version without CPU spinning delays.
> Thanks for reviewing,
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2017-11-27 19:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 14:42 [PATCH 1/3] dt-bindings: thermal/armada: describe AP806 and CP110 Baruch Siach
2017-11-22 14:42 ` Baruch Siach
2017-11-22 14:42 ` [PATCH 2/3] thermal: armada: add support for AP806 Baruch Siach
2017-11-22 14:42 ` Baruch Siach
2017-11-23 15:24 ` Russell King - ARM Linux
2017-11-23 15:24 ` Russell King - ARM Linux
2017-11-23 16:35 ` Baruch Siach
2017-11-23 16:35 ` Baruch Siach
2017-11-27 19:21 ` Eduardo Valentin [this message]
2017-11-27 19:21 ` Eduardo Valentin
2017-11-22 14:42 ` [PATCH 3/3] thermal: armada: add support for CP110 Baruch Siach
2017-11-22 14:42 ` Baruch Siach
2017-11-22 16:23 ` Eduardo Valentin
2017-11-22 16:23 ` Eduardo Valentin
2017-11-22 17:41 ` Baruch Siach
2017-11-22 17:41 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171127192136.GA3835@localhost.localdomain \
--to=edubezval@gmail.com \
--cc=andrew@lunn.ch \
--cc=baruch@tkos.co.il \
--cc=gregory.clement@free-electrons.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=miquel.raynal@free-electrons.com \
--cc=rui.zhang@intel.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.