From: Ladislav Michl <ladis@linux-mips.org>
To: Joe Perches <joe@perches.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, "Andrew F. Davis" <afd@ti.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions
Date: Tue, 28 Nov 2017 08:49:45 +0000 [thread overview]
Message-ID: <20171128084945.GA29091@lenoch> (raw)
In-Reply-To: <1511856244.19952.14.camel@perches.com>
On Tue, Nov 28, 2017 at 12:04:04AM -0800, Joe Perches wrote:
> On Tue, 2017-11-28 at 08:41 +0100, SF Markus Elfring wrote:
> > > > It seems that I got no responses so far for clarification requests
> > > > according to the documentation in a direction I hoped for.
> > >
> > > That's because you are pretty unresponsive to direction.
> >
> > From which places did you get this impression?
>
> How many times have I told you to include the reason for
> your patches in
> your proposed commit message? Too often.
>
> For instance, specific to this patch:
>
> Many people do not know that a generic kmalloc does a
> dump_stack() on OOM. That information should be part
> of the commit message.
>
> Also removing the printk code reduces overall code size.
> The actual size reduction should be described in the
> commit message too.
Could we, please, return one step back and reevaluate need for
kmalloc. That would eliminate original "problem" as well.
ladis
WARNING: multiple messages have this Message-ID (diff)
From: Ladislav Michl <ladis@linux-mips.org>
To: Joe Perches <joe@perches.com>
Cc: SF Markus Elfring <elfring@users.sourceforge.net>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org,
dri-devel@lists.freedesktop.org, "Andrew F. Davis" <afd@ti.com>,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: omapfb/dss: Delete an error message for a failed memory allocation in three functions
Date: Tue, 28 Nov 2017 09:49:45 +0100 [thread overview]
Message-ID: <20171128084945.GA29091@lenoch> (raw)
In-Reply-To: <1511856244.19952.14.camel@perches.com>
On Tue, Nov 28, 2017 at 12:04:04AM -0800, Joe Perches wrote:
> On Tue, 2017-11-28 at 08:41 +0100, SF Markus Elfring wrote:
> > > > It seems that I got no responses so far for clarification requests
> > > > according to the documentation in a direction I hoped for.
> > >
> > > That's because you are pretty unresponsive to direction.
> >
> > From which places did you get this impression?
>
> How many times have I told you to include the reason for
> your patches in
> your proposed commit message? Too often.
>
> For instance, specific to this patch:
>
> Many people do not know that a generic kmalloc does a
> dump_stack() on OOM. That information should be part
> of the commit message.
>
> Also removing the printk code reduces overall code size.
> The actual size reduction should be described in the
> commit message too.
Could we, please, return one step back and reevaluate need for
kmalloc. That would eliminate original "problem" as well.
ladis
next prev parent reply other threads:[~2017-11-28 8:49 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-26 18:55 [PATCH] omapfb/dss: Delete an error message for a failed memory allocation in three functions SF Markus Elfring
2017-11-26 18:55 ` SF Markus Elfring
2017-11-26 18:55 ` SF Markus Elfring
2017-11-27 16:43 ` Andrew F. Davis
2017-11-27 16:43 ` Andrew F. Davis
2017-11-27 16:43 ` Andrew F. Davis
2017-11-27 17:27 ` SF Markus Elfring
2017-11-27 17:27 ` SF Markus Elfring
2017-11-27 17:27 ` SF Markus Elfring
2017-11-27 17:44 ` Ladislav Michl
2017-11-27 17:44 ` Ladislav Michl
2017-11-27 17:44 ` Ladislav Michl
2017-11-27 18:12 ` SF Markus Elfring
2017-11-27 18:12 ` SF Markus Elfring
2017-11-27 18:12 ` SF Markus Elfring
2017-11-27 18:56 ` Geert Uytterhoeven
2017-11-27 18:56 ` Geert Uytterhoeven
2017-11-27 18:56 ` Geert Uytterhoeven
2017-11-27 19:22 ` Ladislav Michl
2017-11-27 19:22 ` Ladislav Michl
2017-11-27 22:20 ` Ladislav Michl
2017-11-27 22:20 ` Ladislav Michl
2017-11-27 19:07 ` [PATCH] " Joe Perches
2017-11-27 19:07 ` Joe Perches
2017-11-27 21:33 ` Andrew F. Davis
2017-11-27 21:33 ` Andrew F. Davis
2017-11-27 21:33 ` Andrew F. Davis
2017-11-27 21:45 ` Ladislav Michl
2017-11-27 21:45 ` Ladislav Michl
2017-11-27 21:48 ` SF Markus Elfring
2017-11-27 21:48 ` SF Markus Elfring
2017-11-27 21:48 ` SF Markus Elfring
2017-11-27 21:48 ` SF Markus Elfring
2017-11-28 1:45 ` Joe Perches
2017-11-28 1:45 ` Joe Perches
2017-11-28 1:45 ` Joe Perches
2017-11-28 7:41 ` SF Markus Elfring
2017-11-28 7:41 ` SF Markus Elfring
2017-11-28 7:41 ` SF Markus Elfring
2017-11-28 7:49 ` Julia Lawall
2017-11-28 7:49 ` Julia Lawall
2017-11-28 8:49 ` SF Markus Elfring
2017-11-28 8:49 ` SF Markus Elfring
2017-11-28 9:26 ` Julia Lawall
2017-11-28 9:26 ` Julia Lawall
2017-11-28 9:26 ` Julia Lawall
2017-11-28 9:56 ` SF Markus Elfring
2017-11-28 9:56 ` SF Markus Elfring
2017-11-28 9:56 ` SF Markus Elfring
2017-11-28 8:04 ` Joe Perches
2017-11-28 8:04 ` Joe Perches
2017-11-28 8:49 ` Ladislav Michl [this message]
2017-11-28 8:49 ` Ladislav Michl
2017-11-28 9:11 ` SF Markus Elfring
2017-11-28 9:11 ` SF Markus Elfring
2017-11-28 9:11 ` SF Markus Elfring
2017-11-28 9:28 ` Julia Lawall
2017-11-28 9:28 ` Julia Lawall
2017-11-28 9:28 ` Julia Lawall
2017-11-28 10:15 ` SF Markus Elfring
2017-11-28 10:15 ` SF Markus Elfring
2017-11-28 10:23 ` Ladislav Michl
2017-11-28 10:23 ` Ladislav Michl
2017-11-28 10:50 ` SF Markus Elfring
2017-11-28 10:50 ` SF Markus Elfring
2017-11-28 10:50 ` SF Markus Elfring
2017-11-28 11:41 ` Ladislav Michl
2017-11-28 11:41 ` Ladislav Michl
2017-11-28 12:13 ` SF Markus Elfring
2017-11-28 12:13 ` SF Markus Elfring
2017-11-28 12:13 ` SF Markus Elfring
2017-11-28 17:50 ` Ladislav Michl
2017-11-28 17:50 ` Ladislav Michl
2017-11-28 18:09 ` SF Markus Elfring
2017-11-28 18:09 ` SF Markus Elfring
2017-11-28 18:09 ` SF Markus Elfring
2017-11-28 14:36 ` Joe Perches
2017-11-28 14:36 ` Joe Perches
2017-12-03 18:20 ` SF Markus Elfring
2017-12-03 18:20 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171128084945.GA29091@lenoch \
--to=ladis@linux-mips.org \
--cc=afd@ti.com \
--cc=arvind.yadav.cs@gmail.com \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=elfring@users.sourceforge.net \
--cc=joe@perches.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.