All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Julia Lawall" <Julia.Lawall@lip6.fr>,
	"Sean Paul" <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org,
	kernel@pyra-handheld.com
Subject: Re: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string
Date: Tue, 28 Nov 2017 15:10:39 +0000	[thread overview]
Message-ID: <20171128151039.GZ28152@atomide.com> (raw)
In-Reply-To: <C108B0B6-FED7-44DB-9A18-39E3BE93E586@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [171128 15:04]:
> Hi Tony,
> 
> > Am 28.11.2017 um 15:57 schrieb Tony Lindgren <tony@atomide.com>:
> > 
> > * H. Nikolaus Schaller <hns@goldelico.com> [171116 08:53]:
> >> Vendor string is "tpo" and not "toppoly".
> >> 
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> >> index 4504908c23fe..ec27ed67a22a 100644
> >> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> >> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> >> @@ -86,7 +86,7 @@
> >> 
> >> 		/* lcd panel */
> >> 		lcd: td028ttec1@0 {
> >> -			compatible = "toppoly,td028ttec1";
> >> +			compatible = "tpo,td028ttec1";
> >> 			reg = <0>;
> >> 			spi-max-frequency = <100000>;
> >> 			spi-cpol;
> > 
> > Applying into omap-for-v4.15/fixes thanks. The other dts patch seems
> > like it can wait for v4.16 merge window.
> 
> Hm. Not really. It needs the panel driver to match. So either both or
> none should be applied or it will break the panel from working.
> 
> I am just 1-2 hours away from submitting a -v3 (rebased and tested
> on top of 4.15-rc1).

OK fine dropping both. Please update the description in both dts
patches to make it clear they are needed as a fix. Preferrably
with a proper fixes tag.

Having "We can remove the "omapdss," prefix" in the description sure
does not sounds like it's needed as a fix :)

Sounds like maybe these two should be just a single patch for
a proper fix?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Thierry Reding" <thierry.reding@gmail.com>,
	"David Airlie" <airlied@linux.ie>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Mark Rutland" <mark.rutland@arm.com>,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"Tomi Valkeinen" <tomi.valkeinen@ti.com>,
	"Bartlomiej Zolnierkiewicz" <b.zolnierkie@samsung.com>,
	"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
	"Julia Lawall" <Julia.Lawall@lip6.fr>,
	"Sean Paul" <seanpaul@chromium.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org, letux-kernel@openphoenux.org,
	kernel@pyra-handheld.com
Subject: Re: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string
Date: Tue, 28 Nov 2017 07:10:39 -0800	[thread overview]
Message-ID: <20171128151039.GZ28152@atomide.com> (raw)
In-Reply-To: <C108B0B6-FED7-44DB-9A18-39E3BE93E586@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [171128 15:04]:
> Hi Tony,
> 
> > Am 28.11.2017 um 15:57 schrieb Tony Lindgren <tony@atomide.com>:
> > 
> > * H. Nikolaus Schaller <hns@goldelico.com> [171116 08:53]:
> >> Vendor string is "tpo" and not "toppoly".
> >> 
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> >> index 4504908c23fe..ec27ed67a22a 100644
> >> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> >> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> >> @@ -86,7 +86,7 @@
> >> 
> >> 		/* lcd panel */
> >> 		lcd: td028ttec1@0 {
> >> -			compatible = "toppoly,td028ttec1";
> >> +			compatible = "tpo,td028ttec1";
> >> 			reg = <0>;
> >> 			spi-max-frequency = <100000>;
> >> 			spi-cpol;
> > 
> > Applying into omap-for-v4.15/fixes thanks. The other dts patch seems
> > like it can wait for v4.16 merge window.
> 
> Hm. Not really. It needs the panel driver to match. So either both or
> none should be applied or it will break the panel from working.
> 
> I am just 1-2 hours away from submitting a -v3 (rebased and tested
> on top of 4.15-rc1).

OK fine dropping both. Please update the description in both dts
patches to make it clear they are needed as a fix. Preferrably
with a proper fixes tag.

Having "We can remove the "omapdss," prefix" in the description sure
does not sounds like it's needed as a fix :)

Sounds like maybe these two should be just a single patch for
a proper fix?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string
Date: Tue, 28 Nov 2017 07:10:39 -0800	[thread overview]
Message-ID: <20171128151039.GZ28152@atomide.com> (raw)
In-Reply-To: <C108B0B6-FED7-44DB-9A18-39E3BE93E586@goldelico.com>

* H. Nikolaus Schaller <hns@goldelico.com> [171128 15:04]:
> Hi Tony,
> 
> > Am 28.11.2017 um 15:57 schrieb Tony Lindgren <tony@atomide.com>:
> > 
> > * H. Nikolaus Schaller <hns@goldelico.com> [171116 08:53]:
> >> Vendor string is "tpo" and not "toppoly".
> >> 
> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com>
> >> ---
> >> arch/arm/boot/dts/omap3-gta04.dtsi | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >> 
> >> diff --git a/arch/arm/boot/dts/omap3-gta04.dtsi b/arch/arm/boot/dts/omap3-gta04.dtsi
> >> index 4504908c23fe..ec27ed67a22a 100644
> >> --- a/arch/arm/boot/dts/omap3-gta04.dtsi
> >> +++ b/arch/arm/boot/dts/omap3-gta04.dtsi
> >> @@ -86,7 +86,7 @@
> >> 
> >> 		/* lcd panel */
> >> 		lcd: td028ttec1 at 0 {
> >> -			compatible = "toppoly,td028ttec1";
> >> +			compatible = "tpo,td028ttec1";
> >> 			reg = <0>;
> >> 			spi-max-frequency = <100000>;
> >> 			spi-cpol;
> > 
> > Applying into omap-for-v4.15/fixes thanks. The other dts patch seems
> > like it can wait for v4.16 merge window.
> 
> Hm. Not really. It needs the panel driver to match. So either both or
> none should be applied or it will break the panel from working.
> 
> I am just 1-2 hours away from submitting a -v3 (rebased and tested
> on top of 4.15-rc1).

OK fine dropping both. Please update the description in both dts
patches to make it clear they are needed as a fix. Preferrably
with a proper fixes tag.

Having "We can remove the "omapdss," prefix" in the description sure
does not sounds like it's needed as a fix :)

Sounds like maybe these two should be just a single patch for
a proper fix?

Regards,

Tony

  reply	other threads:[~2017-11-28 15:10 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-16  8:50 [PATCH v2 0/4] Fixes for omapdrm on OpenPandora and GTA04 H. Nikolaus Schaller
2017-11-16  8:50 ` H. Nikolaus Schaller
2017-11-16  8:50 ` H. Nikolaus Schaller
2017-11-16  8:50 ` H. Nikolaus Schaller
     [not found] ` <cover.1510822218.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-11-16  8:50   ` [PATCH v2 1/4] omapdrm: fix compatible string for td028ttec1 H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16 12:32     ` Tomi Valkeinen
2017-11-16 12:32       ` Tomi Valkeinen
2017-11-16 12:32       ` Tomi Valkeinen
2017-11-16 12:32       ` Tomi Valkeinen
     [not found]       ` <4753a425-d050-7f2d-35ae-b387accfd99e-l0cyMroinI0@public.gmane.org>
2017-11-16 13:43         ` H. Nikolaus Schaller
2017-11-16 13:43           ` H. Nikolaus Schaller
2017-11-16 13:43           ` H. Nikolaus Schaller
2017-11-16 13:43           ` H. Nikolaus Schaller
2017-11-16 15:53           ` Andrew F. Davis
2017-11-16 15:53             ` Andrew F. Davis
2017-11-16 15:53             ` Andrew F. Davis
2017-11-16 15:53             ` Andrew F. Davis
2017-11-16 16:10             ` H. Nikolaus Schaller
2017-11-16 16:10               ` H. Nikolaus Schaller
2017-11-16 16:10               ` H. Nikolaus Schaller
2017-11-16 16:10               ` H. Nikolaus Schaller
2017-11-16 17:08               ` Andrew F. Davis
2017-11-16 17:08                 ` Andrew F. Davis
2017-11-16 17:08                 ` Andrew F. Davis
2017-11-16 17:08                 ` Andrew F. Davis
2017-11-16 18:18                 ` H. Nikolaus Schaller
2017-11-16 18:18                   ` H. Nikolaus Schaller
2017-11-16 18:18                   ` H. Nikolaus Schaller
2017-11-16 18:18                   ` H. Nikolaus Schaller
2017-11-16 18:32                   ` Andrew F. Davis
2017-11-16 18:32                     ` Andrew F. Davis
2017-11-16 18:32                     ` Andrew F. Davis
2017-11-16 18:32                     ` Andrew F. Davis
2017-11-16 18:56                     ` H. Nikolaus Schaller
2017-11-16 18:56                       ` H. Nikolaus Schaller
2017-11-16 18:56                       ` H. Nikolaus Schaller
2017-11-16 18:56                       ` H. Nikolaus Schaller
2017-11-20  5:36                       ` H. Nikolaus Schaller
2017-11-20  5:36                         ` H. Nikolaus Schaller
2017-11-20  5:36                         ` H. Nikolaus Schaller
2017-11-20  5:36                         ` H. Nikolaus Schaller
2017-11-16  8:50   ` [PATCH v2 2/4] DTS: GTA04: fix panel compatibility string H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
     [not found]     ` <09d975dd62afa1dfa43d94079cc9a44731af4b3b.1510822218.git.hns-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-11-28 14:57       ` Tony Lindgren
2017-11-28 14:57         ` Tony Lindgren
2017-11-28 14:57         ` Tony Lindgren
2017-11-28 14:57         ` Tony Lindgren
2017-11-28 15:01         ` H. Nikolaus Schaller
2017-11-28 15:01           ` H. Nikolaus Schaller
2017-11-28 15:01           ` H. Nikolaus Schaller
2017-11-28 15:10           ` Tony Lindgren [this message]
2017-11-28 15:10             ` Tony Lindgren
2017-11-28 15:10             ` Tony Lindgren
2017-11-28 15:48             ` H. Nikolaus Schaller
2017-11-28 15:48               ` H. Nikolaus Schaller
2017-11-28 15:48               ` H. Nikolaus Schaller
2017-11-28 15:48               ` H. Nikolaus Schaller
     [not found]               ` <F14B3797-8154-4958-82AB-8E39C75BB97B-xXXSsgcRVICgSpxsJD1C4w@public.gmane.org>
2017-11-28 16:00                 ` Tony Lindgren
2017-11-28 16:00                   ` Tony Lindgren
2017-11-28 16:00                   ` Tony Lindgren
2017-11-28 16:00                   ` Tony Lindgren
2017-11-28 16:04                   ` H. Nikolaus Schaller
2017-11-28 16:04                     ` H. Nikolaus Schaller
2017-11-28 16:04                     ` H. Nikolaus Schaller
2017-11-16  8:50   ` [PATCH v2 3/4] DTS: Pandora: " H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50   ` [PATCH v2 4/4] drm: omapdrm: Fix DPI on platforms using the DSI VDDS H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-16  8:50     ` H. Nikolaus Schaller
2017-11-21 10:25     ` Tomi Valkeinen
2017-11-21 10:25       ` Tomi Valkeinen
2017-11-21 10:25       ` Tomi Valkeinen
2017-11-21 10:25       ` Tomi Valkeinen
2017-11-21 10:38       ` H. Nikolaus Schaller
2017-11-21 10:38         ` H. Nikolaus Schaller
2017-11-21 10:38         ` H. Nikolaus Schaller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171128151039.GZ28152@atomide.com \
    --to=tony@atomide.com \
    --cc=Julia.Lawall@lip6.fr \
    --cc=airlied@linux.ie \
    --cc=b.zolnierkie@samsung.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hns@goldelico.com \
    --cc=kernel@pyra-handheld.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=letux-kernel@openphoenux.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=seanpaul@chromium.org \
    --cc=thierry.reding@gmail.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.