Fixes for 4.15-rc1

Fixes for 4.15-rc1

[Harry Wentland]

Hi Alex,

I cherry-picked a bunch of fixes for 4.15. These can be found at hwentlan/4.15-rc1-fixes.

Of the changes the highlighted ones (with *) in particular are highly recommended, but even the other ones are probably good to have.

1086abf3e8ab drm/amd/display: USB-C / thunderbolt dock specific workaround
* fc59fdfdbd52 drm/amd/display: Switch to drm_atomic_helper_wait_for_flip_done
* c386a22129a1 drm/amd/display: fix gamma setting
* af54c36e0c30 drm/amd/display: Do not put drm_atomic_state on resume
89be3facaeb1 drm/amd/display: Fix couple more inconsistent NULL checks in dc_resource
75909a2c505a drm/amd/display: Fix potential NULL and mem leak in create_links
dfa21baf4699 drm/amd/display: Fix hubp check in set_cursor_position
4cea995b2636 drm/amd/display: Fix use before NULL check in validate_timing
9a130225c042 drm/amd/display: Bunch of smatch error and warning fixes in DC
65ca5b19622e drm/amd/display: Fix amdgpu_dm bugs found by smatch
8ae2f517cf1d drm/amd/display: try to find matching audio inst for enc inst first
86b16c34c2ef drm/amd/display: fix seq issue: turn on clock before programming afmt.
b35eb4120a68 drm/amd/display: fix memory leaks on error exit return
ab164036ba33 drm/amd/display: check plane state before validating fbc
70d7f684a4d8 drm/amd/display: Do DC mode-change check when adding CRTCs
1baa90a34571 drm/amd/display: Revert noisy assert messages
7397a660300a drm/amd/display: fix split viewport rounding error
bd4eb434d515 drm/amd/display: Check aux channel before MST resume
65633318cedd drm/amd/display: fix split recout offset
9e403e8d7d07 drm/amd/display: Don't reject 3D timings
277a9b0854c4 drm/amd/display: Handle as MST first and then DP dongle if sink support both
d5d60701f3ec drm/amd/display: fix split recout calculation
e947765cc008 drm/amd/display: Fix S3 topology change
405b3c636ac5 drm/amd/display: Add timing validation against dongle cap
* 1f63dba38d42 drm/amd/display: Should disable when new stream is null
fa4e15633102 drm/amd/display: Add null check for 24BPP (xfm and dpp)

I confirmed on Polaris11 the bolded changes fix:
 * DPMS
 * Gamma

The other fixes address a bunch of Raven stuff, as well as dock/dongle issues, and potential problems found by smatch, but I haven't been able to confirm those myself.

I gave S3 a spin since that is also problematic without "Do not put drm_atomic_state on resume"  but on my motherboard the system never comes out of S3 on 4.15rc1, even without loading amdgpu and no X. This works on amd-staging-drm-next, so must be a regression elsewhere in the kernel.

Can you pick these up for your fixes branch?

Harry

PS: I succesfully rebased all of amd-staging-dal-drm-next on 4.15-rc1 last night. It was painless. Just had to skip these two patches:
	    drm/amdgpu Moving amdgpu asic types to a separate file
	    x86/PCI: Enable a 64bit BAR on AMD Family 15h (Models 30h-3fh) Processors

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: Fixes for 4.15-rc1

[Johannes Hirte]

On 2017 Nov 28, Harry Wentland wrote:
> Hi Alex,
> 
> I cherry-picked a bunch of fixes for 4.15. These can be found at hwentlan/4.15-rc1-fixes.
> 
> Of the changes the highlighted ones (with *) in particular are highly recommended, but even the other ones are probably good to have.
> 
> * af54c36e0c30 drm/amd/display: Do not put drm_atomic_state on resume

This one is really needed, cause it fixes a use-after-free. See this
thread: https://lists.freedesktop.org/archives/amd-gfx/2017-November/016236.html

Additionally, another use-after-free waits for fixing in 4.15-rc:
https://lists.freedesktop.org/archives/amd-gfx/2017-October/014827.html

-- 
Regards,
  Johannes

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx