From: Vinod Koul <vinod.koul@intel.com>
To: Sinan Kaya <okaya@codeaurora.org>
Cc: dmaengine@vger.kernel.org, timur@codeaurora.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: check pending interrupts
Date: Wed, 29 Nov 2017 19:31:18 +0530 [thread overview]
Message-ID: <20171129140118.GF32417@localhost> (raw)
In-Reply-To: <1510671301-23223-1-git-send-email-okaya@codeaurora.org>
On Tue, Nov 14, 2017 at 09:55:01AM -0500, Sinan Kaya wrote:
> Driver is missing the interrupts if two requests are queued up at the same
> time as the interrupt handler is servicing a request that was just
> delivered.
>
> The ISR clears the interrupt at the end but it could be clearing the
> interrupt for an outstanding event. Therefore, second interrupt never
> arrives.
>
> Clear the interrupt first and then check for completions.
>
> Also, make sure that request start and interrupt clear do not overlap in
> time by using a spinlock.
Applied, thanks
--
~Vinod
WARNING: multiple messages have this Message-ID (diff)
From: vinod.koul@intel.com (Vinod Koul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] dmaengine: qcom_hidma: check pending interrupts
Date: Wed, 29 Nov 2017 19:31:18 +0530 [thread overview]
Message-ID: <20171129140118.GF32417@localhost> (raw)
In-Reply-To: <1510671301-23223-1-git-send-email-okaya@codeaurora.org>
On Tue, Nov 14, 2017 at 09:55:01AM -0500, Sinan Kaya wrote:
> Driver is missing the interrupts if two requests are queued up at the same
> time as the interrupt handler is servicing a request that was just
> delivered.
>
> The ISR clears the interrupt at the end but it could be clearing the
> interrupt for an outstanding event. Therefore, second interrupt never
> arrives.
>
> Clear the interrupt first and then check for completions.
>
> Also, make sure that request start and interrupt clear do not overlap in
> time by using a spinlock.
Applied, thanks
--
~Vinod
next prev parent reply other threads:[~2017-11-29 13:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-14 14:55 [PATCH] dmaengine: qcom_hidma: check pending interrupts Sinan Kaya
2017-11-14 14:55 ` Sinan Kaya
2017-11-29 14:01 ` Vinod Koul [this message]
2017-11-29 14:01 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129140118.GF32417@localhost \
--to=vinod.koul@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okaya@codeaurora.org \
--cc=timur@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.