From: Andrew Lunn <andrew@lunn.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
David Daney <david.daney@cavium.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-mips@linux-mips.org, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
Carlos Munoz <cmunoz@cavium.com>,
Rob Herring <robh+dt@kernel.org>,
"Steven J. Hill" <steven.hill@cavium.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
James Hogan <james.hogan@mips.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.
Date: Wed, 29 Nov 2017 23:16:31 +0100 [thread overview]
Message-ID: <20171129221631.GD1706@lunn.ch> (raw)
In-Reply-To: <20171129191138.ntlfw5fb4xacwyun@mwanda>
On Wed, Nov 29, 2017 at 10:11:38PM +0300, Dan Carpenter wrote:
> On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote:
> > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, struct port_status status)
> > >> +{
> > >> + u64 data;
> > >> + u64 prtx;
> > >> + u64 miscx;
> > >> + int timeout;
> > >> +
> >
> > >> +
> > >> + switch (status.speed) {
> > >> + case 10:
> > >
> > > In my opinion, instead of hard coding the value, is it fine to use ENUM ?
> > Similar comments applicable in other places where hard coded values are used.
> >
>
> 10 means 10M right? That's not really a magic number. It's fine.
There are also :
uapi/linux/ethtool.h:#define SPEED_10 10
uapi/linux/ethtool.h:#define SPEED_100 100
uapi/linux/ethtool.h:#define SPEED_1000 1000
uapi/linux/ethtool.h:#define SPEED_10000 10000
uapi/linux/ethtool.h:#define SPEED_100000 100000
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
linux-mips@linux-mips.org, devel@driverdev.osuosl.org,
devicetree@vger.kernel.org, netdev@vger.kernel.org,
David Daney <david.daney@cavium.com>,
linux-kernel@vger.kernel.org, ralf@linux-mips.org,
Carlos Munoz <cmunoz@cavium.com>,
Rob Herring <robh+dt@kernel.org>,
Souptick Joarder <jrdr.linux@gmail.com>,
"Steven J. Hill" <steven.hill@cavium.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
James Hogan <james.hogan@mips.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support.
Date: Wed, 29 Nov 2017 23:16:31 +0100 [thread overview]
Message-ID: <20171129221631.GD1706@lunn.ch> (raw)
In-Reply-To: <20171129191138.ntlfw5fb4xacwyun@mwanda>
On Wed, Nov 29, 2017 at 10:11:38PM +0300, Dan Carpenter wrote:
> On Wed, Nov 29, 2017 at 09:37:15PM +0530, Souptick Joarder wrote:
> > >> +static int bgx_port_sgmii_set_link_speed(struct bgx_port_priv *priv, struct port_status status)
> > >> +{
> > >> + u64 data;
> > >> + u64 prtx;
> > >> + u64 miscx;
> > >> + int timeout;
> > >> +
> >
> > >> +
> > >> + switch (status.speed) {
> > >> + case 10:
> > >
> > > In my opinion, instead of hard coding the value, is it fine to use ENUM ?
> > Similar comments applicable in other places where hard coded values are used.
> >
>
> 10 means 10M right? That's not really a magic number. It's fine.
There are also :
uapi/linux/ethtool.h:#define SPEED_10 10
uapi/linux/ethtool.h:#define SPEED_100 100
uapi/linux/ethtool.h:#define SPEED_1000 1000
uapi/linux/ethtool.h:#define SPEED_10000 10000
uapi/linux/ethtool.h:#define SPEED_100000 100000
Andrew
next prev parent reply other threads:[~2017-11-29 22:16 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 0:55 [PATCH v4 0/8] Cavium OCTEON-III network driver David Daney
2017-11-29 0:55 ` David Daney
2017-11-29 0:55 ` [PATCH v4 1/8] dt-bindings: Add Cavium Octeon Common Ethernet Interface David Daney
2017-11-29 0:55 ` David Daney
2017-11-29 2:01 ` Andrew Lunn
2017-11-29 2:01 ` Andrew Lunn
2017-11-29 2:54 ` David Daney
2017-11-29 0:55 ` [PATCH v4 2/8] MIPS: Octeon: Enable LMTDMA/LMTST operations David Daney
2017-11-29 0:55 ` David Daney
2017-11-30 21:36 ` James Hogan
2017-11-30 21:36 ` James Hogan
2017-11-30 21:36 ` James Hogan
2017-11-30 21:49 ` David Daney
2017-11-30 21:49 ` David Daney
2017-11-30 22:56 ` James Hogan
2017-11-30 22:56 ` James Hogan
2017-11-30 23:09 ` David Daney
2017-11-30 23:09 ` David Daney
2017-11-30 23:12 ` James Hogan
2017-11-30 23:12 ` James Hogan
2017-11-30 23:12 ` James Hogan
2017-11-30 23:12 ` James Hogan
2017-11-29 0:55 ` [PATCH v4 3/8] MIPS: Octeon: Add a global resource manager David Daney
2017-11-30 22:53 ` James Hogan
2017-11-30 22:53 ` James Hogan
2017-11-30 22:53 ` James Hogan
2017-11-30 22:53 ` James Hogan
2017-12-01 1:51 ` David Daney
2017-12-01 1:51 ` David Daney
2017-12-01 7:53 ` Philippe Ombredanne
2017-12-01 17:42 ` David Daney
2017-12-01 19:49 ` Philippe Ombredanne
2017-12-01 20:01 ` David Daney
2017-12-01 20:41 ` Philippe Ombredanne
2017-12-01 20:56 ` David Daney
2017-12-01 20:56 ` David Daney
2017-12-01 23:33 ` Philippe Ombredanne
2017-12-01 23:33 ` Philippe Ombredanne
2017-11-29 0:55 ` [PATCH v4 4/8] MIPS: Octeon: Add Free Pointer Unit (FPA) support David Daney
2017-11-29 0:55 ` David Daney
2017-11-29 0:55 ` David Daney
2017-11-29 0:55 ` [PATCH v4 5/8] MIPS: Octeon: Automatically provision CVMSEG space David Daney
2017-11-29 0:55 ` David Daney
2017-11-29 0:55 ` [PATCH v4 6/8] staging: octeon: Remove USE_ASYNC_IOBDMA macro David Daney
2017-11-29 0:55 ` David Daney
2017-12-07 14:28 ` Greg Kroah-Hartman
2017-12-07 14:28 ` Greg Kroah-Hartman
2017-11-29 0:55 ` [PATCH v4 7/8] netdev: octeon-ethernet: Add Cavium Octeon III support David Daney
2017-11-29 10:30 ` Souptick Joarder
2017-11-29 10:30 ` Souptick Joarder
2017-11-29 13:47 ` Andrew Lunn
2017-11-29 13:47 ` Andrew Lunn
2017-11-29 16:07 ` Souptick Joarder
2017-11-29 16:07 ` Souptick Joarder
2017-11-29 19:11 ` Dan Carpenter
2017-11-29 19:11 ` Dan Carpenter
2017-11-29 22:16 ` Andrew Lunn [this message]
2017-11-29 22:16 ` Andrew Lunn
2017-11-29 19:20 ` David Daney
2017-11-29 19:20 ` David Daney
2017-11-30 7:12 ` Souptick Joarder
2017-11-29 22:56 ` Andrew Lunn
2017-11-29 22:56 ` Andrew Lunn
2017-11-29 23:04 ` David Daney
2017-11-29 23:04 ` David Daney
2017-11-29 0:55 ` [PATCH v4 8/8] MAINTAINERS: Add entry for drivers/net/ethernet/cavium/octeon/octeon3-* David Daney
2017-11-29 0:55 ` David Daney
2017-11-29 14:18 ` [PATCH v4 0/8] Cavium OCTEON-III network driver David Miller
2017-11-29 14:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171129221631.GD1706@lunn.ch \
--to=andrew@lunn.ch \
--cc=cmunoz@cavium.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=david.daney@cavium.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=james.hogan@mips.com \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=netdev@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=steven.hill@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.