All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sami Tolvanen <samitolvanen@google.com>
To: Alex Matveev <alxmtvv@gmail.com>, Andi Kleen <ak@linux.intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Greg Hackmann <ghackmann@google.com>,
	Kees Cook <keescook@chromium.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mark Rutland <mark.rutland@arm.com>,
	Masahiro Yamada <yamada.masahiro@socionext.com>,
	Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
	Michal Marek <michal.lkml@markovi.net>,
	Nick Desaulniers <ndesaulniers@google.com>,
	Yury Norov <ynorov@caviumnetworks.com>,
	Matthias Kaehlcke <mka@chromium.org>,
	Nicholas Piggin <npiggin@gmail.com>
Cc: Sami Tolvanen <samitolvanen@google.com>
Subject: [PATCH 1/7] kbuild: add ld-name macro and support for GNU gold
Date: Wed, 29 Nov 2017 15:44:36 -0800	[thread overview]
Message-ID: <20171129234442.655-2-samitolvanen@google.com> (raw)
In-Reply-To: <20171129234442.655-1-samitolvanen@google.com>

GNU gold may require different flags than GNU ld. Add a macro for
detecting the linker and conditionally add gold specific flags from
LDFLAGS_GOLD.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
---
 Makefile               | 5 +++++
 scripts/Kbuild.include | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/Makefile b/Makefile
index f761bf475ba5..a16c98d6e3ba 100644
--- a/Makefile
+++ b/Makefile
@@ -814,6 +814,11 @@ include scripts/Makefile.kasan
 include scripts/Makefile.extrawarn
 include scripts/Makefile.ubsan
 
+# Add any flags specific to ld.gold
+ifeq ($(ld-name),gold)
+LDFLAGS		+= $(LDFLAGS_GOLD)
+endif
+
 # Add any arch overrides and user supplied CPPFLAGS, AFLAGS and CFLAGS as the
 # last assignments
 KBUILD_CPPFLAGS += $(ARCH_CPPFLAGS) $(KCPPFLAGS)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index b6d7d347b203..a7c7843c2cf1 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -277,6 +277,10 @@ ld-option = $(call try-run-cached,\
 # Important: no spaces around options
 ar-option = $(call try-run-cached, $(AR) rc$(1) "$$TMP",$(1),$(2))
 
+# ld-name
+# Expands to either bfd or gold
+ld-name = $(shell $(LD) -v 2>&1 | grep -q "GNU gold" && echo gold || echo bfd)
+
 # ld-version
 # Note this is mainly for HJ Lu's 3 number binutil versions
 ld-version = $(call shell-cached,$(LD) --version | $(srctree)/scripts/ld-version.sh)
-- 
2.15.0.531.g2ccb3012c9-goog


WARNING: multiple messages have this Message-ID (diff)
From: samitolvanen@google.com (Sami Tolvanen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] kbuild: add ld-name macro and support for GNU gold
Date: Wed, 29 Nov 2017 15:44:36 -0800	[thread overview]
Message-ID: <20171129234442.655-2-samitolvanen@google.com> (raw)
In-Reply-To: <20171129234442.655-1-samitolvanen@google.com>

GNU gold may require different flags than GNU ld. Add a macro for
detecting the linker and conditionally add gold specific flags from
LDFLAGS_GOLD.

Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
---
 Makefile               | 5 +++++
 scripts/Kbuild.include | 4 ++++
 2 files changed, 9 insertions(+)

diff --git a/Makefile b/Makefile
index f761bf475ba5..a16c98d6e3ba 100644
--- a/Makefile
+++ b/Makefile
@@ -814,6 +814,11 @@ include scripts/Makefile.kasan
 include scripts/Makefile.extrawarn
 include scripts/Makefile.ubsan
 
+# Add any flags specific to ld.gold
+ifeq ($(ld-name),gold)
+LDFLAGS		+= $(LDFLAGS_GOLD)
+endif
+
 # Add any arch overrides and user supplied CPPFLAGS, AFLAGS and CFLAGS as the
 # last assignments
 KBUILD_CPPFLAGS += $(ARCH_CPPFLAGS) $(KCPPFLAGS)
diff --git a/scripts/Kbuild.include b/scripts/Kbuild.include
index b6d7d347b203..a7c7843c2cf1 100644
--- a/scripts/Kbuild.include
+++ b/scripts/Kbuild.include
@@ -277,6 +277,10 @@ ld-option = $(call try-run-cached,\
 # Important: no spaces around options
 ar-option = $(call try-run-cached, $(AR) rc$(1) "$$TMP",$(1),$(2))
 
+# ld-name
+# Expands to either bfd or gold
+ld-name = $(shell $(LD) -v 2>&1 | grep -q "GNU gold" && echo gold || echo bfd)
+
 # ld-version
 # Note this is mainly for HJ Lu's 3 number binutil versions
 ld-version = $(call shell-cached,$(LD) --version | $(srctree)/scripts/ld-version.sh)
-- 
2.15.0.531.g2ccb3012c9-goog

  reply	other threads:[~2017-11-29 23:44 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29 23:44 [PATCH 0/7] Add support for GNU gold Sami Tolvanen
2017-11-29 23:44 ` Sami Tolvanen
2017-11-29 23:44 ` Sami Tolvanen [this message]
2017-11-29 23:44   ` [PATCH 1/7] kbuild: add ld-name macro and " Sami Tolvanen
2017-11-30  0:32   ` Nick Desaulniers
2017-11-30  0:32     ` Nick Desaulniers
2017-11-30 17:38     ` Sami Tolvanen
2017-11-30 17:38       ` Sami Tolvanen
2017-11-29 23:44 ` [PATCH 2/7] kbuild: add ld-if-name-version and linker-specific macros Sami Tolvanen
2017-11-29 23:44   ` Sami Tolvanen
2017-11-29 23:44 ` [PATCH 3/7] kbuild: fix LD_DEAD_CODE_DATA_ELIMINATION with GNU gold Sami Tolvanen
2017-11-29 23:44   ` Sami Tolvanen
2017-11-30  2:10   ` Nicholas Piggin
2017-11-30  2:10     ` Nicholas Piggin
2017-11-29 23:44 ` [PATCH 4/7] arm64: fix -m for " Sami Tolvanen
2017-11-29 23:44   ` Sami Tolvanen
2017-11-29 23:44 ` [PATCH 5/7] arm64: keep .altinstructions and .altinstr_replacement Sami Tolvanen
2017-11-29 23:44   ` Sami Tolvanen
2017-11-29 23:57   ` Nick Desaulniers
2017-11-29 23:57     ` Nick Desaulniers
2017-11-30  1:58     ` Nicholas Piggin
2017-11-30  1:58       ` Nicholas Piggin
2017-11-30 17:00       ` Nick Desaulniers
2017-11-30 17:00         ` Nick Desaulniers
2017-12-01  0:36         ` Nicholas Piggin
2017-12-01  0:36           ` Nicholas Piggin
2017-11-30 17:48       ` Sami Tolvanen
2017-11-30 17:48         ` Sami Tolvanen
2017-11-29 23:44 ` [PATCH 6/7] arm64: explicitly pass --no-fix-cortex-a53-843419 to GNU gold Sami Tolvanen
2017-11-29 23:44   ` Sami Tolvanen
2017-11-30  0:30   ` Nick Desaulniers
2017-11-30  0:30     ` Nick Desaulniers
2017-11-30 17:50     ` Sami Tolvanen
2017-11-30 17:50       ` Sami Tolvanen
2017-11-29 23:44 ` [PATCH 7/7] arm64: add a workaround for GNU gold with ARM64_MODULE_PLTS Sami Tolvanen
2017-11-29 23:44   ` Sami Tolvanen
2017-11-30  9:31   ` Ard Biesheuvel
2017-11-30  9:31     ` Ard Biesheuvel
2017-11-30 23:38 ` [PATCH v2 0/7] Add support for GNU gold Sami Tolvanen
2017-11-30 23:38   ` Sami Tolvanen
2017-11-30 23:38   ` [PATCH v2 1/7] kbuild: fix LD_DEAD_CODE_DATA_ELIMINATION Sami Tolvanen
2017-11-30 23:38     ` Sami Tolvanen
2017-11-30 23:39   ` [PATCH v2 2/7] arm64: keep .altinstructions and .altinstr_replacement Sami Tolvanen
2017-11-30 23:39     ` Sami Tolvanen
2017-11-30 23:39   ` [PATCH v2 3/7] kbuild: add ld-name macro Sami Tolvanen
2017-11-30 23:39     ` Sami Tolvanen
2017-11-30 23:39   ` [PATCH v2 4/7] kbuild: add __ld-ifversion and linker-specific macros Sami Tolvanen
2017-11-30 23:39     ` Sami Tolvanen
2017-11-30 23:39   ` [PATCH v2 5/7] arm64: fix -m for GNU gold Sami Tolvanen
2017-11-30 23:39     ` Sami Tolvanen
2017-11-30 23:39   ` [PATCH v2 6/7] arm64: explicitly pass --no-fix-cortex-a53-843419 to " Sami Tolvanen
2017-11-30 23:39     ` Sami Tolvanen
2017-12-01  0:13     ` Nick Desaulniers
2017-12-01  0:13       ` Nick Desaulniers
2017-11-30 23:39   ` [PATCH v2 7/7] arm64: add a workaround for GNU gold with ARM64_MODULE_PLTS Sami Tolvanen
2017-11-30 23:39     ` Sami Tolvanen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171129234442.655-2-samitolvanen@google.com \
    --to=samitolvanen@google.com \
    --cc=ak@linux.intel.com \
    --cc=alxmtvv@gmail.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=ghackmann@google.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxim.kuvyrkov@linaro.org \
    --cc=michal.lkml@markovi.net \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=npiggin@gmail.com \
    --cc=yamada.masahiro@socionext.com \
    --cc=ynorov@caviumnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.