All of lore.kernel.org
 help / color / mirror / Atom feed
From: shawnguo@kernel.org (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2] arm: dts: ls1021a: fix the value of TMR_FIPER1
Date: Thu, 30 Nov 2017 08:29:06 +0800	[thread overview]
Message-ID: <20171130002905.GA22908@dragon> (raw)
In-Reply-To: <20171129065458.4235-1-yangbo.lu@nxp.com>

On Wed, Nov 29, 2017 at 02:54:58PM +0800, Yangbo Lu wrote:
> The timer fixed interval period pulse generator register
> is used to generate periodic pulses. The down count
> register loads the value programmed in the fixed period
> interval (FIPER). At every tick of the timer accumulator
> overflow, the counter decrements by the value of
> TMR_CTRL[TCLK_PERIOD]. It generates a pulse when the down
> counter value reaches zero. It reloads the down counter
> in the cycle following a pulse. To use the TMR_FIPER1
> register to generate a 1 PPS event, the value
> (10^9 nanoseconds) - TCLK_PERIOD should be programmed.
> It should be 999999995 not 999999990 since TCLK_PERIOD
> is 5.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>


Again, for arm dts, we usually use prefix like 'ARM: dts: ...'

I fixed it up and applied the patch.

Shawn

> ---
> Changes for v2:
> 	- Added Shawn into cc list.
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 64249726b3cb..a861a4b9e319 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -589,7 +589,7 @@
>  			fsl,tclk-period = <5>;
>  			fsl,tmr-prsc    = <2>;
>  			fsl,tmr-add     = <0xaaaaaaab>;
> -			fsl,tmr-fiper1  = <999999990>;
> +			fsl,tmr-fiper1  = <999999995>;
>  			fsl,tmr-fiper2  = <99990>;
>  			fsl,max-adj     = <499999999>;
>  		};
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Yangbo Lu <yangbo.lu-3arQi8VN3Tc@public.gmane.org>
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>
Subject: Re: [v2] arm: dts: ls1021a: fix the value of TMR_FIPER1
Date: Thu, 30 Nov 2017 08:29:06 +0800	[thread overview]
Message-ID: <20171130002905.GA22908@dragon> (raw)
In-Reply-To: <20171129065458.4235-1-yangbo.lu-3arQi8VN3Tc@public.gmane.org>

On Wed, Nov 29, 2017 at 02:54:58PM +0800, Yangbo Lu wrote:
> The timer fixed interval period pulse generator register
> is used to generate periodic pulses. The down count
> register loads the value programmed in the fixed period
> interval (FIPER). At every tick of the timer accumulator
> overflow, the counter decrements by the value of
> TMR_CTRL[TCLK_PERIOD]. It generates a pulse when the down
> counter value reaches zero. It reloads the down counter
> in the cycle following a pulse. To use the TMR_FIPER1
> register to generate a 1 PPS event, the value
> (10^9 nanoseconds) - TCLK_PERIOD should be programmed.
> It should be 999999995 not 999999990 since TCLK_PERIOD
> is 5.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu-3arQi8VN3Tc@public.gmane.org>


Again, for arm dts, we usually use prefix like 'ARM: dts: ...'

I fixed it up and applied the patch.

Shawn

> ---
> Changes for v2:
> 	- Added Shawn into cc list.
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 64249726b3cb..a861a4b9e319 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -589,7 +589,7 @@
>  			fsl,tclk-period = <5>;
>  			fsl,tmr-prsc    = <2>;
>  			fsl,tmr-add     = <0xaaaaaaab>;
> -			fsl,tmr-fiper1  = <999999990>;
> +			fsl,tmr-fiper1  = <999999995>;
>  			fsl,tmr-fiper2  = <99990>;
>  			fsl,max-adj     = <499999999>;
>  		};
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Yangbo Lu <yangbo.lu@nxp.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Mark Rutland <mark.rutland@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>
Subject: Re: [v2] arm: dts: ls1021a: fix the value of TMR_FIPER1
Date: Thu, 30 Nov 2017 08:29:06 +0800	[thread overview]
Message-ID: <20171130002905.GA22908@dragon> (raw)
In-Reply-To: <20171129065458.4235-1-yangbo.lu@nxp.com>

On Wed, Nov 29, 2017 at 02:54:58PM +0800, Yangbo Lu wrote:
> The timer fixed interval period pulse generator register
> is used to generate periodic pulses. The down count
> register loads the value programmed in the fixed period
> interval (FIPER). At every tick of the timer accumulator
> overflow, the counter decrements by the value of
> TMR_CTRL[TCLK_PERIOD]. It generates a pulse when the down
> counter value reaches zero. It reloads the down counter
> in the cycle following a pulse. To use the TMR_FIPER1
> register to generate a 1 PPS event, the value
> (10^9 nanoseconds) - TCLK_PERIOD should be programmed.
> It should be 999999995 not 999999990 since TCLK_PERIOD
> is 5.
> 
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>


Again, for arm dts, we usually use prefix like 'ARM: dts: ...'

I fixed it up and applied the patch.

Shawn

> ---
> Changes for v2:
> 	- Added Shawn into cc list.
> ---
>  arch/arm/boot/dts/ls1021a.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 64249726b3cb..a861a4b9e319 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -589,7 +589,7 @@
>  			fsl,tclk-period = <5>;
>  			fsl,tmr-prsc    = <2>;
>  			fsl,tmr-add     = <0xaaaaaaab>;
> -			fsl,tmr-fiper1  = <999999990>;
> +			fsl,tmr-fiper1  = <999999995>;
>  			fsl,tmr-fiper2  = <99990>;
>  			fsl,max-adj     = <499999999>;
>  		};
> -- 
> 2.14.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-11-30  0:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-29  6:54 [v2] arm: dts: ls1021a: fix the value of TMR_FIPER1 Yangbo Lu
2017-11-29  6:54 ` Yangbo Lu
2017-11-29  6:54 ` Yangbo Lu
2017-11-30  0:29 ` Shawn Guo [this message]
2017-11-30  0:29   ` Shawn Guo
2017-11-30  0:29   ` Shawn Guo
2017-12-18  2:51   ` Y.b. Lu
2017-12-18  2:51     ` Y.b. Lu
2017-12-18  2:51     ` Y.b. Lu
2017-12-20  3:33     ` Shawn Guo
2017-12-20  3:33       ` Shawn Guo
2017-12-20  3:33       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130002905.GA22908@dragon \
    --to=shawnguo@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.