From: Thiago Rafael Becker <thiago.becker@gmail.com>
To: bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org,
Thiago Rafael Becker <thiago.becker@gmail.com>
Subject: [PATCH 1/3, V2] kernel: make groups_sort globally visible
Date: Thu, 30 Nov 2017 11:04:55 -0200 [thread overview]
Message-ID: <20171130130457.11429-2-thiago.becker@gmail.com> (raw)
In-Reply-To: <20171130130457.11429-1-thiago.becker@gmail.com>
In preparation to move group_info sorting to the caller,
make group_sort globally visible.
Signed-off-by: Thiago Rafael Becker <thiago.becker@gmail.com>
---
include/linux/cred.h | 1 +
kernel/groups.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/cred.h b/include/linux/cred.h
index 099058e..6312865 100644
--- a/include/linux/cred.h
+++ b/include/linux/cred.h
@@ -83,6 +83,7 @@ extern int set_current_groups(struct group_info *);
extern void set_groups(struct cred *, struct group_info *);
extern int groups_search(const struct group_info *, kgid_t);
extern bool may_setgroups(void);
+extern void groups_sort(struct group_info *group_info);
/*
* The security context of a task
diff --git a/kernel/groups.c b/kernel/groups.c
index e357bc8..4c9c9ed 100644
--- a/kernel/groups.c
+++ b/kernel/groups.c
@@ -86,11 +86,13 @@ static int gid_cmp(const void *_a, const void *_b)
return gid_gt(a, b) - gid_lt(a, b);
}
-static void groups_sort(struct group_info *group_info)
+void groups_sort(struct group_info *group_info)
{
sort(group_info->gid, group_info->ngroups, sizeof(*group_info->gid),
gid_cmp, NULL);
}
+EXPORT_SYMBOL(groups_sort);
+
/* a simple bsearch */
int groups_search(const struct group_info *group_info, kgid_t grp)
--
2.9.5
next prev parent reply other threads:[~2017-11-30 13:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:04 [PATCH 0/3, V2] Move groups_sort outisde of set_groups Thiago Rafael Becker
2017-11-30 13:04 ` Thiago Rafael Becker [this message]
2017-11-30 13:04 ` [PATCH 2/3, V2] kernel: Move groups_sort to the caller " Thiago Rafael Becker
2017-12-03 12:56 ` kbuild test robot
2017-12-04 1:42 ` NeilBrown
2017-12-04 15:39 ` Thiago Rafael Becker
2017-12-04 15:47 ` J. Bruce Fields
2017-12-04 19:00 ` Thiago Rafael Becker
2017-12-04 20:11 ` NeilBrown
2017-12-05 21:28 ` Matthew Wilcox
2017-12-05 22:05 ` NeilBrown
2017-12-05 23:03 ` Thiago Rafael Becker
2017-12-05 23:23 ` Matthew Wilcox
2017-12-19 16:30 ` J. Bruce Fields
2017-12-19 20:14 ` NeilBrown
2017-11-30 13:04 ` [PATCH 3/3, V2] kernel: set_groups doesn't call groups_sort anymore Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 0/3 v3] Move groups_sort outisde of set_groups Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 1/3 v3] kernel: make groups_sort globally visible Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 2/3 v3] kernel: Move groups_sort to the caller of set_groups Thiago Rafael Becker
2017-12-05 18:55 ` [PATCH 2/3] " Thiago Rafael Becker
2017-12-05 22:08 ` NeilBrown
2017-12-05 18:57 ` [PATCH 2/3 v3] " Thiago Rafael Becker
2017-12-05 14:05 ` [PATCH 3/3 v3] kernel: set_groups doesn't call groups_sort anymore Thiago Rafael Becker
2017-12-06 19:27 ` [PATCH 0/3 v3] Move groups_sort outisde of set_groups J. Bruce Fields
2017-12-11 13:28 ` [PATCH v4] kernel: make groups_sort calling a responsibility group_info allocators Thiago Rafael Becker
2017-12-11 14:27 ` Matthew Wilcox
2017-12-11 15:14 ` [PATCH v5] " Thiago Rafael Becker
2017-12-11 15:24 ` Matthew Wilcox
2017-12-11 16:18 ` J. Bruce Fields
2017-12-11 21:43 ` NeilBrown
2017-12-11 21:43 ` NeilBrown
2018-01-02 14:54 ` David Howells
2018-01-02 21:01 ` [PATCH] Documentation: security/credentials.rst: explain need to sort group_list NeilBrown
2018-01-02 21:04 ` Matthew Wilcox
2018-01-06 18:09 ` Jonathan Corbet
2018-01-06 20:20 ` Matthew Wilcox
2018-01-06 22:36 ` Randy Dunlap
2018-01-08 16:36 ` Jonathan Corbet
2018-01-07 23:39 ` NeilBrown
2018-01-08 16:40 ` Jonathan Corbet
2018-01-08 16:40 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130130457.11429-2-thiago.becker@gmail.com \
--to=thiago.becker@gmail.com \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.