From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-trivial] [PATCH 0/3] macro do/while (0) cleanup
Date: Thu, 30 Nov 2017 07:41:56 -0600 [thread overview]
Message-ID: <20171130134159.9697-1-eblake@redhat.com> (raw)
Noticed this by chance in the tests/ directory, so I broadened
it to a grep of the entire code base. I suspect many of the
bad macros were the victims of copy-and-paste from some other
bad location (particularly given how many bit-rotten debug
print macros were involved).
https://wiki.qemu.org/BiteSizedTasks#Bitrot_prevention is still
left for someone else, for another day.
Eric Blake (3):
net: Drop unusual use of do { } while (0);
mips: Tweak location of ';' in macros
maint: Fix macros with broken 'do/while(0);' usage
tests/acpi-utils.h | 8 ++++----
ui/sdl_zoom_template.h | 8 ++++----
audio/paaudio.c | 4 ++--
hw/adc/stm32f2xx_adc.c | 2 +-
hw/block/m25p80.c | 2 +-
hw/char/cadence_uart.c | 2 +-
hw/char/stm32f2xx_usart.c | 2 +-
hw/display/cg3.c | 2 +-
hw/display/dpcd.c | 2 +-
hw/display/xlnx_dp.c | 2 +-
hw/dma/pl330.c | 2 +-
hw/dma/xlnx-zynq-devcfg.c | 2 +-
hw/dma/xlnx_dpdma.c | 2 +-
hw/i2c/i2c-ddc.c | 2 +-
hw/misc/auxbus.c | 2 +-
hw/misc/macio/mac_dbdma.c | 4 ++--
hw/misc/mmio_interface.c | 2 +-
hw/misc/stm32f2xx_syscfg.c | 2 +-
hw/misc/zynq_slcr.c | 2 +-
hw/net/cadence_gem.c | 2 +-
hw/net/pcnet.c | 20 ++++++++++----------
hw/ssi/mss-spi.c | 2 +-
hw/ssi/stm32f2xx_spi.c | 2 +-
hw/ssi/xilinx_spi.c | 2 +-
hw/ssi/xilinx_spips.c | 2 +-
hw/timer/a9gtimer.c | 2 +-
hw/timer/cadence_ttc.c | 2 +-
hw/timer/mss-timer.c | 2 +-
hw/timer/stm32f2xx_timer.c | 2 +-
hw/tpm/tpm_passthrough.c | 2 +-
hw/tpm/tpm_tis.c | 2 +-
migration/rdma.c | 2 +-
target/arm/translate-a64.c | 2 +-
target/mips/msa_helper.c | 34 ++++++++++++++++++----------------
target/s390x/kvm.c | 2 +-
tests/tcg/test-mmap.c | 2 +-
36 files changed, 70 insertions(+), 68 deletions(-)
--
2.14.3
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org
Subject: [Qemu-devel] [PATCH 0/3] macro do/while (0) cleanup
Date: Thu, 30 Nov 2017 07:41:56 -0600 [thread overview]
Message-ID: <20171130134159.9697-1-eblake@redhat.com> (raw)
Noticed this by chance in the tests/ directory, so I broadened
it to a grep of the entire code base. I suspect many of the
bad macros were the victims of copy-and-paste from some other
bad location (particularly given how many bit-rotten debug
print macros were involved).
https://wiki.qemu.org/BiteSizedTasks#Bitrot_prevention is still
left for someone else, for another day.
Eric Blake (3):
net: Drop unusual use of do { } while (0);
mips: Tweak location of ';' in macros
maint: Fix macros with broken 'do/while(0);' usage
tests/acpi-utils.h | 8 ++++----
ui/sdl_zoom_template.h | 8 ++++----
audio/paaudio.c | 4 ++--
hw/adc/stm32f2xx_adc.c | 2 +-
hw/block/m25p80.c | 2 +-
hw/char/cadence_uart.c | 2 +-
hw/char/stm32f2xx_usart.c | 2 +-
hw/display/cg3.c | 2 +-
hw/display/dpcd.c | 2 +-
hw/display/xlnx_dp.c | 2 +-
hw/dma/pl330.c | 2 +-
hw/dma/xlnx-zynq-devcfg.c | 2 +-
hw/dma/xlnx_dpdma.c | 2 +-
hw/i2c/i2c-ddc.c | 2 +-
hw/misc/auxbus.c | 2 +-
hw/misc/macio/mac_dbdma.c | 4 ++--
hw/misc/mmio_interface.c | 2 +-
hw/misc/stm32f2xx_syscfg.c | 2 +-
hw/misc/zynq_slcr.c | 2 +-
hw/net/cadence_gem.c | 2 +-
hw/net/pcnet.c | 20 ++++++++++----------
hw/ssi/mss-spi.c | 2 +-
hw/ssi/stm32f2xx_spi.c | 2 +-
hw/ssi/xilinx_spi.c | 2 +-
hw/ssi/xilinx_spips.c | 2 +-
hw/timer/a9gtimer.c | 2 +-
hw/timer/cadence_ttc.c | 2 +-
hw/timer/mss-timer.c | 2 +-
hw/timer/stm32f2xx_timer.c | 2 +-
hw/tpm/tpm_passthrough.c | 2 +-
hw/tpm/tpm_tis.c | 2 +-
migration/rdma.c | 2 +-
target/arm/translate-a64.c | 2 +-
target/mips/msa_helper.c | 34 ++++++++++++++++++----------------
target/s390x/kvm.c | 2 +-
tests/tcg/test-mmap.c | 2 +-
36 files changed, 70 insertions(+), 68 deletions(-)
--
2.14.3
next reply other threads:[~2017-11-30 13:42 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:41 Eric Blake [this message]
2017-11-30 13:41 ` [Qemu-devel] [PATCH 0/3] macro do/while (0) cleanup Eric Blake
2017-11-30 13:41 ` [Qemu-trivial] [PATCH 1/3] net: Drop unusual use of do { } while (0); Eric Blake
2017-11-30 13:41 ` [Qemu-devel] " Eric Blake
2017-11-30 16:08 ` [Qemu-trivial] " Thomas Huth
2017-11-30 16:08 ` Thomas Huth
2017-11-30 13:41 ` [Qemu-trivial] [PATCH 2/3] mips: Tweak location of ';' in macros Eric Blake
2017-11-30 13:41 ` [Qemu-devel] " Eric Blake
2017-11-30 15:33 ` [Qemu-trivial] [Qemu-devel] [PATCH 2/3] mips: Tweak location of '; ' " Philippe Mathieu-Daudé
2017-11-30 15:33 ` [Qemu-devel] [PATCH 2/3] mips: Tweak location of ';' " Philippe Mathieu-Daudé
2017-11-30 13:41 ` [Qemu-trivial] [PATCH 3/3] maint: Fix macros with broken 'do/while(0); ' usage Eric Blake
2017-11-30 13:41 ` [Qemu-devel] " Eric Blake
2017-11-30 13:41 ` [Qemu-arm] " Eric Blake
2017-11-30 13:54 ` [Qemu-trivial] " Cornelia Huck
2017-11-30 13:54 ` [Qemu-devel] " Cornelia Huck
2017-11-30 13:54 ` [Qemu-arm] " Cornelia Huck
2017-11-30 14:43 ` [Qemu-trivial] " Michael S. Tsirkin
2017-11-30 14:43 ` [Qemu-devel] " Michael S. Tsirkin
2017-11-30 14:43 ` [Qemu-arm] " Michael S. Tsirkin
2017-11-30 14:55 ` [Qemu-trivial] " Eric Blake
2017-11-30 14:55 ` [Qemu-devel] " Eric Blake
2017-11-30 14:55 ` [Qemu-arm] " Eric Blake
2017-11-30 14:56 ` [Qemu-trivial] " Dr. David Alan Gilbert
2017-11-30 14:56 ` [Qemu-devel] " Dr. David Alan Gilbert
2017-11-30 14:56 ` [Qemu-arm] " Dr. David Alan Gilbert
2017-12-04 0:45 ` [Qemu-trivial] [Qemu-ppc] " David Gibson
2017-12-04 0:45 ` [Qemu-devel] " David Gibson
2017-12-04 0:45 ` [Qemu-arm] " David Gibson
2017-11-30 14:01 ` [Qemu-trivial] [PATCH 4/3] checkpatch: Enforce proper do/while (0) style Eric Blake
2017-11-30 14:01 ` [Qemu-devel] " Eric Blake
2017-11-30 17:00 ` [Qemu-trivial] " Eric Blake
2017-11-30 17:00 ` Eric Blake
2017-12-01 7:31 ` [Qemu-trivial] " Markus Armbruster
2017-12-01 7:31 ` Markus Armbruster
2017-12-01 14:22 ` [Qemu-trivial] " Eric Blake
2017-12-01 14:22 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171130134159.9697-1-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.