* [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
@ 2017-11-30 11:11 Gary Bisson
2017-11-30 12:41 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Gary Bisson @ 2017-11-30 11:11 UTC (permalink / raw)
To: buildroot
The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was
defined in kernel 4.2, so make sure the toolchain headers match this
requirement.
Fixes:
http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/
Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
---
package/gstreamer1/gst1-imx/Config.in | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in
index 9b977bdde8..cedd917019 100644
--- a/package/gstreamer1/gst1-imx/Config.in
+++ b/package/gstreamer1/gst1-imx/Config.in
@@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
bool "imxv4l2videosink"
select BR2_PACKAGE_GST1_PLUGINS_BAD
+ depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
help
Elements for V4L2 output
--
2.15.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
2017-11-30 11:11 [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin Gary Bisson
@ 2017-11-30 12:41 ` Thomas Petazzoni
2017-11-30 13:47 ` Gary Bisson
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-11-30 12:41 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 30 Nov 2017 12:11:22 +0100, Gary Bisson wrote:
> The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was
> defined in kernel 4.2, so make sure the toolchain headers match this
> requirement.
>
> Fixes:
> http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
> http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/
>
> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> ---
> package/gstreamer1/gst1-imx/Config.in | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in
> index 9b977bdde8..cedd917019 100644
> --- a/package/gstreamer1/gst1-imx/Config.in
> +++ b/package/gstreamer1/gst1-imx/Config.in
> @@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
> config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
> bool "imxv4l2videosink"
> select BR2_PACKAGE_GST1_PLUGINS_BAD
> + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
Thanks! However you need to add the corresponding Config.in comment.
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
2017-11-30 12:41 ` Thomas Petazzoni
@ 2017-11-30 13:47 ` Gary Bisson
2017-11-30 13:57 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Gary Bisson @ 2017-11-30 13:47 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Thu, Nov 30, 2017 at 01:41:54PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 30 Nov 2017 12:11:22 +0100, Gary Bisson wrote:
> > The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was
> > defined in kernel 4.2, so make sure the toolchain headers match this
> > requirement.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/
> > http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/
> >
> > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
> > ---
> > package/gstreamer1/gst1-imx/Config.in | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in
> > index 9b977bdde8..cedd917019 100644
> > --- a/package/gstreamer1/gst1-imx/Config.in
> > +++ b/package/gstreamer1/gst1-imx/Config.in
> > @@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC
> > config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK
> > bool "imxv4l2videosink"
> > select BR2_PACKAGE_GST1_PLUGINS_BAD
> > + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
>
> Thanks! However you need to add the corresponding Config.in comment.
Is a simple mention of the macro sufficient?
depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT
Or would rather have a full sentence above the 'depends'?
Regards,
Gary
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
2017-11-30 13:47 ` Gary Bisson
@ 2017-11-30 13:57 ` Thomas Petazzoni
2017-11-30 14:05 ` Gary Bisson
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2017-11-30 13:57 UTC (permalink / raw)
To: buildroot
Hello,
On Thu, 30 Nov 2017 14:47:05 +0100, Gary Bisson wrote:
> > Thanks! However you need to add the corresponding Config.in comment.
>
> Is a simple mention of the macro sufficient?
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT
>
> Or would rather have a full sentence above the 'depends'?
I'm talking about a Config.in comment, i.e
comment "feature foobaz needs kernel headers >= 4.2"
depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin
2017-11-30 13:57 ` Thomas Petazzoni
@ 2017-11-30 14:05 ` Gary Bisson
0 siblings, 0 replies; 5+ messages in thread
From: Gary Bisson @ 2017-11-30 14:05 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Thu, Nov 30, 2017 at 02:57:38PM +0100, Thomas Petazzoni wrote:
> Hello,
>
> On Thu, 30 Nov 2017 14:47:05 +0100, Gary Bisson wrote:
>
> > > Thanks! However you need to add the corresponding Config.in comment.
> >
> > Is a simple mention of the macro sufficient?
> > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT
> >
> > Or would rather have a full sentence above the 'depends'?
>
> I'm talking about a Config.in comment, i.e
>
> comment "feature foobaz needs kernel headers >= 4.2"
> depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
Right, completely forgot about that. I'll submit a v2 in no time.
Thanks,
Gary
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2017-11-30 14:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-30 11:11 [Buildroot] [PATCH][NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin Gary Bisson
2017-11-30 12:41 ` Thomas Petazzoni
2017-11-30 13:47 ` Gary Bisson
2017-11-30 13:57 ` Thomas Petazzoni
2017-11-30 14:05 ` Gary Bisson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.