All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/1] phy: Add 2.5G SGMII interface mode
Date: Thu, 30 Nov 2017 19:26:21 +0100	[thread overview]
Message-ID: <20171130182621.GC28828@lunn.ch> (raw)
In-Reply-To: <20171130181520.GF10595@n2100.armlinux.org.uk>

On Thu, Nov 30, 2017 at 06:15:20PM +0000, Russell King - ARM Linux wrote:
> On Thu, Nov 30, 2017 at 06:41:27PM +0100, Andrew Lunn wrote:
> > SGMII supports passing auto-negotiation results from the PHY to the
> > MAC. 1000BASE-X does not.
> > 
> > SGMII supports the PHY running at 10, 100, and 1000 Mbps. But to
> > support this, the MAC needs to replicate the bits 100, or 10 times
> > when the PHY is running in 10 or 100Mbps mode.
> > 
> > So with your 2.5G SGMII, you need to replicate the bits 250, 25, or
> > 2.5 times if they PHY is running at lower speeds. This last one is
> > interesting.
> 
> That's not what I've read so far - but I don't know about the PHY
> in this exact case because the docs are only available under NDA
> (which makes it incredibly difficult to have this discussion.)
> 
> However, from what I can ascertain from a Xilinx document, 2.5G is
> 1G SGMII clocked 2.5x faster.  When in 2.5G mode, the other modes
> are unavailable.

Hi Russell

Thanks for looking into the details.

So you need the PHY driver to see what it has negotiated, and when it
calls the adjust_link callback, the MAC needs look at the
phydev->interface and set the MAC to 2.5G SGMII or SGMII.

Same as the Marvell 10G PHY driver flips between
PHY_INTERFACE_MODE_10GKR and PHY_INTERFACE_MODE_SGMII depending on
what it has negotiated.

     Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux <linux@armlinux.org.uk>
Cc: Bhaskar Upadhaya <bhaskar.upadhaya@nxp.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] phy: Add 2.5G SGMII interface mode
Date: Thu, 30 Nov 2017 19:26:21 +0100	[thread overview]
Message-ID: <20171130182621.GC28828@lunn.ch> (raw)
In-Reply-To: <20171130181520.GF10595@n2100.armlinux.org.uk>

On Thu, Nov 30, 2017 at 06:15:20PM +0000, Russell King - ARM Linux wrote:
> On Thu, Nov 30, 2017 at 06:41:27PM +0100, Andrew Lunn wrote:
> > SGMII supports passing auto-negotiation results from the PHY to the
> > MAC. 1000BASE-X does not.
> > 
> > SGMII supports the PHY running at 10, 100, and 1000 Mbps. But to
> > support this, the MAC needs to replicate the bits 100, or 10 times
> > when the PHY is running in 10 or 100Mbps mode.
> > 
> > So with your 2.5G SGMII, you need to replicate the bits 250, 25, or
> > 2.5 times if they PHY is running at lower speeds. This last one is
> > interesting.
> 
> That's not what I've read so far - but I don't know about the PHY
> in this exact case because the docs are only available under NDA
> (which makes it incredibly difficult to have this discussion.)
> 
> However, from what I can ascertain from a Xilinx document, 2.5G is
> 1G SGMII clocked 2.5x faster.  When in 2.5G mode, the other modes
> are unavailable.

Hi Russell

Thanks for looking into the details.

So you need the PHY driver to see what it has negotiated, and when it
calls the adjust_link callback, the MAC needs look at the
phydev->interface and set the MAC to 2.5G SGMII or SGMII.

Same as the Marvell 10G PHY driver flips between
PHY_INTERFACE_MODE_10GKR and PHY_INTERFACE_MODE_SGMII depending on
what it has negotiated.

     Andrew

  reply	other threads:[~2017-11-30 18:26 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30  4:30 [PATCH 1/1] phy: Add 2.5G SGMII interface mode Bhaskar Upadhaya
2017-11-30  4:30 ` Bhaskar Upadhaya
2017-11-30 15:50 ` Andrew Lunn
2017-11-30 15:50   ` Andrew Lunn
2017-11-30 17:16   ` Bhaskar Upadhaya
2017-11-30 17:16     ` Bhaskar Upadhaya
2017-11-30 17:34     ` David Miller
2017-11-30 17:34       ` David Miller
2017-11-30 17:41     ` Andrew Lunn
2017-11-30 17:41       ` Andrew Lunn
2017-11-30 18:15       ` Russell King - ARM Linux
2017-11-30 18:15         ` Russell King - ARM Linux
2017-11-30 18:26         ` Andrew Lunn [this message]
2017-11-30 18:26           ` Andrew Lunn
2017-11-30 18:53           ` Russell King - ARM Linux
2017-11-30 18:53             ` Russell King - ARM Linux
2017-12-01 18:40             ` Bhaskar Upadhaya
2017-12-01 18:40               ` Bhaskar Upadhaya
2017-12-01 18:44               ` Florian Fainelli
2017-12-01 18:44                 ` Florian Fainelli
2017-12-01 19:12               ` Andrew Lunn
2017-12-01 19:12                 ` Andrew Lunn
2017-11-30 17:33   ` Russell King - ARM Linux
2017-11-30 17:33     ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171130182621.GC28828@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.