All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jsnow@redhat.com, famz@redhat.com,
	qemu-block@nongnu.org, vsementsov@virtuozzo.com,
	Max Reitz <mreitz@redhat.com>
Subject: [Qemu-devel] [PATCH v5 19/20] vvfat: Switch to .bdrv_co_block_status()
Date: Thu, 30 Nov 2017 19:42:41 -0600	[thread overview]
Message-ID: <20171201014242.16877-20-eblake@redhat.com> (raw)
In-Reply-To: <20171201014242.16877-1-eblake@redhat.com>

We are gradually moving away from sector-based interfaces, towards
byte-based.  Update the vvfat driver accordingly.  Note that we
can rely on the block driver having already clamped limits to our
block size, and simplify accordingly.

Signed-off-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>

---
v5: no change
v4: rebase to interface tweak
v3: no change
v2: rebase to earlier changes, simplify
---
 block/vvfat.c | 16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index a690595f2c..37d85a389f 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -3086,15 +3086,13 @@ vvfat_co_pwritev(BlockDriverState *bs, uint64_t offset, uint64_t bytes,
     return ret;
 }

-static int64_t coroutine_fn vvfat_co_get_block_status(BlockDriverState *bs,
-        int64_t sector_num, int nb_sectors, int *n, BlockDriverState **file)
+static int coroutine_fn vvfat_co_block_status(BlockDriverState *bs,
+                                              bool want_zero, int64_t offset,
+                                              int64_t bytes, int64_t *n,
+                                              int64_t *map,
+                                              BlockDriverState **file)
 {
-    *n = bs->total_sectors - sector_num;
-    if (*n > nb_sectors) {
-        *n = nb_sectors;
-    } else if (*n < 0) {
-        return 0;
-    }
+    *n = bytes;
     return BDRV_BLOCK_DATA;
 }

@@ -3255,7 +3253,7 @@ static BlockDriver bdrv_vvfat = {

     .bdrv_co_preadv         = vvfat_co_preadv,
     .bdrv_co_pwritev        = vvfat_co_pwritev,
-    .bdrv_co_get_block_status = vvfat_co_get_block_status,
+    .bdrv_co_block_status   = vvfat_co_block_status,
 };

 static void bdrv_vvfat_init(void)
-- 
2.14.3

  parent reply	other threads:[~2017-12-01 15:58 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  1:42 [Qemu-devel] [PATCH v5 00/20] add byte-based block_status driver callbacks Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 01/20] block: Add .bdrv_co_block_status() callback Eric Blake
2017-12-01 14:40   ` Kevin Wolf
2017-12-01 15:03     ` Eric Blake
2017-12-01 15:24       ` Kevin Wolf
2017-12-06 15:20         ` Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 02/20] block: Switch passthrough drivers to .bdrv_co_block_status() Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 03/20] file-posix: Switch " Eric Blake
2017-12-01 16:00   ` Kevin Wolf
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 04/20] gluster: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 05/20] iscsi: Switch cluster_sectors to byte-based Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 06/20] iscsi: Switch iscsi_allocmap_update() " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 07/20] iscsi: Switch to .bdrv_co_block_status() Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 08/20] null: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 09/20] parallels: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 10/20] qcow: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 11/20] qcow2: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 12/20] qed: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 13/20] raw: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 14/20] sheepdog: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 15/20] vdi: Avoid bitrot of debugging code Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 16/20] vdi: Switch to .bdrv_co_block_status() Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 17/20] vmdk: " Eric Blake
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 18/20] vpc: " Eric Blake
2017-12-01  1:42 ` Eric Blake [this message]
2017-12-01  1:42 ` [Qemu-devel] [PATCH v5 20/20] block: Drop unused .bdrv_co_get_block_status() Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201014242.16877-20-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=famz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=vsementsov@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.