From: Eric Wong <e@80x24.org>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test
Date: Fri, 1 Dec 2017 02:56:00 +0000 [thread overview]
Message-ID: <20171201025600.GA29213@starla> (raw)
In-Reply-To: <20171201023239.26153-1-tmz@pobox.com>
Todd Zullinger <tmz@pobox.com> wrote:
> These tests are not run by default nor are they enabled in travis-ci. I
> don't know how much testing they get in user or other packager builds.
>
> I've been slowly increasing the test suite usage in fedora builds. I
> ran into this while testing locally with parallel make test. The
> official fedora builds don't run in parallel (yet), as even before I ran
> into this issue, builds on the fedora builders randomly failed too
> often. I'm hoping to eventually enable parallel tests by default
> though, since it's so much faster.
Cool.
> I'm not sure if there's any objection to changing the variable needed to
> enable the tests from SVNSERVE_PORT to GIT_TEST_SVNSERVE. The way
> SVNSERVE_PORT is set in this patch should allow the port to be set
> explicitly, in case someone requires that -- and they understand that it
> can fail if running parallel tests, of course. Whether that's a
> feature or a bug, I'm not sure. :)
I'm fine with this for now. Since svnserve (and git-daemon)
both support inetd behavior, I think we can eventually have a
test helper which binds random ports and pretends to be an
inetd, letting the test run without any special setup.
It would let multiple test instances run in parallel, even.
> The indentation of lib-git-svn.sh didn't use tabs consistently, in only
> a few places, so I cleaned that up first. I can drop that change if
> it's unwanted.
Fine by me.
next prev parent reply other threads:[~2017-12-01 2:56 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 2:32 [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01 2:32 ` [PATCH 1/2] t/lib-git-svn: whitespace cleanup Todd Zullinger
2017-12-01 3:04 ` Jonathan Nieder
2017-12-01 3:42 ` Todd Zullinger
2017-12-01 3:56 ` Jonathan Nieder
2017-12-01 2:32 ` [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01 3:02 ` Jonathan Nieder
2017-12-01 3:45 ` Todd Zullinger
2017-12-01 3:53 ` Jonathan Nieder
2017-12-01 4:11 ` Todd Zullinger
2017-12-01 15:56 ` [PATCH v2 1/2] t/lib-git-svn: cleanup inconsistent tab/space usage Todd Zullinger
[not found] ` <20171201153241.27071-1-tmz@pobox.com>
2017-12-01 15:56 ` [PATCH v2 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01 20:06 ` Jonathan Nieder
2017-12-01 2:56 ` Eric Wong [this message]
2017-12-01 3:40 ` [PATCH 0/2] " Todd Zullinger
2017-12-01 3:07 ` Jonathan Nieder
2017-12-01 3:40 ` Todd Zullinger
2017-12-14 18:19 ` Todd Zullinger
2017-12-14 18:45 ` Junio C Hamano
2017-12-14 20:35 ` Todd Zullinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201025600.GA29213@starla \
--to=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=tmz@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.