All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Nieder <jrnieder@gmail.com>
To: Todd Zullinger <tmz@pobox.com>
Cc: git@vger.kernel.org, Eric Wong <e@80x24.org>
Subject: Re: [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test
Date: Thu, 30 Nov 2017 19:53:40 -0800	[thread overview]
Message-ID: <20171201035340.GJ20640@aiede.mtv.corp.google.com> (raw)
In-Reply-To: <20171201034519.GE3693@zaya.teonanacatl.net>

Todd Zullinger wrote:

> Much better, thank you.  How about this for the full commit message:
>
>    t/lib-git-svn.sh: improve svnserve tests with parallel make test
>
>    Setting SVNSERVE_PORT enables several tests which require a local
>    svnserve daemon to be run (in t9113 & t9126).  The tests share setup of
>    the local svnserve via `start_svnserve()`.  The function uses svnserve's
>    `--listen-once` option, which causes svnserve to accept one connection
>    on the port, serve it, and exit.  When running the tests in parallel
>    this fails if one test tries to start svnserve while the other is still
>    running.
>
>    Use the test number as the svnserve port (similar to httpd tests) to
>    avoid port conflicts.  Developers can set GIT_TEST_SVNSERVE to any value
>    other than 'false' or 'auto' to enable these tests.
>
> ?

Yep, with this description it is
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks for putting up with my nits. :)

Jonathan

  reply	other threads:[~2017-12-01  3:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-01  2:32 [PATCH 0/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01  2:32 ` [PATCH 1/2] t/lib-git-svn: whitespace cleanup Todd Zullinger
2017-12-01  3:04   ` Jonathan Nieder
2017-12-01  3:42     ` Todd Zullinger
2017-12-01  3:56       ` Jonathan Nieder
2017-12-01  2:32 ` [PATCH 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01  3:02   ` Jonathan Nieder
2017-12-01  3:45     ` Todd Zullinger
2017-12-01  3:53       ` Jonathan Nieder [this message]
2017-12-01  4:11         ` Todd Zullinger
2017-12-01 15:56           ` [PATCH v2 1/2] t/lib-git-svn: cleanup inconsistent tab/space usage Todd Zullinger
     [not found]             ` <20171201153241.27071-1-tmz@pobox.com>
2017-12-01 15:56               ` [PATCH v2 2/2] t/lib-git-svn.sh: improve svnserve tests with parallel make test Todd Zullinger
2017-12-01 20:06                 ` Jonathan Nieder
2017-12-01  2:56 ` [PATCH 0/2] " Eric Wong
2017-12-01  3:40   ` Todd Zullinger
2017-12-01  3:07 ` Jonathan Nieder
2017-12-01  3:40   ` Todd Zullinger
2017-12-14 18:19 ` Todd Zullinger
2017-12-14 18:45   ` Junio C Hamano
2017-12-14 20:35     ` Todd Zullinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171201035340.GJ20640@aiede.mtv.corp.google.com \
    --to=jrnieder@gmail.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=tmz@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.