From: Tony Lindgren <tony@atomide.com>
To: Andre Przywara <andre.przywara@arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Chen-Yu Tsai <wens@csie.org>, Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-gpio@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Icenowy Zheng <icenowy@aosc.xyz>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC PATCH 2/3] pinctrl: sunxi: introduce DT-based generic driver
Date: Fri, 1 Dec 2017 09:45:59 -0800 [thread overview]
Message-ID: <20171201174559.GR28152@atomide.com> (raw)
In-Reply-To: <20171113012523.2328-3-andre.przywara@arm.com>
* Andre Przywara <andre.przywara@arm.com> [171113 01:28]:
> This driver (shim) allows to fully describe an Allwinner pin controller
> and its GPIO ports in device tree nodes.
> It will read some newly introduced properties to build a table
> describing the pins and their routing. This table matches those that we
> have hardcoded for various SoCs in the kernel so far.
> After this table has been created, it will be handed over to the actual
> pinctrl driver, which registers it with the pinctrl subsystem.
Hmm so how come you're not using GENERIC_PINCTRL_GROUPS and
GENERIC_PINMUX_FUNCTIONS that we now have?
These together with the #pinctrl-cells property should make things
quite easy and should also simplify your binding hopefully.
Regards,
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH 2/3] pinctrl: sunxi: introduce DT-based generic driver
Date: Fri, 1 Dec 2017 09:45:59 -0800 [thread overview]
Message-ID: <20171201174559.GR28152@atomide.com> (raw)
In-Reply-To: <20171113012523.2328-3-andre.przywara@arm.com>
* Andre Przywara <andre.przywara@arm.com> [171113 01:28]:
> This driver (shim) allows to fully describe an Allwinner pin controller
> and its GPIO ports in device tree nodes.
> It will read some newly introduced properties to build a table
> describing the pins and their routing. This table matches those that we
> have hardcoded for various SoCs in the kernel so far.
> After this table has been created, it will be handed over to the actual
> pinctrl driver, which registers it with the pinctrl subsystem.
Hmm so how come you're not using GENERIC_PINCTRL_GROUPS and
GENERIC_PINMUX_FUNCTIONS that we now have?
These together with the #pinctrl-cells property should make things
quite easy and should also simplify your binding hopefully.
Regards,
Tony
next prev parent reply other threads:[~2017-12-01 17:46 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-13 1:25 [RFC PATCH 0/3] pinctrl: sunxi: Add DT-based generic pinctrl driver Andre Przywara
2017-11-13 1:25 ` Andre Przywara
[not found] ` <20171113012523.2328-1-andre.przywara-5wv7dgnIgG8@public.gmane.org>
2017-11-13 1:25 ` [RFC PATCH 1/3] dt-bindings: pinctrl: sunxi: document new generic binding Andre Przywara
2017-11-13 1:25 ` Andre Przywara
2017-11-20 18:52 ` Rob Herring
2017-11-20 18:52 ` Rob Herring
2017-11-24 10:19 ` Linus Walleij
2017-11-24 10:19 ` Linus Walleij
2017-11-24 10:52 ` Thierry Reding
2017-11-24 10:52 ` Thierry Reding
2017-11-24 12:04 ` Andre Przywara
2017-11-24 12:04 ` Andre Przywara
[not found] ` <20efcf8f-85a5-3cad-a84b-434ee5cad68e-5wv7dgnIgG8@public.gmane.org>
2017-11-24 13:31 ` Thierry Reding
2017-11-24 13:31 ` Thierry Reding
2017-11-24 17:19 ` Andre Przywara
2017-11-24 17:19 ` Andre Przywara
[not found] ` <0c8051e6-5d8c-32d6-97e4-11c2283da5b4-5wv7dgnIgG8@public.gmane.org>
2017-11-27 8:34 ` Maxime Ripard
2017-11-27 8:34 ` Maxime Ripard
2017-12-01 9:38 ` Linus Walleij
2017-12-01 9:38 ` Linus Walleij
2017-12-01 9:56 ` Linus Walleij
2017-12-01 9:56 ` Linus Walleij
[not found] ` <CACRpkdZ70a7Vk1QPFhkms6ucWmSH6rOUD9_J0h=NjhK+vfXNAA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-06 0:55 ` André Przywara
2017-12-06 0:55 ` André Przywara
[not found] ` <be52417d-9509-f638-65b6-f455fade0c39-5wv7dgnIgG8@public.gmane.org>
2017-12-12 10:52 ` Linus Walleij
2017-12-12 10:52 ` Linus Walleij
2017-11-24 11:58 ` Andre Przywara
2017-11-24 11:58 ` Andre Przywara
[not found] ` <CACRpkdbpfkM4odz425+4qyUCF5vqPWBQ=F5Yk7AtJL5SqXghpg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-24 12:03 ` Maxime Ripard
2017-11-24 12:03 ` Maxime Ripard
2017-11-13 1:25 ` [RFC PATCH 2/3] pinctrl: sunxi: introduce DT-based generic driver Andre Przywara
2017-11-13 1:25 ` Andre Przywara
2017-12-01 17:45 ` Tony Lindgren [this message]
2017-12-01 17:45 ` Tony Lindgren
2017-11-13 1:25 ` [RFC PATCH 3/3] arm64: dts: allwinner: enhance A64 .dtsi with new pinctrl binding Andre Przywara
2017-11-13 1:25 ` Andre Przywara
2017-11-24 10:28 ` [RFC PATCH 0/3] pinctrl: sunxi: Add DT-based generic pinctrl driver Linus Walleij
2017-11-24 10:28 ` Linus Walleij
2017-11-24 12:05 ` Andre Przywara
2017-11-24 12:05 ` Andre Przywara
[not found] ` <54ecfdf7-cf4a-3eae-2661-47fa668a6066-5wv7dgnIgG8@public.gmane.org>
2017-11-30 15:20 ` Linus Walleij
2017-11-30 15:20 ` Linus Walleij
[not found] ` <CACRpkdZQPspH79_nS-WgiSg6d2meXUztgocYbxO07vTgP1HehA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-30 15:55 ` Andre Przywara
2017-11-30 15:55 ` Andre Przywara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171201174559.GR28152@atomide.com \
--to=tony@atomide.com \
--cc=andre.przywara@arm.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.xyz \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.