From: andrew@lunn.ch (Andrew Lunn)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH net-next 5/5] net: phy: realtek: add utility functions to read/write page addresses
Date: Sun, 3 Dec 2017 04:29:47 +0100 [thread overview]
Message-ID: <20171203032947.GE21613@lunn.ch> (raw)
In-Reply-To: <20171202215128.20202-6-martin.blumenstingl@googlemail.com>
On Sat, Dec 02, 2017 at 10:51:28PM +0100, Martin Blumenstingl wrote:
> Realtek PHYs implement the concept of so-called "extension pages". The
> reason for this is probably because these PHYs expose more registers
> than available in the standard address range.
> After all read/write operations on such a page are done the driver
> should switch back to page 0 where the standard MII registers (such as
> MII_BMCR) are available.
>
> When referring to such a register the datasheets of RTL8211E and
> RTL8211F always specify:
> - the page / "ext. page" which has to be written to RTL821x_PAGE_SELECT
> - an address (sometimes also called reg)
>
> These new utility functions make the existing code easier to read since
> it removes some duplication (switching back to page 0 is done within the
> new helpers for example).
>
> No functional changes are intended.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: netdev@vger.kernel.org, f.fainelli@gmail.com,
linux-amlogic@lists.infradead.org, hkallweit1@gmail.com,
Shengzhou.Liu@freescale.com, jaswinder.singh@linaro.org
Subject: Re: [PATCH net-next 5/5] net: phy: realtek: add utility functions to read/write page addresses
Date: Sun, 3 Dec 2017 04:29:47 +0100 [thread overview]
Message-ID: <20171203032947.GE21613@lunn.ch> (raw)
In-Reply-To: <20171202215128.20202-6-martin.blumenstingl@googlemail.com>
On Sat, Dec 02, 2017 at 10:51:28PM +0100, Martin Blumenstingl wrote:
> Realtek PHYs implement the concept of so-called "extension pages". The
> reason for this is probably because these PHYs expose more registers
> than available in the standard address range.
> After all read/write operations on such a page are done the driver
> should switch back to page 0 where the standard MII registers (such as
> MII_BMCR) are available.
>
> When referring to such a register the datasheets of RTL8211E and
> RTL8211F always specify:
> - the page / "ext. page" which has to be written to RTL821x_PAGE_SELECT
> - an address (sometimes also called reg)
>
> These new utility functions make the existing code easier to read since
> it removes some duplication (switching back to page 0 is done within the
> new helpers for example).
>
> No functional changes are intended.
>
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2017-12-03 3:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-02 21:51 [PATCH net-next 0/5] Realtek Ethernet PHY driver improvements Martin Blumenstingl
2017-12-02 21:51 ` Martin Blumenstingl
2017-12-02 21:51 ` [PATCH net-next 1/5] net: phy: realtek: use the BIT and GENMASK macros Martin Blumenstingl
2017-12-02 21:51 ` Martin Blumenstingl
2017-12-03 3:24 ` Andrew Lunn
2017-12-03 3:24 ` Andrew Lunn
2017-12-02 21:51 ` [PATCH net-next 2/5] net: phy: realtek: rename RTL821x_INER_INIT to RTL8211B_INER_INIT Martin Blumenstingl
2017-12-02 21:51 ` Martin Blumenstingl
2017-12-03 3:24 ` Andrew Lunn
2017-12-03 3:24 ` Andrew Lunn
2017-12-02 21:51 ` [PATCH net-next 3/5] net: phy: realtek: group all register bit #defines for RTL821x_INER Martin Blumenstingl
2017-12-02 21:51 ` Martin Blumenstingl
2017-12-03 3:25 ` Andrew Lunn
2017-12-03 3:25 ` Andrew Lunn
2017-12-02 21:51 ` [PATCH net-next 4/5] net: phy: realtek: use the same indentation for all #defines Martin Blumenstingl
2017-12-02 21:51 ` Martin Blumenstingl
2017-12-03 3:26 ` Andrew Lunn
2017-12-03 3:26 ` Andrew Lunn
2017-12-02 21:51 ` [PATCH net-next 5/5] net: phy: realtek: add utility functions to read/write page addresses Martin Blumenstingl
2017-12-02 21:51 ` Martin Blumenstingl
2017-12-03 3:29 ` Andrew Lunn [this message]
2017-12-03 3:29 ` Andrew Lunn
2017-12-03 14:38 ` [PATCH net-next 0/5] Realtek Ethernet PHY driver improvements David Miller
2017-12-03 14:38 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171203032947.GE21613@lunn.ch \
--to=andrew@lunn.ch \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.