All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: "santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org"
	<santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Cc: Dave Gerlach <d-gerlach-l0cyMroinI0@public.gmane.org>,
	Santosh Shilimkar
	<ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	Keerthy J <j-keerthy-l0cyMroinI0@public.gmane.org>,
	Johan Hovold <johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Subject: Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver
Date: Sun, 3 Dec 2017 08:36:32 -0800	[thread overview]
Message-ID: <20171203163632.GU28152@atomide.com> (raw)
In-Reply-To: <179c7668-05eb-09cf-9857-7b6fd2308c3a-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>

* santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org <santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org> [171203 04:03]:
> 
> 
> On 11/30/17 2:56 PM, Dave Gerlach wrote:
> > This is a resend of v5 of this series found here [1]. It introduces
> > relocatable PM handlers for the emif that are copied to sram and
> > run from there during low power mode entry.
> > 
> > The patches still have the previous ACKs but have a small change to
> > accomodate a change made by Tony in commit cd57dc5a2099 ("ARM: dts:
> > Add missing hwmod related nodes for am33xx"). If there are objections
> > to this let me know ASAP.
> > 
> > Now that a hwmod is present for the am335x EMIF, on probe fail the call to
> > pm_runtime_put_sync causes the board to hang. In fact, this emif driver should
> > never alter the PM state of the hardware at all through normal kernel calls, it
> > is the job of the suspend handlers that are added, that is the whole point of
> > this driver. Because of this, I have dropped all runtime pm calls, as any
> > change to the PM state while the kernel is running is dangerous as we may shut
> > of the memory controller. It makes the most sense just to drop runtime PM from
> > the driver entirely. Besides that patch is unchanged.
> > 
> > This code is required for low-power modes to work on AM335x and AM437x and a
> > forthcoming PM series for those platforms will depend on this series. After
> > both this and the PM series are reviewed I will send the necessary device tree
> > changes for both, but in the meantime all remaining patches for am335x and
> > am437x PM can be found here [2].
> > 
> Applied

OK, do you have some immutable commit for these I can pull in too for
the related SoC changes?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver
Date: Sun, 3 Dec 2017 08:36:32 -0800	[thread overview]
Message-ID: <20171203163632.GU28152@atomide.com> (raw)
In-Reply-To: <179c7668-05eb-09cf-9857-7b6fd2308c3a@oracle.com>

* santosh.shilimkar at oracle.com <santosh.shilimkar@oracle.com> [171203 04:03]:
> 
> 
> On 11/30/17 2:56 PM, Dave Gerlach wrote:
> > This is a resend of v5 of this series found here [1]. It introduces
> > relocatable PM handlers for the emif that are copied to sram and
> > run from there during low power mode entry.
> > 
> > The patches still have the previous ACKs but have a small change to
> > accomodate a change made by Tony in commit cd57dc5a2099 ("ARM: dts:
> > Add missing hwmod related nodes for am33xx"). If there are objections
> > to this let me know ASAP.
> > 
> > Now that a hwmod is present for the am335x EMIF, on probe fail the call to
> > pm_runtime_put_sync causes the board to hang. In fact, this emif driver should
> > never alter the PM state of the hardware at all through normal kernel calls, it
> > is the job of the suspend handlers that are added, that is the whole point of
> > this driver. Because of this, I have dropped all runtime pm calls, as any
> > change to the PM state while the kernel is running is dangerous as we may shut
> > of the memory controller. It makes the most sense just to drop runtime PM from
> > the driver entirely. Besides that patch is unchanged.
> > 
> > This code is required for low-power modes to work on AM335x and AM437x and a
> > forthcoming PM series for those platforms will depend on this series. After
> > both this and the PM series are reviewed I will send the necessary device tree
> > changes for both, but in the meantime all remaining patches for am335x and
> > am437x PM can be found here [2].
> > 
> Applied

OK, do you have some immutable commit for these I can pull in too for
the related SoC changes?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
Cc: Dave Gerlach <d-gerlach@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Keerthy J <j-keerthy@ti.com>, Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver
Date: Sun, 3 Dec 2017 08:36:32 -0800	[thread overview]
Message-ID: <20171203163632.GU28152@atomide.com> (raw)
In-Reply-To: <179c7668-05eb-09cf-9857-7b6fd2308c3a@oracle.com>

* santosh.shilimkar@oracle.com <santosh.shilimkar@oracle.com> [171203 04:03]:
> 
> 
> On 11/30/17 2:56 PM, Dave Gerlach wrote:
> > This is a resend of v5 of this series found here [1]. It introduces
> > relocatable PM handlers for the emif that are copied to sram and
> > run from there during low power mode entry.
> > 
> > The patches still have the previous ACKs but have a small change to
> > accomodate a change made by Tony in commit cd57dc5a2099 ("ARM: dts:
> > Add missing hwmod related nodes for am33xx"). If there are objections
> > to this let me know ASAP.
> > 
> > Now that a hwmod is present for the am335x EMIF, on probe fail the call to
> > pm_runtime_put_sync causes the board to hang. In fact, this emif driver should
> > never alter the PM state of the hardware at all through normal kernel calls, it
> > is the job of the suspend handlers that are added, that is the whole point of
> > this driver. Because of this, I have dropped all runtime pm calls, as any
> > change to the PM state while the kernel is running is dangerous as we may shut
> > of the memory controller. It makes the most sense just to drop runtime PM from
> > the driver entirely. Besides that patch is unchanged.
> > 
> > This code is required for low-power modes to work on AM335x and AM437x and a
> > forthcoming PM series for those platforms will depend on this series. After
> > both this and the PM series are reviewed I will send the necessary device tree
> > changes for both, but in the meantime all remaining patches for am335x and
> > am437x PM can be found here [2].
> > 
> Applied

OK, do you have some immutable commit for these I can pull in too for
the related SoC changes?

Regards,

Tony

  parent reply	other threads:[~2017-12-03 16:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 22:56 [PATCH v6 0/2] memory: Introduce ti-emif-sram driver Dave Gerlach
2017-11-30 22:56 ` Dave Gerlach
2017-11-30 22:56 ` Dave Gerlach
     [not found] ` <1512082568-5012-1-git-send-email-d-gerlach-l0cyMroinI0@public.gmane.org>
2017-11-30 22:56   ` [PATCH v6 1/2] Documentation: dt: Update ti,emif bindings Dave Gerlach
2017-11-30 22:56     ` Dave Gerlach
2017-11-30 22:56     ` Dave Gerlach
2017-11-30 22:56 ` [PATCH v6 2/2] memory: ti-emif-sram: introduce relocatable suspend/resume handlers Dave Gerlach
2017-11-30 22:56   ` Dave Gerlach
2017-11-30 22:56   ` Dave Gerlach
2017-12-01 17:54 ` [PATCH v6 0/2] memory: Introduce ti-emif-sram driver Tony Lindgren
2017-12-01 17:54   ` Tony Lindgren
     [not found]   ` <20171201175418.GS28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-12-01 21:58     ` Santosh Shilimkar
2017-12-01 21:58       ` Santosh Shilimkar
2017-12-01 21:58       ` Santosh Shilimkar
2017-12-03  4:00 ` santosh.shilimkar
2017-12-03  4:00   ` santosh.shilimkar
2017-12-03  4:00   ` santosh.shilimkar at oracle.com
     [not found]   ` <179c7668-05eb-09cf-9857-7b6fd2308c3a-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
2017-12-03 16:36     ` Tony Lindgren [this message]
2017-12-03 16:36       ` Tony Lindgren
2017-12-03 16:36       ` Tony Lindgren
     [not found]       ` <20171203163632.GU28152-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-12-04 17:35         ` Santosh Shilimkar
2017-12-04 17:35           ` Santosh Shilimkar
2017-12-04 17:35           ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171203163632.GU28152@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=d-gerlach-l0cyMroinI0@public.gmane.org \
    --cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=j-keerthy-l0cyMroinI0@public.gmane.org \
    --cc=johan-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org \
    --cc=ssantosh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.