From: Greg Kroah-Hartman <gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>
To: Dave Young <dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Matt Fleming
<matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>,
Ard Biesheuvel
<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
Linus Torvalds
<torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
"Tobin C. Harding" <me-xzjC0nNlxno@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [GIT PULL] hash addresses printed with %p
Date: Mon, 4 Dec 2017 08:36:42 +0100 [thread overview]
Message-ID: <20171204073642.GC19596@kroah.com> (raw)
In-Reply-To: <20171204020216.GA2436-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
On Mon, Dec 04, 2017 at 10:02:16AM +0800, Dave Young wrote:
> +#define __ATTR_IRUSR(_name) { \
> + .attr = { .name = __stringify(_name), .mode = S_IRUSR }, \
> + .show = _name##_show, \
> +}
Ick, no, as others, including Linus, have said, using IRUSER is a pain
in the ass to try to look up and remember what it is...
Just use __ATTR() please, it should be fine for what you need to do,
which is special-case a sysfs attribute.
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Dave Young <dyoung@redhat.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
"Tobin C. Harding" <me@tobin.cc>,
LKML <linux-kernel@vger.kernel.org>,
"linux-efi@vger.kernel.org" <linux-efi@vger.kernel.org>
Subject: Re: [GIT PULL] hash addresses printed with %p
Date: Mon, 4 Dec 2017 08:36:42 +0100 [thread overview]
Message-ID: <20171204073642.GC19596@kroah.com> (raw)
In-Reply-To: <20171204020216.GA2436@dhcp-128-65.nay.redhat.com>
On Mon, Dec 04, 2017 at 10:02:16AM +0800, Dave Young wrote:
> +#define __ATTR_IRUSR(_name) { \
> + .attr = { .name = __stringify(_name), .mode = S_IRUSR }, \
> + .show = _name##_show, \
> +}
Ick, no, as others, including Linus, have said, using IRUSER is a pain
in the ass to try to look up and remember what it is...
Just use __ATTR() please, it should be fine for what you need to do,
which is special-case a sysfs attribute.
thanks,
greg k-h
next prev parent reply other threads:[~2017-12-04 7:36 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 4:59 [GIT PULL] hash addresses printed with %p Tobin C. Harding
2017-11-29 19:22 ` Linus Torvalds
2017-11-29 19:39 ` Linus Torvalds
2017-11-29 20:54 ` Joe Perches
2017-11-29 21:05 ` Linus Torvalds
2017-11-29 21:31 ` Kees Cook
2017-11-29 21:08 ` Tobin C. Harding
2017-11-29 21:14 ` Linus Torvalds
2017-11-29 21:28 ` Tobin C. Harding
2017-11-29 21:36 ` Linus Torvalds
[not found] ` <CA+55aFwPXV0sXb+edcQc4epz0pWustZgJsoq95=a3OEDxynq7g-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-11-30 16:32 ` Greg Kroah-Hartman
2017-11-30 16:32 ` Greg Kroah-Hartman
[not found] ` <20171130163235.GA27849-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-30 17:10 ` Greg Kroah-Hartman
2017-11-30 17:10 ` Greg Kroah-Hartman
[not found] ` <20171130171036.GB31817-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-11-30 17:18 ` Ard Biesheuvel
2017-11-30 17:18 ` Ard Biesheuvel
2017-12-01 9:48 ` Greg Kroah-Hartman
2017-12-01 9:54 ` Ard Biesheuvel
[not found] ` <CAKv+Gu-YyuE-Hs4MVPWfS8Exx0S6qo5sgV2VdO0MP5wEXSrM1Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-01 15:34 ` Greg Kroah-Hartman
2017-12-01 15:34 ` Greg Kroah-Hartman
[not found] ` <20171201153444.GA17867-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-01 16:33 ` Kees Cook
2017-12-01 16:33 ` Kees Cook
2017-12-02 8:51 ` Ard Biesheuvel
2017-12-02 22:22 ` Matt Fleming
2017-12-02 22:22 ` Matt Fleming
[not found] ` <20171202222244.GA3799-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2017-12-03 1:15 ` Dave Young
2017-12-03 1:15 ` Dave Young
2017-12-04 2:02 ` Dave Young
2017-12-04 2:02 ` Dave Young
2017-12-04 2:33 ` Joe Perches
[not found] ` <1512354837.6321.41.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2017-12-04 2:39 ` Dave Young
2017-12-04 2:39 ` Dave Young
[not found] ` <20171204020216.GA2436-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-04 7:36 ` Greg Kroah-Hartman [this message]
2017-12-04 7:36 ` Greg Kroah-Hartman
2017-12-04 9:29 ` Dave Young
[not found] ` <20171204092928.GA4421-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-04 9:34 ` Greg Kroah-Hartman
2017-12-04 9:34 ` Greg Kroah-Hartman
2017-12-04 9:48 ` Ard Biesheuvel
[not found] ` <CAKv+Gu8iOF1BCpZEVRwT=_6FbXsK0ve7fiWKA5R0D5x2P5MavA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-04 9:59 ` Greg Kroah-Hartman
2017-12-04 9:59 ` Greg Kroah-Hartman
[not found] ` <20171204095936.GA10547-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-04 10:03 ` Ard Biesheuvel
2017-12-04 10:03 ` Ard Biesheuvel
2017-12-04 10:11 ` Greg Kroah-Hartman
2017-12-04 12:51 ` David Laight
[not found] ` <d455baafa3d44669a774c7d555c01416-1XygrNkDbNvwg4NCKwmqgw@public.gmane.org>
2017-12-04 14:00 ` Greg Kroah-Hartman
2017-12-04 14:00 ` Greg Kroah-Hartman
[not found] ` <20171204140012.GA8744-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-05 5:14 ` Dave Young
2017-12-05 5:14 ` Dave Young
2017-12-05 8:09 ` Greg Kroah-Hartman
[not found] ` <20171205080957.GA18268-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-05 8:45 ` Dave Young
2017-12-05 8:45 ` Dave Young
2017-12-05 8:52 ` Greg Kroah-Hartman
[not found] ` <20171205085219.GA16055-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-12-05 9:25 ` Ard Biesheuvel
2017-12-05 9:25 ` Ard Biesheuvel
[not found] ` <CAKv+Gu9=4Rrgb3UgmP37LpTjd_xzZ2aVqA2KMAkek9Wxr8fSTA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-12-05 10:15 ` Greg Kroah-Hartman
2017-12-05 10:15 ` Greg Kroah-Hartman
2017-12-05 9:32 ` Dave Young
2017-12-05 9:32 ` Dave Young
[not found] ` <20171205084537.GA5974-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-05 9:24 ` Dave Young
2017-12-05 9:24 ` Dave Young
[not found] ` <20171205092410.GA16190-0VdLhd/A9Pl+NNSt+8eSiB/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2017-12-05 10:14 ` Greg Kroah-Hartman
2017-12-05 10:14 ` Greg Kroah-Hartman
2017-11-30 23:17 ` Linus Torvalds
2017-12-01 9:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204073642.GC19596@kroah.com \
--to=gregkh-hqyy1w1ycw8ekmwlsbkhg0b+6bgklq7r@public.gmane.org \
--cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
--cc=me-xzjC0nNlxno@public.gmane.org \
--cc=torvalds-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.