Re: [PATCH 1/5] lib/oe/package.py: Expose is_elf

[Olof Johansson <olof.johansson@axis.com>]

On 17-12-01 16:50 +0100, Olof Johansson wrote:
> is_elf/isELF had copies in both staging.bbclass and package.bbclass.
> After recent refactoring in staging.bbclass (involving breaking out the
> isELF function to is_elf in lib/oe/package.py), the implementions
> diverged. It would be beneficial to make everybody use this one
> implementation, so let's expose it here for others to use.
...
> +def is_elf(path, on_error=_is_elf_error):
...
> +    :param on_error: callable, gets called when an error occurs.
> +                     the callback takes a message parameter. A
> +                     default error handler is provided that prints
> +                     the message with 'bb.error'.
> +
...
> +    """
...
> +    if ret:
> +        error_cb('"file %s" failed')

This should be on_error, not error_cb, sorry! Will fix in v2,
together with not assuming "," in file output, as suggested by
Mark.

-- 
olofjn