From: Olof Johansson <olof.johansson@axis.com>
To: Mark Hatle <mark.hatle@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives
Date: Mon, 4 Dec 2017 11:00:28 +0100 [thread overview]
Message-ID: <20171204100028.d4nljjgntdlrcccg@axis.com> (raw)
In-Reply-To: <20171201211328.enhdinuar24niey7@axis.com>
On 17-12-01 22:13 +0100, Olof Johansson wrote:
> On 17-12-01 11:43 -0600, Mark Hatle wrote:
> > The original implementation did not include the ',' options because different
> > versions of file (as well as different architectures) would return different
> > strings.
> >
> > They all contains the same information, but order and inclusion of ',' changed
> > regularly.
> >
> > So I would caution that for this to check out a wide variety of host systems and
> > architectures would need to be verified. (It's very possible that all modern
> > systems now conform to a single standard...)
>
> I was a little bit worried about this, thanks, this is useful
> feedback. Perhaps dropping the "," while still retaining the
> whitespace delimitation could be enough, and still work with a
> variety of file implementations?
Reading more about this, I was wrong in calling it GNU file, I
don't know where I got that from. It actually seems to be only
one prevalent implementation, one written by Ian Darwin [0]:
> Who's using it?
>
> Most known BSD distributions (FreeBSD, NetBSD, Darwin/Mac OS X, etc)
> Every known Linux distribution
Could you elaborate on the portability issues you've seen?
0: http://www.darwinsys.com/file/
--
olofjn
next prev parent reply other threads:[~2017-12-04 10:00 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 15:50 [PATCH 0/5] Improve isELF, gets triggered by ELF anywhere in pathname Olof Johansson
2017-12-01 15:50 ` [PATCH 1/5] lib/oe/package.py: Expose is_elf Olof Johansson
2017-12-04 9:34 ` Olof Johansson
2017-12-01 15:50 ` [PATCH 2/5] package.bbclass: Make use of common is_elf function Olof Johansson
2017-12-01 15:50 ` [PATCH 3/5] lib/oe/package.py: is_elf: Don't let filename influence filetype Olof Johansson
2017-12-01 15:50 ` [PATCH 4/5] lib/oe/package.py: is_elf: Disallow shell specials to be expanded Olof Johansson
2017-12-01 15:50 ` [PATCH 5/5] lib/oe/package.py: is_elf: Make it less prone to false positives Olof Johansson
2017-12-01 17:43 ` Mark Hatle
2017-12-01 21:13 ` Olof Johansson
2017-12-04 10:00 ` Olof Johansson [this message]
2017-12-04 19:22 ` Mark Hatle
2017-12-04 12:36 ` Burton, Ross
2017-12-04 15:30 ` Olof Johansson
2017-12-04 15:33 ` Burton, Ross
2017-12-06 21:38 ` Burton, Ross
2017-12-18 11:06 ` Olof Johansson
2017-12-18 11:28 ` Burton, Ross
2017-12-18 12:00 ` Burton, Ross
2017-12-20 11:05 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204100028.d4nljjgntdlrcccg@axis.com \
--to=olof.johansson@axis.com \
--cc=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.