Re: Patch "x86/entry/64: Add missing irqflags tracing to native_load_gs_index()" has been added to the 4.9-stable tree

[Greg KH <gregkh@linuxfoundation.org>]

On Thu, Nov 30, 2017 at 10:50:22AM -0800, Andy Lutomirski wrote:
> On Thu, Nov 30, 2017 at 6:29 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> >
> >
> >> On Nov 30, 2017, at 12:44 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> >>
> >>> On Wed, Nov 29, 2017 at 08:23:10AM -0800, Andy Lutomirski wrote:
> >>> If this hasn't been released yet, please hold off.  It's buggy.
> >>
> >> Ah crap, I missed this and just released it.  Is there a fix for this in
> >> Linus's tree?  How "buggy" is it?
> >
> > It breaks suspend/resume on some configuration that I haven't quite figured out.  I think it only happens if (lockdep is on and some other unknown condition occurs) or (ftrace is actively tracing irq flags).  I have a fix, but I was waiting to for the OP to test it.
> >
> > I'll send the fix Linusward later today without the Tested-by if I don't hear anything.
> 
> I think the thing to do is to revert the patch from -stable.  The bug
> it fixes is very minor, and the regression is that it made a
> pre-existing bug in some nearly-undebuggable core resume code much
> easier to hit.  I don't feel comfortable with a backport of the latter
> fix until it has a good long soak in Linus' tree.

Ok, now reverted.  Should I do the same thing for the patch in
4.14-stable as well?

thanks,

greg k-h