From: Greg KH <gregkh@linuxfoundation.org>
To: NeilBrown <neilb@suse.com>
Cc: kumba@gentoo.org, shli@fb.com, stable@vger.kernel.org
Subject: Re: FAILED: patch "[PATCH] md: forbid a RAID5 from having both a bitmap and a journal." failed to apply to 4.14-stable tree
Date: Mon, 4 Dec 2017 13:16:39 +0100 [thread overview]
Message-ID: <20171204121639.GF18589@kroah.com> (raw)
In-Reply-To: <877eu9yhc6.fsf@notabene.neil.brown.name>
On Wed, Nov 29, 2017 at 01:00:25PM +1100, NeilBrown wrote:
>
> Subject: [PATCH] md: forbid a RAID5 from having both a bitmap and a journal.
>
> commit 230b55fa8d64007339319539f8f8e68114d08529 upstream.
>
> Having both a bitmap and a journal is pointless.
> Attempting to do so can corrupt the bitmap if the journal
> replay happens before the bitmap is initialized.
> Rather than try to avoid this corruption, simply
> refuse to allow arrays with both a bitmap and a journal.
> So:
> - if raid5_run sees both are present, fail.
> - if adding a bitmap finds a journal is present, fail
> - if adding a journal finds a bitmap is present, fail.
>
> Cc: stable@vger.kernel.org (4.10+)
> Signed-off-by: NeilBrown <neilb@suse.com>
> Tested-by: Joshua Kinard <kumba@gentoo.org>
> Acked-by: Joshua Kinard <kumba@gentoo.org>
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
> drivers/md/bitmap.c | 6 ++++++
> drivers/md/md.c | 2 +-
> drivers/md/raid5.c | 7 +++++++
> 3 files changed, 14 insertions(+), 1 deletion(-)
>
> This commit only had problems due to a filename change.
Oops, I should have caught that one, sorry about that. Thanks for the
patch.
greg k-h
prev parent reply other threads:[~2017-12-04 12:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-27 15:23 FAILED: patch "[PATCH] md: forbid a RAID5 from having both a bitmap and a journal." failed to apply to 4.14-stable tree gregkh
2017-11-29 2:00 ` NeilBrown
2017-12-04 12:16 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204121639.GF18589@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kumba@gentoo.org \
--cc=neilb@suse.com \
--cc=shli@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.