All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoffer Dall <cdall@kernel.org>
To: kvmarm@lists.cs.columbia.edu,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Radim Krčmář" <rkrcmar@redhat.com>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
	kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: [PULL 15/19] KVM: arm/arm64: Avoid attempting to load timer vgic state without a vgic
Date: Mon,  4 Dec 2017 15:03:44 +0100	[thread overview]
Message-ID: <20171204140348.21965-13-cdall@kernel.org> (raw)
In-Reply-To: <20171204135637.21620-1-cdall@kernel.org>

From: Christoffer Dall <christoffer.dall@linaro.org>

The timer optimization patches inadvertendly changed the logic to always
load the timer state as if we have a vgic, even if we don't have a vgic.

Fix this by doing the usual irqchip_in_kernel() check and call the
appropriate load function.

Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
 virt/kvm/arm/arch_timer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c
index 190c99ed1b73..f9555b1e7f15 100644
--- a/virt/kvm/arm/arch_timer.c
+++ b/virt/kvm/arm/arch_timer.c
@@ -835,7 +835,10 @@ int kvm_timer_enable(struct kvm_vcpu *vcpu)
 no_vgic:
 	preempt_disable();
 	timer->enabled = 1;
-	kvm_timer_vcpu_load_vgic(vcpu);
+	if (!irqchip_in_kernel(vcpu->kvm))
+		kvm_timer_vcpu_load_user(vcpu);
+	else
+		kvm_timer_vcpu_load_vgic(vcpu);
 	preempt_enable();
 
 	return 0;
-- 
2.14.2

WARNING: multiple messages have this Message-ID (diff)
From: cdall@kernel.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PULL 15/19] KVM: arm/arm64: Avoid attempting to load timer vgic state without a vgic
Date: Mon,  4 Dec 2017 15:03:44 +0100	[thread overview]
Message-ID: <20171204140348.21965-13-cdall@kernel.org> (raw)
In-Reply-To: <20171204135637.21620-1-cdall@kernel.org>

From: Christoffer Dall <christoffer.dall@linaro.org>

The timer optimization patches inadvertendly changed the logic to always
load the timer state as if we have a vgic, even if we don't have a vgic.

Fix this by doing the usual irqchip_in_kernel() check and call the
appropriate load function.

Signed-off-by: Christoffer Dall <christoffer.dall@linaro.org>
---
 virt/kvm/arm/arch_timer.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/virt/kvm/arm/arch_timer.c b/virt/kvm/arm/arch_timer.c
index 190c99ed1b73..f9555b1e7f15 100644
--- a/virt/kvm/arm/arch_timer.c
+++ b/virt/kvm/arm/arch_timer.c
@@ -835,7 +835,10 @@ int kvm_timer_enable(struct kvm_vcpu *vcpu)
 no_vgic:
 	preempt_disable();
 	timer->enabled = 1;
-	kvm_timer_vcpu_load_vgic(vcpu);
+	if (!irqchip_in_kernel(vcpu->kvm))
+		kvm_timer_vcpu_load_user(vcpu);
+	else
+		kvm_timer_vcpu_load_vgic(vcpu);
 	preempt_enable();
 
 	return 0;
-- 
2.14.2

  parent reply	other threads:[~2017-12-04 14:01 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-04 13:56 [PULL 00/19] KVM/ARM Fixes for v4.15 Christoffer Dall
2017-12-04 13:56 ` Christoffer Dall
2017-12-04 13:56 ` [PULL 01/19] KVM: arm/arm64: Don't enable/disable physical timer access on VHE Christoffer Dall
2017-12-04 13:56   ` Christoffer Dall
2017-12-04 13:56 ` [PULL 02/19] KVM: arm/arm64: VGIC: extend !vgic_is_initialized guard Christoffer Dall
2017-12-04 13:56   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 03/19] KVM: arm/arm64: vgic-irqfd: Fix MSI entry allocation Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 04/19] KVM: arm/arm64: vgic: Preserve the revious read from the pending table Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 05/19] KVM: arm/arm64: vgic-its: " Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 06/19] KVM: arm/arm64: vgic-its: Check result of allocation before use Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 07/19] KVM: arm/arm64: vgic-v4: Only perform an unmap for valid vLPIs Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 08/19] arm64: KVM: fix VTTBR_BADDR_MASK BUG_ON off-by-one Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 09/19] arm: KVM: Fix " Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 10/19] KVM: arm/arm64: debug: Introduce helper for single-step Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 11/19] kvm: arm64: handle single-stepping trapped instructions Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 12/19] kvm: arm64: handle single-step of userspace mmio instructions Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 13/19] kvm: arm64: handle single-step during SError exceptions Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 14/19] kvm: arm64: handle single-step of hyp emulated mmio instructions Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` Christoffer Dall [this message]
2017-12-04 14:03   ` [PULL 15/19] KVM: arm/arm64: Avoid attempting to load timer vgic state without a vgic Christoffer Dall
2017-12-04 14:03 ` [PULL 16/19] kvm: arm: don't treat unavailable HYP mode as an error Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 17/19] KVM: arm/arm64: Fix spinlock acquisition in vgic_set_owner Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 18/19] KVM: arm/arm64: kvm_arch_destroy_vm cleanups Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03 ` [PULL 19/19] KVM: arm/arm64: Fix broken GICH_ELRSR big endian conversion Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-04 14:03   ` Christoffer Dall
2017-12-05 17:59 ` [PULL 00/19] KVM/ARM Fixes for v4.15 Radim Krčmář
2017-12-05 17:59   ` Radim Krčmář

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171204140348.21965-13-cdall@kernel.org \
    --to=cdall@kernel.org \
    --cc=kvm@vger.kernel.org \
    --cc=kvmarm@lists.cs.columbia.edu \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=pbonzini@redhat.com \
    --cc=rkrcmar@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.