From: Christoffer Dall <cdall@kernel.org>
To: "Gomonovych, Vasyl" <gomonovych@gmail.com>
Cc: Christoffer Dall <cdall@linaro.org>,
Christoffer Dall <christoffer.dall@linaro.org>,
marc.zyngier@arm.com, eric.auger@redhat.com,
andre.przywara@arm.com, wanghaibin.wang@huawei.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: arm: Use PTR_ERR_OR_ZERO()
Date: Mon, 4 Dec 2017 20:40:49 +0100 [thread overview]
Message-ID: <20171204194049.GH32397@cbox> (raw)
In-Reply-To: <CAHYXAnL3DVkDMF03QRV62RCFzmViDGYR2rQHBS44jyCo2FRgqw@mail.gmail.com>
On Mon, Dec 04, 2017 at 12:11:22PM +0100, Gomonovych, Vasyl wrote:
> Hi Christoffer
>
> It is just syntax sugar of course
> and in mentioned function context it looks harmonically because it is
> in the end of function return statement.
> But in context of around source files it is looks not so harmonically because
> existing code uses old approach.
> And this old approach is only in one place here.
> So it is just a try to fix the warning and may be force to use it in a
> future changes.
ok, thanks.
-Christoffer
WARNING: multiple messages have this Message-ID (diff)
From: cdall@kernel.org (Christoffer Dall)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] KVM: arm: Use PTR_ERR_OR_ZERO()
Date: Mon, 4 Dec 2017 20:40:49 +0100 [thread overview]
Message-ID: <20171204194049.GH32397@cbox> (raw)
In-Reply-To: <CAHYXAnL3DVkDMF03QRV62RCFzmViDGYR2rQHBS44jyCo2FRgqw@mail.gmail.com>
On Mon, Dec 04, 2017 at 12:11:22PM +0100, Gomonovych, Vasyl wrote:
> Hi Christoffer
>
> It is just syntax sugar of course
> and in mentioned function context it looks harmonically because it is
> in the end of function return statement.
> But in context of around source files it is looks not so harmonically because
> existing code uses old approach.
> And this old approach is only in one place here.
> So it is just a try to fix the warning and may be force to use it in a
> future changes.
ok, thanks.
-Christoffer
next prev parent reply other threads:[~2017-12-04 19:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-28 22:48 [PATCH] KVM: arm: Use PTR_ERR_OR_ZERO() Vasyl Gomonovych
2017-11-28 22:48 ` Vasyl Gomonovych
2017-12-01 8:00 ` Christoffer Dall
2017-12-01 8:00 ` Christoffer Dall
2017-12-01 8:00 ` Christoffer Dall
2017-12-04 11:11 ` Gomonovych, Vasyl
2017-12-04 11:11 ` Gomonovych, Vasyl
2017-12-04 19:40 ` Christoffer Dall [this message]
2017-12-04 19:40 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171204194049.GH32397@cbox \
--to=cdall@kernel.org \
--cc=andre.przywara@arm.com \
--cc=cdall@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=eric.auger@redhat.com \
--cc=gomonovych@gmail.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=wanghaibin.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.