All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel/stop_machine: fix (de)reference function pointer
@ 2017-12-05  5:02 Liu, Changcheng
  0 siblings, 0 replies; only message in thread
From: Liu, Changcheng @ 2017-12-05  5:02 UTC (permalink / raw)
  To: paulmck, mingo, tglx, bigeasy; +Cc: linux-kernel, akpm, changcheng.liu

It's better to avoid ambiguity when (de)referencing function
pointer.

Signed-off-by: Liu Changcheng <changcheng.liu@intel.com>

diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index b759126..121d6aa 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -577,7 +577,7 @@ int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data,
 
 		local_irq_save(flags);
 		hard_irq_disable();
-		ret = (*fn)(data);
+		ret = fn(data);
 		local_irq_restore(flags);
 
 		return ret;
-- 
2.7.4

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2017-12-05  5:04 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-12-05  5:02 [PATCH] kernel/stop_machine: fix (de)reference function pointer Liu, Changcheng

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.