From: linux@roeck-us.net (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [v2] mfd: stm32: Adopt SPDX identifier
Date: Tue, 5 Dec 2017 09:23:37 -0800 [thread overview]
Message-ID: <20171205172337.GA24480@roeck-us.net> (raw)
In-Reply-To: <20171205152418.28104-1-benjamin.gaignard@st.com>
On Tue, Dec 05, 2017 at 04:24:18PM +0100, benjamin.gaignard at linaro.org wrote:
> Add SPDX identifier
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/mfd/stm32-lptimer.c | 6 +-----
> drivers/mfd/stm32-timers.c | 4 +---
> include/linux/mfd/stm32-lptimer.h | 6 +-----
> include/linux/mfd/stm32-timers.h | 4 +---
> 4 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mfd/stm32-lptimer.c b/drivers/mfd/stm32-lptimer.c
> index 075330a25f61..a00f99f36559 100644
> --- a/drivers/mfd/stm32-lptimer.c
> +++ b/drivers/mfd/stm32-lptimer.c
> @@ -1,13 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
I have been wondering - why is the SPDX identifier for the most part added
as separate C++ comment at the beginning of the file, and not inline with
the rest of the top comments ? SPDX doesn't mandate this - the examples
I can find on the SPDX web site all show it inline. Is there a special
Linux kernel convention ?
Thanks,
Guenter
> * STM32 Low-Power Timer parent driver.
> - *
> * Copyright (C) STMicroelectronics 2017
> - *
> * Author: Fabrice Gasnier <fabrice.gasnier@st.com>
> - *
> * Inspired by Benjamin Gaignard's stm32-timers driver
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #include <linux/mfd/stm32-lptimer.h>
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index a6675a449409..1d347e5dfa79 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -1,9 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (C) STMicroelectronics 2016
> - *
> * Author: Benjamin Gaignard <benjamin.gaignard@st.com>
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #include <linux/mfd/stm32-timers.h>
> diff --git a/include/linux/mfd/stm32-lptimer.h b/include/linux/mfd/stm32-lptimer.h
> index 77c7cf40d9b4..605f62264825 100644
> --- a/include/linux/mfd/stm32-lptimer.h
> +++ b/include/linux/mfd/stm32-lptimer.h
> @@ -1,13 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * STM32 Low-Power Timer parent driver.
> - *
> * Copyright (C) STMicroelectronics 2017
> - *
> * Author: Fabrice Gasnier <fabrice.gasnier@st.com>
> - *
> * Inspired by Benjamin Gaignard's stm32-timers driver
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #ifndef _LINUX_STM32_LPTIMER_H_
> diff --git a/include/linux/mfd/stm32-timers.h b/include/linux/mfd/stm32-timers.h
> index ce7346e7f77a..2aadab6f34a1 100644
> --- a/include/linux/mfd/stm32-timers.h
> +++ b/include/linux/mfd/stm32-timers.h
> @@ -1,9 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) STMicroelectronics 2016
> - *
> * Author: Benjamin Gaignard <benjamin.gaignard@st.com>
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #ifndef _LINUX_STM32_GPTIMER_H_
WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: benjamin.gaignard@linaro.org
Cc: lee.jones@linaro.org, alexandre.torgue@st.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [v2] mfd: stm32: Adopt SPDX identifier
Date: Tue, 5 Dec 2017 09:23:37 -0800 [thread overview]
Message-ID: <20171205172337.GA24480@roeck-us.net> (raw)
In-Reply-To: <20171205152418.28104-1-benjamin.gaignard@st.com>
On Tue, Dec 05, 2017 at 04:24:18PM +0100, benjamin.gaignard@linaro.org wrote:
> Add SPDX identifier
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/mfd/stm32-lptimer.c | 6 +-----
> drivers/mfd/stm32-timers.c | 4 +---
> include/linux/mfd/stm32-lptimer.h | 6 +-----
> include/linux/mfd/stm32-timers.h | 4 +---
> 4 files changed, 4 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mfd/stm32-lptimer.c b/drivers/mfd/stm32-lptimer.c
> index 075330a25f61..a00f99f36559 100644
> --- a/drivers/mfd/stm32-lptimer.c
> +++ b/drivers/mfd/stm32-lptimer.c
> @@ -1,13 +1,9 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
I have been wondering - why is the SPDX identifier for the most part added
as separate C++ comment at the beginning of the file, and not inline with
the rest of the top comments ? SPDX doesn't mandate this - the examples
I can find on the SPDX web site all show it inline. Is there a special
Linux kernel convention ?
Thanks,
Guenter
> * STM32 Low-Power Timer parent driver.
> - *
> * Copyright (C) STMicroelectronics 2017
> - *
> * Author: Fabrice Gasnier <fabrice.gasnier@st.com>
> - *
> * Inspired by Benjamin Gaignard's stm32-timers driver
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #include <linux/mfd/stm32-lptimer.h>
> diff --git a/drivers/mfd/stm32-timers.c b/drivers/mfd/stm32-timers.c
> index a6675a449409..1d347e5dfa79 100644
> --- a/drivers/mfd/stm32-timers.c
> +++ b/drivers/mfd/stm32-timers.c
> @@ -1,9 +1,7 @@
> +// SPDX-License-Identifier: GPL-2.0
> /*
> * Copyright (C) STMicroelectronics 2016
> - *
> * Author: Benjamin Gaignard <benjamin.gaignard@st.com>
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #include <linux/mfd/stm32-timers.h>
> diff --git a/include/linux/mfd/stm32-lptimer.h b/include/linux/mfd/stm32-lptimer.h
> index 77c7cf40d9b4..605f62264825 100644
> --- a/include/linux/mfd/stm32-lptimer.h
> +++ b/include/linux/mfd/stm32-lptimer.h
> @@ -1,13 +1,9 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * STM32 Low-Power Timer parent driver.
> - *
> * Copyright (C) STMicroelectronics 2017
> - *
> * Author: Fabrice Gasnier <fabrice.gasnier@st.com>
> - *
> * Inspired by Benjamin Gaignard's stm32-timers driver
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #ifndef _LINUX_STM32_LPTIMER_H_
> diff --git a/include/linux/mfd/stm32-timers.h b/include/linux/mfd/stm32-timers.h
> index ce7346e7f77a..2aadab6f34a1 100644
> --- a/include/linux/mfd/stm32-timers.h
> +++ b/include/linux/mfd/stm32-timers.h
> @@ -1,9 +1,7 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> /*
> * Copyright (C) STMicroelectronics 2016
> - *
> * Author: Benjamin Gaignard <benjamin.gaignard@st.com>
> - *
> - * License terms: GNU General Public License (GPL), version 2
> */
>
> #ifndef _LINUX_STM32_GPTIMER_H_
next prev parent reply other threads:[~2017-12-05 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 15:24 [PATCH v2] mfd: stm32: Adopt SPDX identifier Benjamin Gaignard
2017-12-05 15:24 ` Benjamin Gaignard
2017-12-05 17:23 ` Guenter Roeck [this message]
2017-12-05 17:23 ` [v2] " Guenter Roeck
2017-12-05 17:28 ` Greg KH
2017-12-05 17:28 ` Greg KH
2017-12-05 18:07 ` Guenter Roeck
2017-12-05 18:07 ` Guenter Roeck
2017-12-07 10:36 ` [PATCH v2] " Lee Jones
2017-12-07 10:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205172337.GA24480@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.