From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Ross Zwisler <ross.zwisler@linux.intel.com>,
fstests <fstests@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>,
linux-nvdimm <linux-nvdimm@lists.01.org>, Jan Kara <jack@suse.cz>,
Dave Chinner <david@fromorbit.com>,
Dan Williams <dan.j.williams@intel.com>,
Amir Goldstein <amir73il@gmail.com>
Subject: Re: [fstests PATCH v4 3/4] dm-log-writes: allow DAX to be used when possible
Date: Tue, 5 Dec 2017 16:21:36 -0700 [thread overview]
Message-ID: <20171205232136.GA9541@linux.intel.com> (raw)
In-Reply-To: <20171118061703.GD2749@eguan.usersys.redhat.com>
On Sat, Nov 18, 2017 at 02:17:03PM +0800, Eryu Guan wrote:
> On Fri, Nov 17, 2017 at 01:28:27PM -0700, Ross Zwisler wrote:
> > Enhance _require_dm_target so that a user can request a minimum version of a
> > given dm target.
> >
> > DAX support was added to v1.1.0 of the dm-log-writes kernel module, so
> > allow the DAX mount option starting with that version.
>
> Is is possible not relying on the version numbers but actually trying
> what you want to do and _notrun if that fails? Currently fstests does no
> version number checking at all, and it'd be great if we keep that
> tradition.
Yep, and I agree that this is better. I'll be fixed in the next version.
Thanks for the feedback.
WARNING: multiple messages have this Message-ID (diff)
From: Ross Zwisler <ross.zwisler@linux.intel.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Jan Kara <jack@suse.cz>, linux-nvdimm <linux-nvdimm@lists.01.org>,
Amir Goldstein <amir73il@gmail.com>,
Dave Chinner <david@fromorbit.com>,
fstests <fstests@vger.kernel.org>,
linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [fstests PATCH v4 3/4] dm-log-writes: allow DAX to be used when possible
Date: Tue, 5 Dec 2017 16:21:36 -0700 [thread overview]
Message-ID: <20171205232136.GA9541@linux.intel.com> (raw)
In-Reply-To: <20171118061703.GD2749@eguan.usersys.redhat.com>
On Sat, Nov 18, 2017 at 02:17:03PM +0800, Eryu Guan wrote:
> On Fri, Nov 17, 2017 at 01:28:27PM -0700, Ross Zwisler wrote:
> > Enhance _require_dm_target so that a user can request a minimum version of a
> > given dm target.
> >
> > DAX support was added to v1.1.0 of the dm-log-writes kernel module, so
> > allow the DAX mount option starting with that version.
>
> Is is possible not relying on the version numbers but actually trying
> what you want to do and _notrun if that fails? Currently fstests does no
> version number checking at all, and it'd be great if we keep that
> tradition.
Yep, and I agree that this is better. I'll be fixed in the next version.
Thanks for the feedback.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
next prev parent reply other threads:[~2017-12-05 23:21 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-17 20:28 [fstests PATCH v4 0/4] add test for DAX MAP_SYNC support Ross Zwisler
2017-11-17 20:28 ` Ross Zwisler
2017-11-17 20:28 ` [fstests PATCH v4 1/4] common/rc: add _scratch_has_mount_option() Ross Zwisler
2017-11-17 20:28 ` Ross Zwisler
2017-11-17 20:28 ` [fstests PATCH v4 2/4] dm-log-writes: only replay log to marks that exist Ross Zwisler
2017-11-17 20:28 ` Ross Zwisler
2017-11-18 3:51 ` Eryu Guan
2017-11-18 3:51 ` Eryu Guan
2017-11-17 20:28 ` [fstests PATCH v4 3/4] dm-log-writes: allow DAX to be used when possible Ross Zwisler
2017-11-17 20:28 ` Ross Zwisler
2017-11-18 6:17 ` Eryu Guan
2017-11-18 6:17 ` Eryu Guan
2017-12-05 23:21 ` Ross Zwisler [this message]
2017-12-05 23:21 ` Ross Zwisler
2017-11-17 20:28 ` [fstests PATCH v4 4/4] generic: add test for DAX MAP_SYNC support Ross Zwisler
2017-11-17 20:28 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171205232136.GA9541@linux.intel.com \
--to=ross.zwisler@linux.intel.com \
--cc=amir73il@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jack@suse.cz \
--cc=linux-nvdimm@lists.01.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.