From: Alexey Dobriyan <adobriyan@gmail.com>
To: sergey.senozhatsky.work@gmail.com
Cc: linux-kernel@vger.kernel.org, torvalds@linux-foundation.org, me@tobin.cc
Subject: Re: [PATCH V11 4/5] vsprintf: add printk specifier %px
Date: Wed, 6 Dec 2017 07:19:24 +0300 [thread overview]
Message-ID: <20171206041924.GA2959@avx2> (raw)
> more %p grepping [filtering out all `%ps %pf %pb' variants] gives
> a huge number of print outs that potentially can be broken now
Because people who introduce this stupid %p hashing can't be bothered
to actually audit users:
static int show_timer(struct seq_file *m, void *v)
{
...
seq_printf(m, "signal: %d/%p\n",
timer->sigq->info.si_signo,
timer->sigq->info.si_value.sival_ptr);
Overall, this %px thing doesn't matter. Developers will quickly learn
than %p gives some useless irreversible values and start using %px
everywhere. Soon someone will use %px in the wrong place and new
non-standard format specifier will be added.
next reply other threads:[~2017-12-06 4:20 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-06 4:19 Alexey Dobriyan [this message]
2017-12-06 4:40 ` [PATCH V11 4/5] vsprintf: add printk specifier %px Linus Torvalds
2017-12-16 20:26 ` Tobin C. Harding
-- strict thread matches above, loose matches on Subject: below --
2017-11-29 2:05 [kernel-hardening] [PATCH V11 0/5] hash addresses printed with %p Tobin C. Harding
2017-11-29 2:05 ` [PATCH V11 4/5] vsprintf: add printk specifier %px Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:29 ` Linus Torvalds
2017-11-29 2:29 ` Linus Torvalds
2017-11-29 4:29 ` Tobin C. Harding
2017-11-29 4:29 ` Tobin C. Harding
2017-11-29 10:07 ` David Laight
2017-11-29 10:07 ` David Laight
2017-11-29 22:28 ` Kees Cook
2017-11-29 22:28 ` Kees Cook
2017-11-29 22:36 ` Roberts, William C
2017-11-29 22:36 ` Roberts, William C
2017-11-29 22:47 ` Linus Torvalds
2017-11-29 22:47 ` Linus Torvalds
2017-11-30 10:38 ` David Laight
2017-11-30 10:38 ` David Laight
2017-12-05 21:08 ` Randy Dunlap
2017-12-05 21:08 ` Randy Dunlap
2017-12-05 21:22 ` Linus Torvalds
2017-12-05 21:22 ` Linus Torvalds
2017-12-06 1:36 ` Sergey Senozhatsky
2017-12-06 1:36 ` Sergey Senozhatsky
2017-12-06 1:59 ` Linus Torvalds
2017-12-06 1:59 ` Linus Torvalds
2017-12-06 2:15 ` Sergey Senozhatsky
2017-12-06 2:15 ` Sergey Senozhatsky
2017-12-06 8:32 ` Geert Uytterhoeven
2017-12-06 8:32 ` Geert Uytterhoeven
2017-12-06 8:45 ` Sergey Senozhatsky
2017-12-06 8:45 ` Sergey Senozhatsky
2017-12-07 5:17 ` Tobin C. Harding
2017-12-07 5:17 ` Tobin C. Harding
2017-12-07 5:29 ` Linus Torvalds
2017-12-07 5:37 ` Sergey Senozhatsky
2017-12-07 5:37 ` Sergey Senozhatsky
2017-12-07 5:12 ` Tobin C. Harding
2017-12-07 5:12 ` Tobin C. Harding
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:26 ` Tobin C. Harding
2017-11-29 23:26 ` Tobin C. Harding
2017-11-30 3:58 ` Joe Perches
2017-11-30 3:58 ` Joe Perches
2017-11-30 4:18 ` Tobin C. Harding
2017-11-30 4:18 ` Tobin C. Harding
2017-11-30 4:41 ` Joe Perches
2017-11-30 4:41 ` Joe Perches
2017-11-30 5:00 ` Tobin C. Harding
2017-11-30 5:00 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206041924.GA2959@avx2 \
--to=adobriyan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.