From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: "Sergey Senozhatsky" <sergey.senozhatsky.work@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"David Laight" <David.Laight@aculab.com>,
"Kees Cook" <keescook@chromium.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Tycho Andersen" <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
"Tejun Heo" <tj@kernel.org>,
"Jordan Glover" <Golden_Miller83@protonmail.ch>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Petr Mladek" <pmladek@suse.com>, "Joe Perches" <joe@perches.com>,
"Ian Campbell" <ijc@hellion.org.uk>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <wilal.deacon@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Chris Fries" <cfries@google.com>,
"Dave Weinstein" <olorin@google.com>,
"Daniel Micay" <danielmicay@gmail.com>,
"Djalal Harouni" <tixxdz@gmail.com>,
"Radim Krcmár" <rkrcmar@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
"Alexander Potapenko" <glider@google.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: [kernel-hardening] Re: [PATCH V11 4/5] vsprintf: add printk specifier %px
Date: Thu, 7 Dec 2017 14:37:55 +0900 [thread overview]
Message-ID: <20171207053755.GC6084@jagdpanzerIV> (raw)
In-Reply-To: <20171207051711.GB2191@eros>
On (12/07/17 16:17), Tobin C. Harding wrote:
[..]
> > hm, indeed. and !CONFIG_KALLSYMS config turns %pS/%ps
> > into special_hex_number().
>
> But totally misses this :(
>
> "<no-sym>" would be better returned when !CONFIG_KALLSYMS, right?
I guess I'll take back my comment.
I assume there are tons of embedded devices that have !CONFIG_KALLSYMS
in 'release' builds, yet those devices still warn/oops sometimes; having
pointers/hex numbers is really the only way to make any sense out of
backtraces... yet it, basically, means that we are leaking kernel pointers.
-ss
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: "Sergey Senozhatsky" <sergey.senozhatsky.work@gmail.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Linus Torvalds" <torvalds@linux-foundation.org>,
"Randy Dunlap" <rdunlap@infradead.org>,
"David Laight" <David.Laight@aculab.com>,
"Kees Cook" <keescook@chromium.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
"Theodore Ts'o" <tytso@mit.edu>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Tycho Andersen" <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
"Tejun Heo" <tj@kernel.org>,
"Jordan Glover" <Golden_Miller83@protonmail.ch>,
"Greg KH" <gregkh@linuxfoundation.org>,
"Petr Mladek" <pmladek@suse.com>, "Joe Perches" <joe@perches.com>,
"Ian Campbell" <ijc@hellion.org.uk>,
"Sergey Senozhatsky" <sergey.senozhatsky@gmail.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <wilal.deacon@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Chris Fries" <cfries@google.com>,
"Dave Weinstein" <olorin@google.com>,
"Daniel Micay" <danielmicay@gmail.com>,
"Djalal Harouni" <tixxdz@gmail.com>,
"Radim Krcmár" <rkrcmar@redhat.com>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Network Development" <netdev@vger.kernel.org>,
"David Miller" <davem@davemloft.net>,
"Stephen Rothwell" <sfr@canb.auug.org.au>,
"Andrey Ryabinin" <aryabinin@virtuozzo.com>,
"Alexander Potapenko" <glider@google.com>,
"Dmitry Vyukov" <dvyukov@google.com>,
"Andrew Morton" <akpm@linux-foundation.org>
Subject: Re: [PATCH V11 4/5] vsprintf: add printk specifier %px
Date: Thu, 7 Dec 2017 14:37:55 +0900 [thread overview]
Message-ID: <20171207053755.GC6084@jagdpanzerIV> (raw)
In-Reply-To: <20171207051711.GB2191@eros>
On (12/07/17 16:17), Tobin C. Harding wrote:
[..]
> > hm, indeed. and !CONFIG_KALLSYMS config turns %pS/%ps
> > into special_hex_number().
>
> But totally misses this :(
>
> "<no-sym>" would be better returned when !CONFIG_KALLSYMS, right?
I guess I'll take back my comment.
I assume there are tons of embedded devices that have !CONFIG_KALLSYMS
in 'release' builds, yet those devices still warn/oops sometimes; having
pointers/hex numbers is really the only way to make any sense out of
backtraces... yet it, basically, means that we are leaking kernel pointers.
-ss
WARNING: multiple messages have this Message-ID (diff)
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: "Tobin C. Harding" <me@tobin.cc>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
David Laight <David.Laight@aculab.com>,
Kees Cook <keescook@chromium.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Theodore Ts'o <tytso@mit.edu>,
Paolo Bonzini <pbonzini@redhat.com>,
Tycho Andersen <tycho@tycho.ws>,
"Roberts, William C" <william.c.roberts@intel.com>,
Tejun Heo <tj@kernel.org>,
Jordan Glover <Golden_Miller83@protonmail.ch>,
Greg KH <gregkh@linuxfoundation.org>,
Petr Mladek <pmladek@suse.com>, Joe Perches <joe@perches.com>,
Ian Campbell <ijc@hellion.org.uk>,
Sergey Seno
Subject: Re: [PATCH V11 4/5] vsprintf: add printk specifier %px
Date: Thu, 7 Dec 2017 14:37:55 +0900 [thread overview]
Message-ID: <20171207053755.GC6084@jagdpanzerIV> (raw)
In-Reply-To: <20171207051711.GB2191@eros>
On (12/07/17 16:17), Tobin C. Harding wrote:
[..]
> > hm, indeed. and !CONFIG_KALLSYMS config turns %pS/%ps
> > into special_hex_number().
>
> But totally misses this :(
>
> "<no-sym>" would be better returned when !CONFIG_KALLSYMS, right?
I guess I'll take back my comment.
I assume there are tons of embedded devices that have !CONFIG_KALLSYMS
in 'release' builds, yet those devices still warn/oops sometimes; having
pointers/hex numbers is really the only way to make any sense out of
backtraces... yet it, basically, means that we are leaking kernel pointers.
-ss
next prev parent reply other threads:[~2017-12-07 5:37 UTC|newest]
Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-29 2:05 [kernel-hardening] [PATCH V11 0/5] hash addresses printed with %p Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` [kernel-hardening] [PATCH V11 1/5] docs: correct documentation for %pK Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` [kernel-hardening] [PATCH V11 2/5] vsprintf: refactor %pK code out of pointer() Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:39 ` [kernel-hardening] " Steven Rostedt
2017-11-29 2:39 ` Steven Rostedt
2017-11-29 2:39 ` Steven Rostedt
2017-11-29 4:27 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 4:27 ` Tobin C. Harding
2017-11-29 4:27 ` Tobin C. Harding
2017-11-29 11:54 ` [kernel-hardening] " Steven Rostedt
2017-11-29 11:54 ` Steven Rostedt
2017-11-29 11:54 ` Steven Rostedt
2017-11-29 2:05 ` [kernel-hardening] [PATCH V11 3/5] printk: hash addresses printed with %p Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 23:21 ` [kernel-hardening] " Andrew Morton
2017-11-29 23:21 ` Andrew Morton
2017-11-29 23:21 ` Andrew Morton
2017-12-05 20:20 ` [kernel-hardening] " Geert Uytterhoeven
2017-12-05 20:20 ` Geert Uytterhoeven
2017-12-05 20:20 ` Geert Uytterhoeven
2017-12-05 20:31 ` [kernel-hardening] " David Miller
2017-12-05 20:31 ` David Miller
2017-12-06 10:31 ` [kernel-hardening] " David Laight
2017-12-06 10:31 ` David Laight
2017-12-06 10:31 ` David Laight
2017-12-06 23:21 ` [kernel-hardening] " Kees Cook
2017-12-06 23:21 ` Kees Cook
2017-12-06 23:21 ` Kees Cook
2017-12-06 23:28 ` [kernel-hardening] " Linus Torvalds
2017-12-06 23:28 ` Linus Torvalds
2017-12-06 23:28 ` Linus Torvalds
2017-12-05 20:44 ` [kernel-hardening] " Tobin C. Harding
2017-12-05 20:44 ` Tobin C. Harding
2017-12-05 20:44 ` Tobin C. Harding
2017-12-05 22:57 ` [kernel-hardening] " Geert Uytterhoeven
2017-12-05 22:57 ` Geert Uytterhoeven
2017-12-05 22:57 ` Geert Uytterhoeven
2017-12-05 23:33 ` [kernel-hardening] " Linus Torvalds
2017-12-05 23:33 ` Linus Torvalds
2017-12-05 23:33 ` Linus Torvalds
2017-12-06 8:48 ` [kernel-hardening] " Geert Uytterhoeven
2017-12-06 8:48 ` Geert Uytterhoeven
2017-12-06 8:48 ` Geert Uytterhoeven
2017-11-29 2:05 ` [kernel-hardening] [PATCH V11 4/5] vsprintf: add printk specifier %px Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:29 ` [kernel-hardening] " Linus Torvalds
2017-11-29 2:29 ` Linus Torvalds
2017-11-29 2:29 ` Linus Torvalds
2017-11-29 4:29 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 4:29 ` Tobin C. Harding
2017-11-29 4:29 ` Tobin C. Harding
2017-11-29 10:07 ` [kernel-hardening] " David Laight
2017-11-29 10:07 ` David Laight
2017-11-29 10:07 ` David Laight
2017-11-29 22:28 ` [kernel-hardening] " Kees Cook
2017-11-29 22:28 ` Kees Cook
2017-11-29 22:28 ` Kees Cook
2017-11-29 22:36 ` [kernel-hardening] " Roberts, William C
2017-11-29 22:36 ` Roberts, William C
2017-11-29 22:36 ` Roberts, William C
2017-11-29 22:47 ` [kernel-hardening] " Linus Torvalds
2017-11-29 22:47 ` Linus Torvalds
2017-11-29 22:47 ` Linus Torvalds
2017-11-30 10:38 ` [kernel-hardening] " David Laight
2017-11-30 10:38 ` David Laight
2017-11-30 10:38 ` David Laight
2017-12-05 21:08 ` [kernel-hardening] " Randy Dunlap
2017-12-05 21:08 ` Randy Dunlap
2017-12-05 21:08 ` Randy Dunlap
2017-12-05 21:22 ` [kernel-hardening] " Linus Torvalds
2017-12-05 21:22 ` Linus Torvalds
2017-12-05 21:22 ` Linus Torvalds
2017-12-06 1:36 ` [kernel-hardening] " Sergey Senozhatsky
2017-12-06 1:36 ` Sergey Senozhatsky
2017-12-06 1:36 ` Sergey Senozhatsky
2017-12-06 1:59 ` [kernel-hardening] " Linus Torvalds
2017-12-06 1:59 ` Linus Torvalds
2017-12-06 1:59 ` Linus Torvalds
2017-12-06 2:15 ` [kernel-hardening] " Sergey Senozhatsky
2017-12-06 2:15 ` Sergey Senozhatsky
2017-12-06 2:15 ` Sergey Senozhatsky
2017-12-06 8:32 ` [kernel-hardening] " Geert Uytterhoeven
2017-12-06 8:32 ` Geert Uytterhoeven
2017-12-06 8:32 ` Geert Uytterhoeven
2017-12-06 8:45 ` [kernel-hardening] " Sergey Senozhatsky
2017-12-06 8:45 ` Sergey Senozhatsky
2017-12-06 8:45 ` Sergey Senozhatsky
2017-12-07 5:17 ` [kernel-hardening] " Tobin C. Harding
2017-12-07 5:17 ` Tobin C. Harding
2017-12-07 5:17 ` Tobin C. Harding
2017-12-07 5:29 ` [kernel-hardening] " Linus Torvalds
2017-12-07 5:29 ` Linus Torvalds
2017-12-07 5:37 ` Sergey Senozhatsky [this message]
2017-12-07 5:37 ` Sergey Senozhatsky
2017-12-07 5:37 ` Sergey Senozhatsky
2017-12-07 5:12 ` [kernel-hardening] " Tobin C. Harding
2017-12-07 5:12 ` Tobin C. Harding
2017-12-07 5:12 ` Tobin C. Harding
2017-11-29 23:20 ` [kernel-hardening] " Andrew Morton
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:26 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 23:26 ` Tobin C. Harding
2017-11-29 23:26 ` Tobin C. Harding
2017-11-30 3:58 ` [kernel-hardening] " Joe Perches
2017-11-30 3:58 ` Joe Perches
2017-11-30 3:58 ` Joe Perches
2017-11-30 4:18 ` [kernel-hardening] " Tobin C. Harding
2017-11-30 4:18 ` Tobin C. Harding
2017-11-30 4:18 ` Tobin C. Harding
2017-11-30 4:41 ` [kernel-hardening] " Joe Perches
2017-11-30 4:41 ` Joe Perches
2017-11-30 4:41 ` Joe Perches
2017-11-30 5:00 ` [kernel-hardening] " Tobin C. Harding
2017-11-30 5:00 ` Tobin C. Harding
2017-11-30 5:00 ` Tobin C. Harding
2017-11-29 2:05 ` [kernel-hardening] [PATCH V11 5/5] kasan: use %px to print addresses instead of %p Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 2:05 ` Tobin C. Harding
2017-11-29 23:20 ` [kernel-hardening] Re: [PATCH V11 0/5] hash addresses printed with %p Andrew Morton
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:20 ` Andrew Morton
2017-11-29 23:34 ` [kernel-hardening] " Tobin C. Harding
2017-11-29 23:34 ` Tobin C. Harding
2017-11-29 23:34 ` Tobin C. Harding
2017-11-30 10:23 ` [kernel-hardening] " David Laight
2017-11-30 10:23 ` David Laight
2017-11-30 10:23 ` David Laight
2017-11-30 10:26 ` [kernel-hardening] " Sergey Senozhatsky
2017-11-30 10:26 ` Sergey Senozhatsky
2017-11-30 10:26 ` Sergey Senozhatsky
2017-12-01 6:15 ` [kernel-hardening] " Sergey Senozhatsky
2017-12-01 6:15 ` Sergey Senozhatsky
2017-12-01 6:15 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207053755.GC6084@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=David.Laight@aculab.com \
--cc=Golden_Miller83@protonmail.ch \
--cc=Jason@zx2c4.com \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=catalin.marinas@arm.com \
--cc=cfries@google.com \
--cc=danielmicay@gmail.com \
--cc=davem@davemloft.net \
--cc=dvyukov@google.com \
--cc=geert@linux-m68k.org \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=ijc@hellion.org.uk \
--cc=joe@perches.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@tobin.cc \
--cc=netdev@vger.kernel.org \
--cc=olorin@google.com \
--cc=pbonzini@redhat.com \
--cc=pmladek@suse.com \
--cc=rdunlap@infradead.org \
--cc=rkrcmar@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
--cc=tixxdz@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tycho@tycho.ws \
--cc=tytso@mit.edu \
--cc=wilal.deacon@arm.com \
--cc=william.c.roberts@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.