All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Nguyen Phan Quang Minh <minhnpq16@gmail.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro
Date: Wed, 6 Dec 2017 16:19:03 +0100	[thread overview]
Message-ID: <20171206151903.GA11701@kroah.com> (raw)
In-Reply-To: <20171203000949.GA19959@minhnpqrs-antergos>

On Sun, Dec 03, 2017 at 01:09:49AM +0100, Nguyen Phan Quang Minh wrote:
> The macro calls its argument -a function- twice, makes the calling
> function return prematurely -skipping resource cleanup code- and hurts
> understandability.
> 
> Signed-off-by: Nguyen Phan Quang Minh <minhnpq16@gmail.com>
> ---
> Base on Dan's feedback, I checked and the macro return indeed skips over
> some cleanup code, hence remove it.
> The code is not pretty, any hints on how to do it better is greatly
> appreciated.

Please redo this based on Dan's comments.

thanks,

greg k-h

      reply	other threads:[~2017-12-06 15:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-30 21:40 [PATCH] staging: pi433: pi433_if.c Fix SET_CHECKED style issues Nguyen Phan Quang Minh
2017-12-01 14:23 ` Dan Carpenter
2017-12-01 14:26   ` Dan Carpenter
2017-12-03  0:09 ` [PATCHv2] staging: pi433: pi433_if.c remove SET_CHECKED macro Nguyen Phan Quang Minh
2017-12-06 15:19   ` Greg Kroah-Hartman [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171206151903.GA11701@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=minhnpq16@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.