From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Linux MM <linux-mm@kvack.org>, Christoph Hellwig <hch@lst.de>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: Re: [PATCH 2/2] mm: fix dev_pagemap reference counting around get_dev_pagemap
Date: Wed, 6 Dec 2017 23:44:41 +0100 [thread overview]
Message-ID: <20171206224441.GA14274@lst.de> (raw)
In-Reply-To: <CAPcyv4i3RP12-3T8R4tazfVvC+UG-FaUjorcbHnC1OPsc-5+YQ@mail.gmail.com>
On Tue, Dec 05, 2017 at 06:43:36PM -0800, Dan Williams wrote:
> I don't think we need this change, but perhaps the reasoning should be
> added to the code as a comment... details below.
Hmm, looks like we are ok at least. But even if it's not a correctness
issue there is no good point in decrementing and incrementing the
reference count every time.
_______________________________________________
Linux-nvdimm mailing list
Linux-nvdimm@lists.01.org
https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@lst.de>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: [PATCH 2/2] mm: fix dev_pagemap reference counting around get_dev_pagemap
Date: Wed, 6 Dec 2017 23:44:41 +0100 [thread overview]
Message-ID: <20171206224441.GA14274@lst.de> (raw)
In-Reply-To: <CAPcyv4i3RP12-3T8R4tazfVvC+UG-FaUjorcbHnC1OPsc-5+YQ@mail.gmail.com>
On Tue, Dec 05, 2017 at 06:43:36PM -0800, Dan Williams wrote:
> I don't think we need this change, but perhaps the reasoning should be
> added to the code as a comment... details below.
Hmm, looks like we are ok at least. But even if it's not a correctness
issue there is no good point in decrementing and incrementing the
reference count every time.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-12-06 22:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 0:34 RFC: dev_pagemap reference counting Christoph Hellwig
2017-12-05 0:34 ` Christoph Hellwig
2017-12-05 0:34 ` [PATCH 1/2] mm: move get_dev_pagemap out of line Christoph Hellwig
2017-12-05 0:34 ` Christoph Hellwig
2017-12-05 0:34 ` [PATCH 2/2] mm: fix dev_pagemap reference counting around get_dev_pagemap Christoph Hellwig
2017-12-05 0:34 ` Christoph Hellwig
2017-12-06 2:43 ` Dan Williams
2017-12-06 22:44 ` Christoph Hellwig [this message]
2017-12-06 22:44 ` Christoph Hellwig
2017-12-06 22:52 ` Dan Williams
2017-12-06 22:52 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171206224441.GA14274@lst.de \
--to=hch@lst.de \
--cc=dan.j.williams@intel.com \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.