From: "Tobin C. Harding" <me@tobin.cc>
To: kaiwan.billimoria@gmail.com
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: [kernel-hardening] Re: [PATCH v4] leaking_addresses: add support for x86 32-bit kernel addresses
Date: Thu, 7 Dec 2017 15:32:03 +1100 [thread overview]
Message-ID: <20171207043203.GC3275@eros> (raw)
In-Reply-To: <1512616656.17323.50.camel@gmail.com>
On Thu, Dec 07, 2017 at 08:47:36AM +0530, kaiwan.billimoria@gmail.com wrote:
> Currently, leaking_addresses.pl only supports scanning 64 bit
> architectures. This is due to how the regular expressions are formed. We
> can do better than this. 32 architectures can be supported if we take
> into consideration the kernel virtual address split (via the PAGE_OFFSET
> kernel configurable).
>
> Add support for ix86 32 bit architectures.
> - Add command line option for page offset.
> - Add command line option for kernel configuration file.
> - Parse kernel config file for page offset (CONFIG_PAGE_OFFSET).
> - Use page offset when checking for kernel virtual addresses.
>
>
> Signed-off-by: Kaiwan N Billimoria <kaiwan.billimoria@gmail.com>
> ---
>
> Ok, this patch is the same as the previous v3, with suggestions from Tobin incorporated:
> - newline in sub is_false_positive_ix86_32
> - refactoring of code to remove the temp file in sub get_page_offset
> - git short desc delibrately modified to make it more appropriate.
Cool, this is all good. I'm not going to apply it because of our
previous discussion on doing a general 32 bit implementation. I've just
finished doing some work to lay the ground for that. Posting the patch
set now.
thanks,
Tobin.
WARNING: multiple messages have this Message-ID (diff)
From: "Tobin C. Harding" <me@tobin.cc>
To: kaiwan.billimoria@gmail.com
Cc: Alexander Kapshuk <alexander.kapshuk@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"kernel-hardening@lists.openwall.com"
<kernel-hardening@lists.openwall.com>
Subject: Re: [PATCH v4] leaking_addresses: add support for x86 32-bit kernel addresses
Date: Thu, 7 Dec 2017 15:32:03 +1100 [thread overview]
Message-ID: <20171207043203.GC3275@eros> (raw)
In-Reply-To: <1512616656.17323.50.camel@gmail.com>
On Thu, Dec 07, 2017 at 08:47:36AM +0530, kaiwan.billimoria@gmail.com wrote:
> Currently, leaking_addresses.pl only supports scanning 64 bit
> architectures. This is due to how the regular expressions are formed. We
> can do better than this. 32 architectures can be supported if we take
> into consideration the kernel virtual address split (via the PAGE_OFFSET
> kernel configurable).
>
> Add support for ix86 32 bit architectures.
> - Add command line option for page offset.
> - Add command line option for kernel configuration file.
> - Parse kernel config file for page offset (CONFIG_PAGE_OFFSET).
> - Use page offset when checking for kernel virtual addresses.
>
>
> Signed-off-by: Kaiwan N Billimoria <kaiwan.billimoria@gmail.com>
> ---
>
> Ok, this patch is the same as the previous v3, with suggestions from Tobin incorporated:
> - newline in sub is_false_positive_ix86_32
> - refactoring of code to remove the temp file in sub get_page_offset
> - git short desc delibrately modified to make it more appropriate.
Cool, this is all good. I'm not going to apply it because of our
previous discussion on doing a general 32 bit implementation. I've just
finished doing some work to lay the ground for that. Posting the patch
set now.
thanks,
Tobin.
next prev parent reply other threads:[~2017-12-07 4:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-05 6:26 [kernel-hardening] [PATCH v3] scripts: leaking_addresses: add support for 32-bit kernel addresses kaiwan.billimoria
2017-12-05 6:26 ` kaiwan.billimoria
2017-12-06 4:04 ` [kernel-hardening] " Tobin C. Harding
2017-12-06 4:04 ` Tobin C. Harding
2017-12-06 11:51 ` [kernel-hardening] " kaiwan.billimoria
2017-12-06 11:51 ` kaiwan.billimoria
2017-12-06 12:53 ` [kernel-hardening] " kaiwan.billimoria
2017-12-06 12:53 ` kaiwan.billimoria
2017-12-06 23:03 ` [kernel-hardening] " Tobin C. Harding
2017-12-06 23:03 ` Tobin C. Harding
2017-12-06 23:01 ` [kernel-hardening] " Tobin C. Harding
2017-12-06 23:01 ` Tobin C. Harding
2017-12-07 3:17 ` [kernel-hardening] [PATCH v4] leaking_addresses: add support for x86 " kaiwan.billimoria
2017-12-07 3:17 ` kaiwan.billimoria
2017-12-07 4:32 ` Tobin C. Harding [this message]
2017-12-07 4:32 ` Tobin C. Harding
2017-12-07 4:11 ` [kernel-hardening] Re: [PATCH v3] scripts: leaking_addresses: add support for " kaiwan.billimoria
2017-12-07 4:11 ` kaiwan.billimoria
2017-12-07 5:24 ` [kernel-hardening] " Tobin C. Harding
2017-12-07 5:24 ` Tobin C. Harding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207043203.GC3275@eros \
--to=me@tobin.cc \
--cc=alexander.kapshuk@gmail.com \
--cc=kaiwan.billimoria@gmail.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.