* [PATCH] knotty: Be consistent when creating/updating progress bars
2017-12-07 14:38 [PATCH 1/2] gstreamer1.0.inc: Define a PACKAGECONFIG for examples Peter Kjellerstedt
@ 2017-12-07 14:38 ` Peter Kjellerstedt
2017-12-07 14:38 ` [PATCH 2/2] gstreamer1.0-plugins.inc: Define a PACKAGECONFIG for examples Peter Kjellerstedt
2017-12-07 14:49 ` [PATCH 1/2] gstreamer1.0.inc: " Peter Kjellerstedt
2 siblings, 0 replies; 4+ messages in thread
From: Peter Kjellerstedt @ 2017-12-07 14:38 UTC (permalink / raw)
To: bitbake-devel
When creating a new progress bar (using BBProgress), a colon was
appended to the supplied message. However, when updating the message,
no colon was appended.
Change this so that the colon is instead part of the widgets that make
up the progress bar so that it does not matter when and how the
message is updated, it always displays the same.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
bitbake/lib/bb/ui/knotty.py | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/bitbake/lib/bb/ui/knotty.py b/bitbake/lib/bb/ui/knotty.py
index fa88e6ccdd..a945fc1994 100644
--- a/bitbake/lib/bb/ui/knotty.py
+++ b/bitbake/lib/bb/ui/knotty.py
@@ -45,15 +45,15 @@ class BBProgress(progressbar.ProgressBar):
self.msg = msg
self.extrapos = extrapos
if not widgets:
- widgets = [progressbar.Percentage(), ' ', progressbar.Bar(), ' ',
- progressbar.ETA()]
- self.extrapos = 4
+ widgets = [': ', progressbar.Percentage(), ' ', progressbar.Bar(),
+ ' ', progressbar.ETA()]
+ self.extrapos = 5
if resize_handler:
self._resize_default = resize_handler
else:
self._resize_default = signal.getsignal(signal.SIGWINCH)
- progressbar.ProgressBar.__init__(self, maxval, [self.msg + ": "] + widgets, fd=sys.stdout)
+ progressbar.ProgressBar.__init__(self, maxval, [self.msg] + widgets, fd=sys.stdout)
def _handle_resize(self, signum=None, frame=None):
progressbar.ProgressBar._handle_resize(self, signum, frame)
@@ -248,10 +248,10 @@ class TerminalFilter(object):
start_time = activetasks[t].get("starttime", None)
if not pbar or pbar.bouncing != (progress < 0):
if progress < 0:
- pbar = BBProgress("0: %s (pid %s) " % (activetasks[t]["title"], t), 100, widgets=[progressbar.BouncingSlider(), ''], extrapos=2, resize_handler=self.sigwinch_handle)
+ pbar = BBProgress("0: %s (pid %s)" % (activetasks[t]["title"], t), 100, widgets=[' ', progressbar.BouncingSlider(), ''], extrapos=3, resize_handler=self.sigwinch_handle)
pbar.bouncing = True
else:
- pbar = BBProgress("0: %s (pid %s) " % (activetasks[t]["title"], t), 100, widgets=[progressbar.Percentage(), ' ', progressbar.Bar(), ''], extrapos=4, resize_handler=self.sigwinch_handle)
+ pbar = BBProgress("0: %s (pid %s)" % (activetasks[t]["title"], t), 100, widgets=[' ', progressbar.Percentage(), ' ', progressbar.Bar(), ''], extrapos=5, resize_handler=self.sigwinch_handle)
pbar.bouncing = False
activetasks[t]["progressbar"] = pbar
tasks.append((pbar, progress, rate, start_time))
--
2.12.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] gstreamer1.0-plugins.inc: Define a PACKAGECONFIG for examples
2017-12-07 14:38 [PATCH 1/2] gstreamer1.0.inc: Define a PACKAGECONFIG for examples Peter Kjellerstedt
2017-12-07 14:38 ` [PATCH] knotty: Be consistent when creating/updating progress bars Peter Kjellerstedt
@ 2017-12-07 14:38 ` Peter Kjellerstedt
2017-12-07 14:49 ` [PATCH 1/2] gstreamer1.0.inc: " Peter Kjellerstedt
2 siblings, 0 replies; 4+ messages in thread
From: Peter Kjellerstedt @ 2017-12-07 14:38 UTC (permalink / raw)
To: bitbake-devel
This makes it consistent with, e.g., debug, that can be
enabled/disabled using a PACKAGECONFIG.
Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
---
meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
index c40d398911..32846165c1 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins.inc
@@ -19,15 +19,12 @@ require gst-plugins-package.inc
GSTREAMER_ORC ?= "orc"
PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
+PACKAGECONFIG[examples] = "--enable-examples,--disable-examples"
PACKAGECONFIG[orc] = "--enable-orc,--disable-orc,orc orc-native"
PACKAGECONFIG[valgrind] = "--enable-valgrind,--disable-valgrind,valgrind"
export ORCC = "${STAGING_DIR_NATIVE}${bindir}/orcc"
-EXTRA_OECONF = " \
- --disable-examples \
-"
-
delete_pkg_m4_file() {
# This m4 file is out of date and is missing PKG_CONFIG_SYSROOT_PATH tweaks which we need for introspection
rm "${S}/common/m4/pkg.m4" || true
--
2.12.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 1/2] gstreamer1.0.inc: Define a PACKAGECONFIG for examples
2017-12-07 14:38 [PATCH 1/2] gstreamer1.0.inc: Define a PACKAGECONFIG for examples Peter Kjellerstedt
2017-12-07 14:38 ` [PATCH] knotty: Be consistent when creating/updating progress bars Peter Kjellerstedt
2017-12-07 14:38 ` [PATCH 2/2] gstreamer1.0-plugins.inc: Define a PACKAGECONFIG for examples Peter Kjellerstedt
@ 2017-12-07 14:49 ` Peter Kjellerstedt
2 siblings, 0 replies; 4+ messages in thread
From: Peter Kjellerstedt @ 2017-12-07 14:49 UTC (permalink / raw)
To: bitbake-devel@lists.openembedded.org
Please disregard this patch and the other GStreamer patch in this
series. They were apparently around when I used 0* to gather the
patch I intended to send.
//Peter
> -----Original Message-----
> From: bitbake-devel-bounces@lists.openembedded.org [mailto:bitbake-
> devel-bounces@lists.openembedded.org] On Behalf Of Peter Kjellerstedt
> Sent: den 7 december 2017 15:39
> To: bitbake-devel@lists.openembedded.org
> Subject: [bitbake-devel] [PATCH 1/2] gstreamer1.0.inc: Define a
> PACKAGECONFIG for examples
>
> This makes it consistent with, e.g., debug, that can be
> enabled/disabled using a PACKAGECONFIG.
>
> Signed-off-by: Peter Kjellerstedt <peter.kjellerstedt@axis.com>
> ---
> meta/recipes-multimedia/gstreamer/gstreamer1.0.inc | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> index 329193486d..a3a8207229 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0.inc
> @@ -21,6 +21,7 @@ SRC_URI_append = " \
> PACKAGECONFIG ??= ""
>
> PACKAGECONFIG[debug] = "--enable-debug,--disable-debug"
> +PACKAGECONFIG[examples] = "--enable-examples,--disable-examples"
> PACKAGECONFIG[tests] = "--enable-tests,--disable-tests"
> PACKAGECONFIG[valgrind] = "--enable-valgrind,--disable-
> valgrind,valgrind,"
> PACKAGECONFIG[gst-tracer-hooks] = "--enable-gst-tracer-hooks,--
> disable-gst-tracer-hooks,"
> @@ -29,7 +30,6 @@ PACKAGECONFIG[dw] = "--with-dw,--without-dw,elfutils"
>
> EXTRA_OECONF = " \
> --disable-dependency-tracking \
> - --disable-examples \
> "
>
> CACHED_CONFIGUREVARS += "ac_cv_header_valgrind_valgrind_h=no"
> --
> 2.12.0
>
> --
> _______________________________________________
> bitbake-devel mailing list
> bitbake-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/bitbake-devel
^ permalink raw reply [flat|nested] 4+ messages in thread