From: andrew@lunn.ch (Andrew Lunn)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH net-next v2 3/8] net: phy: meson-gxl: add read and write helpers for bank registers
Date: Thu, 7 Dec 2017 17:02:35 +0100 [thread overview]
Message-ID: <20171207160235.GL24750@lunn.ch> (raw)
In-Reply-To: <1512661873.7042.9.camel@baylibre.com>
> Banks actually comes from the datasheet, Yes.
> I don't mind renaming it but I would be making things up. As you wish ?
Keep it as is for the moment.
> Does the usual pages comes with this weird toggle thing to open the access ?
> Would we able to use these generic helpers with our this kind of quirks ?
I don't think the API has been defined yet. But what has been
discussed is adding functions to struct phy_driver. The driver can
then implement whatever is needed to select a given page. There will
then be helpers which take the lock, select the page, do the
read/write, select page 0, and unlock.
Supporting this funny toggle should not be a problem.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH net-next v2 3/8] net: phy: meson-gxl: add read and write helpers for bank registers
Date: Thu, 7 Dec 2017 17:02:35 +0100 [thread overview]
Message-ID: <20171207160235.GL24750@lunn.ch> (raw)
In-Reply-To: <1512661873.7042.9.camel@baylibre.com>
> Banks actually comes from the datasheet, Yes.
> I don't mind renaming it but I would be making things up. As you wish ?
Keep it as is for the moment.
> Does the usual pages comes with this weird toggle thing to open the access ?
> Would we able to use these generic helpers with our this kind of quirks ?
I don't think the API has been defined yet. But what has been
discussed is adding functions to struct phy_driver. The driver can
then implement whatever is needed to select a given page. There will
then be helpers which take the lock, select the page, do the
read/write, select page 0, and unlock.
Supporting this funny toggle should not be a problem.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
Russell King <rmk+kernel@arm.linux.org.uk>
Subject: Re: [PATCH net-next v2 3/8] net: phy: meson-gxl: add read and write helpers for bank registers
Date: Thu, 7 Dec 2017 17:02:35 +0100 [thread overview]
Message-ID: <20171207160235.GL24750@lunn.ch> (raw)
In-Reply-To: <1512661873.7042.9.camel@baylibre.com>
> Banks actually comes from the datasheet, Yes.
> I don't mind renaming it but I would be making things up. As you wish ?
Keep it as is for the moment.
> Does the usual pages comes with this weird toggle thing to open the access ?
> Would we able to use these generic helpers with our this kind of quirks ?
I don't think the API has been defined yet. But what has been
discussed is adding functions to struct phy_driver. The driver can
then implement whatever is needed to select a given page. There will
then be helpers which take the lock, select the page, do the
read/write, select page 0, and unlock.
Supporting this funny toggle should not be a problem.
Andrew
next prev parent reply other threads:[~2017-12-07 16:02 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 14:27 [PATCH net-next v2 0/8] phy: net: meson-gxl: clean-up and improvements Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 1/8] net: phy: meson-gxl: check phy_write return value Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 14:27 ` [PATCH net-next v2 2/8] net: phy: meson-gxl: define control registers Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 3/8] net: phy: meson-gxl: add read and write helpers for bank registers Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:49 ` Neil Armstrong
2017-12-07 15:49 ` Neil Armstrong
2017-12-07 15:49 ` Neil Armstrong
2017-12-07 15:51 ` Jerome Brunet
2017-12-07 15:51 ` Jerome Brunet
2017-12-07 15:51 ` Jerome Brunet
2017-12-07 16:02 ` Andrew Lunn [this message]
2017-12-07 16:02 ` Andrew Lunn
2017-12-07 16:02 ` Andrew Lunn
2017-12-08 9:11 ` Russell King - ARM Linux
2017-12-08 9:11 ` Russell King - ARM Linux
2017-12-08 9:11 ` Russell King - ARM Linux
2017-12-07 14:27 ` [PATCH net-next v2 4/8] net: phy: meson-gxl: use genphy_config_init Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 15:46 ` Andrew Lunn
2017-12-07 14:27 ` [PATCH net-next v2 5/8] net: phy: meson-gxl: detect LPA corruption Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:34 ` Andrew Lunn
2017-12-07 15:42 ` Jerome Brunet
2017-12-07 15:42 ` Jerome Brunet
2017-12-07 15:42 ` Jerome Brunet
2017-12-07 16:12 ` Andrew Lunn
2017-12-07 16:12 ` Andrew Lunn
2017-12-07 16:12 ` Andrew Lunn
2017-12-07 16:22 ` Jerome Brunet
2017-12-07 16:22 ` Jerome Brunet
2017-12-07 16:22 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 6/8] net: phy: meson-gxl: leave CONFIG_A6 untouched Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:49 ` Andrew Lunn
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 15:56 ` Jerome Brunet
2017-12-07 14:27 ` [PATCH net-next v2 7/8] net: phy: meson-gxl: add interrupt support Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:54 ` Andrew Lunn
2017-12-07 15:54 ` Andrew Lunn
2017-12-07 15:54 ` Andrew Lunn
2017-12-07 16:04 ` Jerome Brunet
2017-12-07 16:04 ` Jerome Brunet
2017-12-07 16:04 ` Jerome Brunet
2017-12-07 16:07 ` Andrew Lunn
2017-12-07 16:07 ` Andrew Lunn
2017-12-07 16:07 ` Andrew Lunn
2017-12-07 14:27 ` [PATCH net-next v2 8/8] net: phy: meson-gxl: join the authors Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 14:27 ` Jerome Brunet
2017-12-07 15:55 ` Andrew Lunn
2017-12-07 15:55 ` Andrew Lunn
2017-12-07 15:55 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171207160235.GL24750@lunn.ch \
--to=andrew@lunn.ch \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.